[Compute] az sig image-definition create: Add warning message for Hyper-V generation and Security Type
#28610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @ZengTaoxu, |
️✔️AzureCLI-BreakingChangeTest
|
|
Compute |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
yanzhudd
reviewed
Mar 25, 2024
Comment on lines
4661
to
4665
| logger.warning( | ||
| "Please note that in the future, the default Hyper-V generation will be changed from V1 to V2 and " | ||
| "Security Type is set to “TrustedLaunchSuppoted” as the default behavior." | ||
| ) | ||
|
|
There was a problem hiding this comment.
Suggested change
| logger.warning( | |
| "Please note that in the future, the default Hyper-V generation will be changed from V1 to V2 and " | |
| "Security Type is set to “TrustedLaunchSuppoted” as the default behavior." | |
| ) | |
| logger.warning( | |
| 'Starting Build (May) 2024, "az sig image-definition create" command will use the new default values Hyper-V Generation: V2 and SecurityType: TrustedLaunchSuppoted.' | |
| ) | |
ZengTaoxu
changed the title
az sig image-definition create: Add warning message for Hyper-V generation and Security Typeaz sig image-definition create: Add warning message for Hyper-V generation and Security Type
|
please convert this PR from draft to ready for review state |
yanzhudd
approved these changes
Mar 26, 2024
johnl2323
reviewed
Apr 26, 2024
| @@ -4658,6 +4658,11 @@ def create_gallery_image(cmd, resource_group_name, gallery_name, gallery_image_n | |||
| minimum_cpu_core=None, maximum_cpu_core=None, minimum_memory=None, maximum_memory=None, | |||
| disallowed_disk_types=None, plan_name=None, plan_publisher=None, plan_product=None, tags=None, | |||
| hyper_v_generation='V1', features=None, architecture=None): | |||
| logger.warning( | |||
| "Starting Build (May) 2024, \"az sig image-definition create\" command will use the new default values " | |||
| "Hyper-V Generation: V2 and SecurityType: TrustedLaunchSuppoted." | |||
There was a problem hiding this comment.
@yanzhudd @ZengTaoxu "TrustedLaunchSuppoted" is spelled incorrectly.
There was a problem hiding this comment.
Hi @johnl2323,
thanks for pointing out, we'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
relate: #28557
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.