Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compute] az sig image-definition create: Add warning message for Hyper-V generation and Security Type #28610

Merged
merged 3 commits into from
Mar 26, 2024
Merged

[Compute] az sig image-definition create: Add warning message for Hyper-V generation and Security Type #28610

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab1ec7e
update
ZengTaoxu Mar 22, 2024
4a7a695
update
ZengTaoxu Mar 25, 2024
ad41ddb
Merge branch 'dev' of https://github.com/Azure/azure-cli into image-d…
ZengTaoxu Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/azure-cli/azure/cli/command_modules/vm/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4658,6 +4658,11 @@ def create_gallery_image(cmd, resource_group_name, gallery_name, gallery_image_n
minimum_cpu_core=None, maximum_cpu_core=None, minimum_memory=None, maximum_memory=None,
disallowed_disk_types=None, plan_name=None, plan_publisher=None, plan_product=None, tags=None,
hyper_v_generation='V1', features=None, architecture=None):
logger.warning(
"Starting Build (May) 2024, \"az sig image-definition create\" command will use the new default values "
"Hyper-V Generation: V2 and SecurityType: TrustedLaunchSuppoted."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanzhudd @ZengTaoxu "TrustedLaunchSuppoted" is spelled incorrectly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnl2323,
thanks for pointing out, we'll fix it.

)

# pylint: disable=line-too-long
GalleryImage, GalleryImageIdentifier, RecommendedMachineConfiguration, ResourceRange, Disallowed, ImagePurchasePlan, GalleryImageFeature = cmd.get_models(
'GalleryImage', 'GalleryImageIdentifier', 'RecommendedMachineConfiguration', 'ResourceRange', 'Disallowed', 'ImagePurchasePlan', 'GalleryImageFeature')
Expand Down