Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AKS] update for changes in SDK #5086

Merged
merged 7 commits into from
Dec 14, 2017
Merged

[AKS] update for changes in SDK #5086

merged 7 commits into from
Dec 14, 2017

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Dec 12, 2017 •
edited
Loading

Changes in Azure/azure-rest-api-specs#1956 to use x-ms-client-flatten implied some minor changes here in the CLI. Note that this will fail until azure-mgmt-containerservice 3.0.0 is available. (avaiable now)

Requires Azure/azure-sdk-for-python#1699

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5086
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

This was referenced Dec 12, 2017
Merged
Closed
@derekbekoe derekbekoe added the ACS az acs/aks/openshift label Dec 13, 2017
@derekbekoe
Copy link
Member

@mboersma Looks like there are user-facing changes here?
If so can you update HISTORY.rst?

@mboersma
Copy link
Member Author

mboersma commented Dec 13, 2017 •
edited
Loading

@derekbekoe the only thing a user would notice is that I bumped the example Kubernetes versions in the help text to slightly newer ones. Should that go in HISTORY.rst? Or I can drop that commit--sorry, it wasn't strictly related to this change.

@derekbekoe
Copy link
Member

That change is fine.
I was referring to the flattening. Now the JSON output of the modified commands won't have some 'properties' fields?

@mboersma
Copy link
Member Author

Good point--I mentioned that in HISTORY.rst now.

@derekbekoe derekbekoe merged commit d1d0fba into Azure:dev Dec 14, 2017
@mboersma mboersma deleted the aks-take-two branch January 8, 2018 17:58
@mboersma mboersma mentioned this pull request Jan 8, 2018
Closed
@haroldrandom haroldrandom added the ACS az acs/aks/openshift label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbekoe derekbekoe derekbekoe approved these changes

Assignees
No one assigned
Labels
ACS az acs/aks/openshift
Projects
None yet
Milestone
Sprint 28 - Final 2017 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @azuresdkci @derekbekoe @haroldrandom