Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS] 3.0.0 version with flattened properties and new endpoint #1699

Merged
merged 3 commits into from
Dec 13, 2017

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Dec 12, 2017

Requires Azure/azure-rest-api-specs#2140 merged
Refs Azure/azure-cli#5086
See also #1700.

* Flattened ManagedCluster so there is no separate properties object
* Added get_access_profiles operation to managed clusters
* Finally generated from public swagger spec
@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #1699 into master will decrease coverage by 0.01%.
The diff coverage is 29.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   55.42%   55.41%   -0.02%     
==========================================
  Files        4197     4190       -7     
  Lines       99683    99627      -56     
==========================================
- Hits        55253    55211      -42     
+ Misses      44430    44416      -14
Impacted Files Coverage Δ
.../mgmt/containerservice/models/container_service.py 100% <ø> (ø) ⬆️
...ice/models/container_service_agent_pool_profile.py 100% <ø> (ø) ⬆️
...erservice/models/container_service_client_enums.py 100% <ø> (ø) ⬆️
...e/models/container_service_orchestrator_profile.py 100% <ø> (ø) ⬆️
...vice/models/container_service_ssh_configuration.py 100% <ø> (ø) ⬆️
...service/models/container_service_master_profile.py 100% <ø> (ø) ⬆️
...els/container_service_service_principal_profile.py 62.5% <ø> (ø) ⬆️
...rservice/models/container_service_linux_profile.py 100% <ø> (ø) ⬆️
...ce/models/container_service_diagnostics_profile.py 83.33% <ø> (ø) ⬆️
...ice/models/managed_cluster_pool_upgrade_profile.py 55.55% <ø> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd101c...1e1dbc5. Read the comment docs.

@lmazuel lmazuel merged commit e46f33e into Azure:master Dec 13, 2017
@mboersma mboersma deleted the aks-take-two branch December 13, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants