Internal Pagination: Fixes APIs to be cleaner. #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
DmitriMelnikov
previously approved these changes
Jan 22, 2021
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedCrossFeedRangeAsyncEnumerable.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeed/Pagination/ChangeFeedPaginationOptions.cs
Outdated
Show resolved
Hide resolved
...ure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/DocumentContainerChangeFeedTests.cs
Show resolved
Hide resolved
...ure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/DocumentContainerChangeFeedTests.cs
Show resolved
Hide resolved
...osmos/tests/Microsoft.Azure.Cosmos.Tests/ChangeFeed/NetworkAttachedDocumentContainerTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Pagination/DocumentContainerTests.cs
Show resolved
Hide resolved
vivekr20
reviewed
Jan 26, 2021
vivekr20
reviewed
Jan 26, 2021
vivekr20
reviewed
Jan 26, 2021
…Azure/azure-cosmos-dotnet-v3 into users/brchon/Pagination/Options
sboshra
reviewed
Feb 3, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Pagination/InMemoryContainer.cs
Outdated
Show resolved
Hide resolved
vivekr20
approved these changes
Feb 3, 2021
vivekr20
requested changes
Feb 3, 2021
vivekr20
previously approved these changes
Feb 3, 2021
vivekr20
previously approved these changes
Feb 4, 2021
…Azure/azure-cosmos-dotnet-v3 into users/brchon/Pagination/Options
sboshra
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Pagination: Fixes APIs to be cleaner.
Description
This PR cleans up the pagination API by creating
PaginationOptions, which groups together all the static options for a particular FeedOperation. We also wired through raw headers on the request and response path for custom headers on compute gateway. Finally we used theFeedRangeState<TState>which is a composite of FeedRange and State to lower the number of parameters on most functions that require both.