[Internal] ChangeFeed: Adds Support to Pass Custom Headers for ChangeFeed Queries #2163
Conversation
…eed Queries - This is needed for the Cassandra API to function correctly as we rely on passing down the BinaryPassThrough header for HybridRow Full-FidelitySupport, as well as the SchemaOwnerId, SchemaHash, & SchemaId Headers for data correctness.
vivekr20
requested review from
ealsur,
FabianMeiswinkel,
j82w and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
vivekr20
changed the title
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
vivekr20
changed the title
There was a problem hiding this comment.
Wiring ChangeFeedRequestOptions (the v3 type) through the pagination library is not really an option. This creates tight coupling between the v3 SDK and this general purpose pagination library. The goal is that this code can be forked into a different SDK and by a strong dependency on the type we are stopping any chances of that in the future.
@bchong95 My intention for this change is only as a stop gap until #2144 can get merged in, at which point, your concerns would be addressed. The reason to get this change in now before waiting for the above PR is so that we can add the missing capabilities needed to support ChangeFeed with FeedRanges for Cassandra, which in turn is a dependency for Materialized views. |
This is needed for the Cassandra API to function correctly as we rely on passing down the BinaryPassThrough header for HybridRow Full-FidelitySupport, as well as the SchemaOwnerId, SchemaHash, & SchemaId Headers for data correctness.
[] Bug fix (non-breaking change which fixes an issue)