-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuction App Flex Consumption publish support #2688
Fuction App Flex Consumption publish support #2688
Conversation
@patelchandni @fabiocav - this PR is from the Visual Studio team to add publish support for Flex Consumption for the .NET Isolated worker. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anvillan can you please add a note covering those changes to sdk/release_notes.md?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested few changes based on new API behavior. Rest looks good, thank you.
…ation; set correct query params to URLs; add UTs for ZipDeployTask and ZipDeploymentStatus
I added UTs for I also added the new cases for the new variations after the changes introduced in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
@fabiocav, could you please take a look and help me to complete all the checks so this PR merges? I can't see any actionable items for me to do. CC: @nzthiago, @patelchandni |
/azp run dotnet-worker.public |
Azure Pipelines successfully started running 1 pipeline(s). |
This change was merged with #2712. Closing this PR. |
Issue describing the changes in this PR
resolves (TBD)
In this PR:
UseBlobContainerDeploy
(bool
) property to theZipDeploy
target/task to identify when to use the"
<publishUrl>/api/publish
" endpoint to publish a Flex Consumption function appstatus_text
message (if defined) along with the status itself. E.g.:"Deployment status is Failed: App setting WEBSITE_RUN_FROM_PACKAGE is not supported..."
.Pull request checklist
release_notes.md