Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function App (Flex Cosumption) ZipDeploy publish support #2712

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

anvillan
Copy link
Contributor

@anvillan anvillan commented Sep 13, 2024

Issue describing the changes in this PR

resolves (TBD)

In this PR:

  • Add new UseBlobContainerDeploy (bool) property to the ZipDeploy target/task to identify when to use the OneDeploy URL
    "<publishUrl>/api/publish" endpoint to publish a Flex Consumption function app
  • When polling for the ZipDeploy pubish status, append the status_text message (if defined) along with the status itself. E.g.: "Deployment status is Failed: App setting WEBSITE_RUN_FROM_PACKAGE is not supported...".
  • Add UTs for ZipDeployTask and ZipDeploymentStatus

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This is a copy of #2688, created to be able to pass required checks failing due to lack of permission(s).

@anvillan
Copy link
Contributor Author

@kshyju @fabiocav @nzthiago

Please let me know if anything else is required so this PR is approved, and it merges.

Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the plans to test this E2E with the VS profile you mentioned?

@anvillan anvillan merged commit 24cd553 into main Sep 23, 2024
29 checks passed
@anvillan anvillan deleted the anvillan/flex_consumption_zipdeploy_support branch September 23, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants