improve image_creation script

[dongsupark]

Improve image_creation.sh script.

• Make necessary variables configurable like resource group, storage account, location, vm_name, vm_size, etc.
• Consolidate storage accounts creation into a single account, to avoid defining custom connection string env variables. Instead, generate connection string from the storage account directly to pass it to the subsequent commands.
• Create storage account and container before getting SAS string.
• Create SIG gallery before running az sig image-version create.
• Convert variable names to capital letters.
• Create image-definition before creating image-version in an automated way.
• Explicitly set SecurityType=TrustedLaunch for vm create and sig image-definition create.
• Address warnings and infos when running shellcheck, mainly by adding quotes around variables.
• Add command line options -h for help and -v for verbose.

How to run with custom parameters.

RG="my-test-azinit" LOCATION="westeurope" VM_SIZE="Standard_D2ds_v5" BASE_IMAGE="Debian:debian-11:11-backports-gen2:latest" demo/image_creation.sh

Testing done

Done testing with a couple of possible variables.

[jeremycline]

I tried this out with RG="jcline-azinit-test2" LOCATION="eastus2" BASE_IMAGE="Debian:debian-11:11-backports-gen2:latest" demo/image_creation.sh and the VM failed configuration with

[   33.134147] cloud-init[918]: /var/log/azure/image/setup.sh: line 14: /etc/netplan/eth0.yaml: No such file or directory

I assume /etc/netplan/ doesn't exist on that image.

Since you're not touching the customdata_template.yml this is just an existing issue from what I can tell. The changes themselves look good good to me. You might want to point ShellCheck at it, but all those were pre-existing so we can do that separately as well.

[dongsupark]

I tried this out with RG="jcline-azinit-test2" LOCATION="eastus2" BASE_IMAGE="Debian:debian-11:11-backports-gen2:latest" demo/image_creation.sh and the VM failed configuration with

[   33.134147] cloud-init[918]: /var/log/azure/image/setup.sh: line 14: /etc/netplan/eth0.yaml: No such file or directory

I assume /etc/netplan/ doesn't exist on that image.

I cannot reproduce it myself, but anyway pushed a fix for that in customdata_template.yml.

Since you're not touching the customdata_template.yml this is just an existing issue from what I can tell. The changes themselves look good good to me. You might want to point ShellCheck at it, but all those were pre-existing so we can do that separately as well.

[anhvoms]

The image creation script was used with Ubuntu 20.04/22.04. It assumed that netplan was used for networking and a lot of code written was based on that assumption. See issue #90

[dongsupark]

Added an automated creation of image definition before creating image version.
Addressed warnings and infos when running shellcheck.

[anhvoms]

LGTM! Thank you.