Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve image_creation script #88

Merged
merged 2 commits into from
Jul 3, 2024
Merged

improve image_creation script #88

merged 2 commits into from
Jul 3, 2024

Commits on Jun 28, 2024

  1. image_creation: improve image creation script 

    * Make necessary variables configurable like resource group, storage
  account, location, vm_name, vm_size, etc.
* Consolidate storage accounts creation into a single account, to avoid
  defining custom connection string env variables. Instead, generate
  connection string from the storage account directly to pass it to the
  subsequent commands.
* Create storage account and container before getting SAS string.
* Create SIG gallery before running az sig image-version create.
* Convert variable names to capital letters.
* Create image-definition before creating image-version in an automated
  way.
* Explicitly set SecurityType=TrustedLaunch for vm create and sig
  image-definition create.
* Address warnings and infos when running shellcheck, mainly by adding
  quotes around variables.
* Add command line options -h for help and -v for verbose.
    @dongsupark
    dongsupark committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3d6188a View commit details
    Browse the repository at this point in the history

  2. customdata_template: create /etc/netplan directory before writing 

    Create directory /etc/netplan before writing files into the directory.
Remove a garbage file with `rm -f` to prevent the machine to be stuck
before shutting down.
    @dongsupark
    dongsupark committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a68e417 View commit details
    Browse the repository at this point in the history