EventGrid: Fix multiple linter and swagger correctness/completeness i…

…ssues for latest preview and stable API versions (#12767) * fix example * Fix multiple linter and swagger correctness/completeness issues for latest preview and stable api version * Fix format * fix examples * fix validation model errors * fix validation model errors * fix example * remove default * revert 2020-06 changes * fix eventgrid swagger file with multiple linter and correctness fixes * fix 2020-06-01 stable swagger * fix 2020-06-01 stable swagger -- part 2 * fix format * fix prettier check * additional format fix * fix examples and wrong response code * fix validator * fix validator Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Azure · Feb 20, 2021 · 2ba10df · 2ba10df
1 parent c29b17e
commit 2ba10df
Show file tree

Hide file tree

Showing 13 changed files with 203 additions and 35 deletions.
diff --git a/.../eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json b/.../eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json
@@ -163,6 +163,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "202": {
             "description": "Accepted"
           },
@@ -619,6 +622,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "202": {
             "description": "Accepted"
           },
@@ -1382,6 +1388,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "202": {
             "description": "Accepted"
           },
@@ -1816,6 +1825,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "202": {
             "description": "Accepted"
           },
@@ -2811,6 +2823,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "202": {
             "description": "Accepted"
           },
@@ -4444,6 +4459,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "202": {
             "description": "Accepted"
           },
@@ -5176,6 +5194,9 @@
             "schema": {
               "$ref": "#/definitions/ExtensionTopic"
             }
+          },
+          "default": {
+            "description": "*** Error Responses: ***\n\n * 400 Bad Request.\n\n * 500 Internal Server Error."
           }
         },
         "x-ms-examples": {
@@ -5378,7 +5399,8 @@
           "x-ms-enum": {
             "name": "PublicNetworkAccess",
             "modelAsString": true
-          }
+          },
+          "default": "Enabled"
         },
         "inboundIpRules": {
           "description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
@@ -5501,12 +5523,12 @@
           "readOnly": true
         },
         "name": {
-          "description": "Name of the resource",
+          "description": "Name of the resource.",
           "type": "string",
           "readOnly": true
         },
         "type": {
-          "description": "Type of the resource",
+          "description": "Type of the resource.",
           "type": "string",
           "readOnly": true
         }
@@ -5725,7 +5747,8 @@
         },
         "sku": {
           "$ref": "#/definitions/ResourceSku",
-          "description": "The Sku pricing tier for the domain."
+          "description": "The Sku pricing tier for the domain.",
+          "default": "Basic"
         },
         "identity": {
           "$ref": "#/definitions/IdentityInfo",
@@ -5773,7 +5796,8 @@
           "x-ms-enum": {
             "name": "PublicNetworkAccess",
             "modelAsString": true
-          }
+          },
+          "default": "Enabled"
         },
         "inboundIpRules": {
           "description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
@@ -6251,6 +6275,12 @@
           "$ref": "#/definitions/EventChannelProperties",
           "description": "Properties of the EventChannel.",
           "x-ms-client-flatten": true
+        },
+        "systemData": {
+          "description": "The system metadata relating to Event Channel resource.",
+          "type": "object",
+          "readOnly": true,
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
         }
       }
     },
@@ -6324,6 +6354,7 @@
         },
         "eventDeliverySchema": {
           "description": "The event delivery schema for the event subscription.",
+          "default": "EventGridSchema",
           "enum": [
             "EventGridSchema",
             "CustomInputSchema",
@@ -6454,7 +6485,8 @@
       "properties": {
         "endpointUrl": {
           "description": "The URL that represents the endpoint of the destination of an event subscription.",
-          "type": "string"
+          "type": "string",
+          "x-ms-secret": true
         },
         "endpointBaseUrl": {
           "description": "The base URL that represents the endpoint of the destination of an event subscription.",
@@ -6464,11 +6496,13 @@
         "maxEventsPerBatch": {
           "format": "int32",
           "description": "Maximum number of events per batch.",
+          "default": 1,
           "type": "integer"
         },
         "preferredBatchSizeInKilobytes": {
           "format": "int32",
           "description": "Preferred batch size in Kilobytes.",
+          "default": 64,
           "type": "integer"
         },
         "azureActiveDirectoryTenantId": {
@@ -6700,11 +6734,13 @@
         "maxEventsPerBatch": {
           "format": "int32",
           "description": "Maximum number of events per batch.",
+          "default": 1,
           "type": "integer"
         },
         "preferredBatchSizeInKilobytes": {
           "format": "int32",
           "description": "Preferred batch size in Kilobytes.",
+          "default": 64,
           "type": "integer"
         }
       }
@@ -6766,6 +6802,12 @@
           "$ref": "#/definitions/EventSubscriptionProperties",
           "description": "Properties of the event subscription.",
           "x-ms-client-flatten": true
+        },
+        "systemData": {
+          "description": "The system metadata relating to Event Subscription resource.",
+          "type": "object",
+          "readOnly": true,
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
         }
       }
     },
@@ -6954,6 +6996,12 @@
           "$ref": "#/definitions/PartnerNamespaceProperties",
           "description": "Properties of the partner namespace.",
           "x-ms-client-flatten": true
+        },
+        "systemData": {
+          "description": "The system metadata relating to Partner Namespace resource.",
+          "type": "object",
+          "readOnly": true,
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
         }
       }
     },
@@ -7110,6 +7158,12 @@
           "$ref": "#/definitions/PartnerRegistrationProperties",
           "description": "Properties of the partner registration.",
           "x-ms-client-flatten": true
+        },
+        "systemData": {
+          "description": "The system metadata relating to Partner Registration resource.",
+          "type": "object",
+          "readOnly": true,
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
         }
       }
     },
@@ -7300,6 +7354,12 @@
           "$ref": "#/definitions/PartnerTopicProperties",
           "description": "Properties of the partner topic.",
           "x-ms-client-flatten": true
+        },
+        "systemData": {
+          "description": "The system metadata relating to Partner Topic resource.",
+          "type": "object",
+          "readOnly": true,
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
         }
       }
     },
@@ -7432,11 +7492,11 @@
           "type": "string"
         },
         "name": {
-          "description": "Name of the resource",
+          "description": "Name of the resource.",
           "type": "string"
         },
         "type": {
-          "description": "Type of the resource",
+          "description": "Type of the resource.",
           "type": "string"
         }
       }
@@ -7530,6 +7590,12 @@
           "$ref": "#/definitions/SystemTopicProperties",
           "description": "Properties of the system topic.",
           "x-ms-client-flatten": true
+        },
+        "systemData": {
+          "description": "The system metadata relating to System Topic resource.",
+          "type": "object",
+          "readOnly": true,
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
         }
       }
     },
@@ -7628,7 +7694,8 @@
           "x-ms-enum": {
             "name": "PublicNetworkAccess",
             "modelAsString": true
-          }
+          },
+          "default": "Enabled"
         },
         "inboundIpRules": {
           "description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
@@ -7655,7 +7722,8 @@
         },
         "sku": {
           "$ref": "#/definitions/ResourceSku",
-          "description": "The Sku pricing tier for the topic."
+          "description": "The Sku pricing tier for the topic.",
+          "default": "Basic"
         },
         "identity": {
           "$ref": "#/definitions/IdentityInfo",
@@ -7703,7 +7771,8 @@
           "x-ms-enum": {
             "name": "PublicNetworkAccess",
             "modelAsString": true
-          }
+          },
+          "default": "Enabled"
         },
         "inboundIpRules": {
           "description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
@@ -7904,6 +7973,7 @@
       "description": "The number of results to return per page for the list operation. Valid range for top parameter is 1 to 100. If not specified, the default number of results to be returned is 20 items per page.",
       "required": false,
       "type": "integer",
+      "format": "int32",
       "x-ms-parameter-location": "method"
     }
   },

diff --git a/...-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/DomainTopics_Delete.json b/...-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/DomainTopics_Delete.json
@@ -7,6 +7,7 @@
     "api-version": "2020-04-01-preview"
   },
   "responses": {
+    "200": {},
     "202": {},
     "204": {}
   }

diff --git a/...ource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/Domains_Delete.json b/...ource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/Domains_Delete.json
@@ -6,6 +6,7 @@
     "api-version": "2020-04-01-preview"
   },
   "responses": {
+    "200": {},
     "202": {},
     "204": {}
   }

diff --git a/...ger/Microsoft.EventGrid/preview/2020-04-01-preview/examples/PartnerNamespaces_Delete.json b/...ger/Microsoft.EventGrid/preview/2020-04-01-preview/examples/PartnerNamespaces_Delete.json
@@ -6,6 +6,7 @@
     "api-version": "2020-04-01-preview"
   },
   "responses": {
+    "200": {},
     "202": {},
     "204": {}
   }

diff --git a/....EventGrid/preview/2020-04-01-preview/examples/PartnerTopicEventSubscriptions_Delete.json b/....EventGrid/preview/2020-04-01-preview/examples/PartnerTopicEventSubscriptions_Delete.json
@@ -7,6 +7,7 @@
     "api-version": "2020-04-01-preview"
   },
   "responses": {
+    "200": {},
     "202": {},
     "204": {}
   }

diff --git a/...t.EventGrid/preview/2020-04-01-preview/examples/SystemTopicEventSubscriptions_Delete.json b/...t.EventGrid/preview/2020-04-01-preview/examples/SystemTopicEventSubscriptions_Delete.json
@@ -7,6 +7,7 @@
     "api-version": "2020-04-01-preview"
   },
   "responses": {
+    "200": {},
     "202": {},
     "204": {}
   }

diff --git a/...-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/SystemTopics_Delete.json b/...-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/SystemTopics_Delete.json
@@ -6,6 +6,7 @@
     "api-version": "2020-04-01-preview"
   },
   "responses": {
+    "200": {},
     "202": {},
     "204": {}
   }