EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

ahamad-MS · 2021-02-01T23:26:30Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
02/05/2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
02/05/2021
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…atest preview and stable api version

openapi-workflow-bot · 2021-02-01T23:26:32Z

Hi, @ahamad-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-02-01T23:26:33Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

openapi-pipeline-app · 2021-02-01T23:26:34Z

Swagger Validation Report

️❌BreakingChange: 118 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-04-01-preview/EventGrid.json <---> new: preview/2020-04-01-preview/EventGrid.json
- original: preview/2020-10-15-preview/EventGrid.json <---> new: preview/2020-10-15-preview/EventGrid.json
- original: stable/2020-06-01/EventGrid.json <---> new: stable/2020-06-01/EventGrid.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L166:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L625:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L1391:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L1828:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L2826:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L4462:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json#L5198:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-10-15-preview/EventGrid.json#L166:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-10-15-preview/EventGrid.json#L625:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.EventGrid/stable/2020-06-01/EventGrid.json#L166:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]

The following tags are being changed in this PR

Rule	Message
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"eventgrid/resource-manager/readme.md", "tag":"package-2020-10-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"eventgrid/resource-manager/readme.md", "tag":"package-2020-06", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"eventgrid/resource-manager/readme.md", "tag":"package-2020-04-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-01T23:26:35Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 2ba10df. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-eventgrid [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DomainUpdateParameters has a new parameter identity
info	[Changelog]   - Model DomainUpdateParameters has a new parameter sku
info	[Changelog]   - Model TopicTypeInfo has a new parameter supported_scopes_for_source
info	[Changelog]   - Model TopicUpdateParameters has a new parameter identity
info	[Changelog]   - Model TopicUpdateParameters has a new parameter sku
info	[Changelog]   - Model EventSubscriptionUpdateParameters has a new parameter delivery_with_resource_identity
info	[Changelog]   - Model EventSubscriptionUpdateParameters has a new parameter dead_letter_with_resource_identity
info	[Changelog]   - Model WebHookEventSubscriptionDestination has a new parameter delivery_attribute_mappings
info	[Changelog]   - Model ServiceBusQueueEventSubscriptionDestination has a new parameter delivery_attribute_mappings
info	[Changelog]   - Model DomainTopic has a new parameter system_data
info	[Changelog]   - Model AzureFunctionEventSubscriptionDestination has a new parameter delivery_attribute_mappings
info	[Changelog]   - Model StorageQueueEventSubscriptionDestination has a new parameter queue_message_time_to_live_in_seconds
info	[Changelog]   - Model Domain has a new parameter identity
info	[Changelog]   - Model Domain has a new parameter system_data
info	[Changelog]   - Model Domain has a new parameter sku
info	[Changelog]   - Model EventHubEventSubscriptionDestination has a new parameter delivery_attribute_mappings
info	[Changelog]   - Model Topic has a new parameter system_data
info	[Changelog]   - Model Topic has a new parameter extended_location
info	[Changelog]   - Model Topic has a new parameter identity
info	[Changelog]   - Model Topic has a new parameter kind
info	[Changelog]   - Model Topic has a new parameter sku
info	[Changelog]   - Model HybridConnectionEventSubscriptionDestination has a new parameter delivery_attribute_mappings
info	[Changelog]   - Model EventSubscription has a new parameter system_data
info	[Changelog]   - Model EventSubscription has a new parameter delivery_with_resource_identity
info	[Changelog]   - Model EventSubscription has a new parameter dead_letter_with_resource_identity
info	[Changelog]   - Model ServiceBusTopicEventSubscriptionDestination has a new parameter delivery_attribute_mappings
info	[Changelog]   - Model EventSubscriptionFilter has a new parameter enable_advanced_filtering_on_arrays
info	[Changelog]   - Added operation EventSubscriptionsOperations.get_delivery_attributes
info	[Changelog]   - Added operation group PartnerTopicsOperations
info	[Changelog]   - Added operation group ExtensionTopicsOperations
info	[Changelog]   - Added operation group PartnerNamespacesOperations
info	[Changelog]   - Added operation group SystemTopicEventSubscriptionsOperations
info	[Changelog]   - Added operation group PartnerTopicEventSubscriptionsOperations
info	[Changelog]   - Added operation group PartnerRegistrationsOperations
info	[Changelog]   - Added operation group SystemTopicsOperations
info	[Changelog]   - Added operation group EventChannelsOperations

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ba10df. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/eventgrid/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.EventGrid [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.EventGrid.6.0.0.nupkg
- Microsoft.Azure.Management.EventGrid.6.0.0.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ba10df. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️eventgrid/mgmt/2020-06-01/eventgrid [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 10 items here, please refer to log for details.

info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `TopicsRegenerateKeyFuture`
info	[Changelog] - New field `SystemData` in struct `EventSubscription`
info	[Changelog] - New field `SystemData` in struct `DomainTopic`
info	[Changelog] - New field `SystemData` in struct `Domain`
info	[Changelog] - New field `SystemData` in struct `Topic`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 13 additive change(s).
info	[Changelog]

️✔️eventgrid/mgmt/2019-06-01/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️eventgrid/mgmt/2019-01-01/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️eventgrid/mgmt/2018-01-01/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/eventgrid/mgmt/2020-10-15-preview/eventgrid [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `SystemData` in struct `DomainTopic`
info	[Changelog] - New field `SystemData` in struct `Domain`
info	[Changelog] - New field `SystemData` in struct `Topic`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]

️✔️preview/eventgrid/mgmt/2020-04-01-preview/eventgrid [View full logs] [Release SDK Changes]

Only show 10 items here, please refer to log for details.

info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `SystemData` in struct `PartnerTopic`
info	[Changelog] - New field `SystemData` in struct `PartnerRegistration`
info	[Changelog] - New field `SystemData` in struct `PartnerNamespace`
info	[Changelog] - New field `SystemData` in struct `EventChannel`
info	[Changelog] - New field `SystemData` in struct `EventSubscription`
info	[Changelog] - New field `SystemData` in struct `SystemTopic`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 13 additive change(s).
info	[Changelog]

️✔️preview/eventgrid/mgmt/2020-01-01-preview/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/eventgrid/mgmt/2019-02-01-preview/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/eventgrid/mgmt/2018-09-15-preview/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/eventgrid/mgmt/2018-05-01-preview/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/eventgrid/mgmt/2017-09-15-preview/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/eventgrid/mgmt/2017-06-15-preview/eventgrid [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2ba10df. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-20 02:45:25 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-eventgrid;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-02-20 02:45:25 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-02-20 02:45:25 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.16 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/eventgrid/azure-resourcemanager-eventgrid --java.namespace=com.azure.resourcemanager.eventgrid   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/eventgrid/resource-manager/readme.md
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-eventgrid
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [POM][Skip] pom already has module azure-resourcemanager-eventgrid
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [POM][Skip] pom already has module sdk/eventgrid
cmderr	[generate.py] 2021-02-20 02:46:22 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-eventgrid [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-20 02:49:44 DEBUG Got artifact_id: azure-resourcemanager-eventgrid
cmderr	[Inst] 2021-02-20 02:49:44 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-20 02:49:44 DEBUG Got artifact: azure-resourcemanager-eventgrid-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-02-20 02:49:44 DEBUG Got artifact: azure-resourcemanager-eventgrid-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-02-20 02:49:44 DEBUG Got artifact: azure-resourcemanager-eventgrid-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-20 02:49:44 DEBUG Match jar package: azure-resourcemanager-eventgrid-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-20 02:49:44 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12767/azure-sdk-for-java/azure-resourcemanager-eventgrid/azure-resourcemanager-eventgrid-1.0.0-beta.2.jar\" -o azure-resourcemanager-eventgrid-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-eventgrid -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-eventgrid-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️❌ azure-sdk-for-js failed [Detail]

❌Failed [Logs]Release - Generate from 2ba10df. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/eventgrid/resource-manager/readme.md

❌@azure/arm-eventgrid [View full logs] [Release SDK Changes]

error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/eventgrid/arm-eventgrid]: npm pack --silent

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2ba10df. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/eventgrid/resource-manager/readme.md

️✔️eventgrid [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN
cmderr	[resource-manager] Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-01T23:28:12Z

Hi @ahamad-MS, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

ahamad-MS · 2021-02-18T17:53:36Z

Hello @jianyexi @qianwens.. The comments are addressed. Please Let me know if additional info needed and what is expected ETA for sign off? I was asked for an ETA for this work

Thanks

akning-ms · 2021-02-20T01:14:11Z

/azp run

azure-pipelines · 2021-02-20T01:14:26Z

Azure Pipelines successfully started running 2 pipeline(s).

jianyexi · 2021-02-20T02:04:28Z

@qiaozha could you look at the js SDK failre ?

mikhailshilkov · 2021-02-25T08:21:17Z

I believe this PR has broken the specs: #13167

…ssues for latest preview and stable API versions (Azure#12767) * fix example * Fix multiple linter and swagger correctness/completeness issues for latest preview and stable api version * Fix format * fix examples * fix validation model errors * fix validation model errors * fix example * remove default * revert 2020-06 changes * fix eventgrid swagger file with multiple linter and correctness fixes * fix 2020-06-01 stable swagger * fix 2020-06-01 stable swagger -- part 2 * fix format * fix prettier check * additional format fix * fix examples and wrong response code * fix validator * fix validator Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>

Ashraf Hamad added 3 commits November 10, 2020 23:46

fix example

b9693fc

Merge remote-tracking branch 'upstream/master'

8760d97

Fix multiple linter and swagger correctness/completeness issues for l…

69b51d3

…atest preview and stable api version

ahamad-MS requested a review from Kishp01 as a code owner February 1, 2021 23:26

openapi-assignment-bot bot assigned qianwens Feb 1, 2021

openapi-workflow-bot bot added the FixS360 label Feb 1, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 1, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 1, 2021

Fix format

6cdf899

openapi-sdkautomation bot mentioned this pull request Feb 1, 2021

[AutoPR azure-resourcemanager-eventgrid] EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions AzureSDKAutomation/azure-sdk-for-java#7371

Closed

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 1, 2021

fix examples

0ad8a2b

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 1, 2021

fix validation model errors

2b135a0

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 2, 2021

fix validation model errors

a35eabb

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 2, 2021

fix example

ca30817

Kishp01 approved these changes Feb 18, 2021

View reviewed changes

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 20, 2021

openapi-sdkautomation bot mentioned this pull request Feb 20, 2021

[AutoPR azure-mgmt-eventgrid] EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions AzureSDKAutomation/azure-sdk-for-python#4231

Closed

jianyexi approved these changes Feb 20, 2021

View reviewed changes

qianwens added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 20, 2021

qianwens merged commit 2ba10df into Azure:master Feb 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

ahamad-MS commented Feb 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2021

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2021

ahamad-MS commented Feb 18, 2021

akning-ms commented Feb 20, 2021

azure-pipelines bot commented Feb 20, 2021

jianyexi commented Feb 20, 2021

mikhailshilkov commented Feb 25, 2021

EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

Conversation

ahamad-MS commented Feb 1, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 1, 2021

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 1, 2021

ahamad-MS commented Feb 18, 2021

akning-ms commented Feb 20, 2021

azure-pipelines bot commented Feb 20, 2021

jianyexi commented Feb 20, 2021

mikhailshilkov commented Feb 25, 2021

ahamad-MS commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading