Skip to content

Commit

Permalink
[LogicApp] Bugfix for swagger/sdk not matching the underlying service…
Browse files Browse the repository at this point in the history 
… API (#4769)

* Bugfix for swagger/sdk not matching the underlying service API

* Add in approved override
  • Loading branch information
@refortie @sarangan12
refortie authored and sarangan12 committed Dec 7, 2018
1 parent b011d6c commit eab6334
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 32 deletions.
16 changes: 8 additions & 8 deletions ...icrosoft.Logic/preview/2018-07-01-preview/examples/IntegrationAccountAgreements_List.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"interchangeControlNumberValidityDays": 30,
"checkDuplicateGroupControlNumber": false,
"checkDuplicateTransactionSetControlNumber": false,
"validateEdiTypes": true,
"validateXsdTypes": false,
"validateEDITypes": true,
"validateXSDTypes": false,
"allowLeadingAndTrailingSpacesAndZeroes": false,
"trimLeadingAndTrailingSpacesAndZeroes": false,
"trailingSeparatorPolicy": "NotAllowed"
Expand Down Expand Up @@ -117,8 +117,8 @@
"interchangeControlNumberValidityDays": 30,
"checkDuplicateGroupControlNumber": false,
"checkDuplicateTransactionSetControlNumber": false,
"validateEdiTypes": true,
"validateXsdTypes": false,
"validateEDITypes": true,
"validateXSDTypes": false,
"allowLeadingAndTrailingSpacesAndZeroes": false,
"trimLeadingAndTrailingSpacesAndZeroes": false,
"trailingSeparatorPolicy": "NotAllowed"
Expand Down Expand Up @@ -387,8 +387,8 @@
"interchangeControlNumberValidityDays": 30,
"checkDuplicateGroupControlNumber": true,
"checkDuplicateTransactionSetControlNumber": true,
"validateEdiTypes": true,
"validateXsdTypes": true,
"validateEDITypes": true,
"validateXSDTypes": true,
"trimLeadingAndTrailingSpacesAndZeroes": true,
"allowLeadingAndTrailingSpacesAndZeroes": true,
"trailingSeparatorPolicy": "Optional"
Expand Down Expand Up @@ -488,8 +488,8 @@
"interchangeControlNumberValidityDays": 30,
"checkDuplicateGroupControlNumber": true,
"checkDuplicateTransactionSetControlNumber": true,
"validateEdiTypes": true,
"validateXsdTypes": true,
"validateEDITypes": true,
"validateXSDTypes": true,
"trimLeadingAndTrailingSpacesAndZeroes": true,
"allowLeadingAndTrailingSpacesAndZeroes": true,
"trailingSeparatorPolicy": "Optional"
Expand Down
32 changes: 16 additions & 16 deletions specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7481,8 +7481,8 @@
"interchangeControlNumberValidityDays",
"checkDuplicateGroupControlNumber",
"checkDuplicateTransactionSetControlNumber",
"validateEdiTypes",
"validateXsdTypes",
"validateEDITypes",
"validateXSDTypes",
"allowLeadingAndTrailingSpacesAndZeroes",
"trimLeadingAndTrailingSpacesAndZeroes",
"trailingSeparatorPolicy"
Expand All @@ -7509,11 +7509,11 @@
"type": "boolean",
"description": "The value indicating whether to check for duplicate transaction set control number."
},
"validateEdiTypes": {
"validateEDITypes": {
"type": "boolean",
"description": "The value indicating whether to Whether to validate EDI types."
},
"validateXsdTypes": {
"validateXSDTypes": {
"type": "boolean",
"description": "The value indicating whether to Whether to validate XSD types."
},
Expand Down Expand Up @@ -7930,8 +7930,8 @@
"type": "object",
"required": [
"messageId",
"validateEdiTypes",
"validateXsdTypes",
"validateEDITypes",
"validateXSDTypes",
"allowLeadingAndTrailingSpacesAndZeroes",
"validateCharacterSet",
"trimLeadingAndTrailingSpacesAndZeroes",
Expand All @@ -7942,11 +7942,11 @@
"type": "string",
"description": "The message id on which the validation settings has to be applied."
},
"validateEdiTypes": {
"validateEDITypes": {
"type": "boolean",
"description": "The value indicating whether to validate EDI types."
},
"validateXsdTypes": {
"validateXSDTypes": {
"type": "boolean",
"description": "The value indicating whether to validate XSD types."
},
Expand Down Expand Up @@ -8324,8 +8324,8 @@
"interchangeControlNumberValidityDays",
"checkDuplicateGroupControlNumber",
"checkDuplicateTransactionSetControlNumber",
"validateEdiTypes",
"validateXsdTypes",
"validateEDITypes",
"validateXSDTypes",
"allowLeadingAndTrailingSpacesAndZeroes",
"trimLeadingAndTrailingSpacesAndZeroes",
"trailingSeparatorPolicy"
Expand All @@ -8352,11 +8352,11 @@
"type": "boolean",
"description": "The value indicating whether to check for duplicate transaction set control number."
},
"validateEdiTypes": {
"validateEDITypes": {
"type": "boolean",
"description": "The value indicating whether to Whether to validate EDI types."
},
"validateXsdTypes": {
"validateXSDTypes": {
"type": "boolean",
"description": "The value indicating whether to Whether to validate XSD types."
},
Expand Down Expand Up @@ -8867,8 +8867,8 @@
"required": [
"messageId",
"enforceCharacterSet",
"validateEdiTypes",
"validateXsdTypes",
"validateEDITypes",
"validateXSDTypes",
"allowLeadingAndTrailingSpacesAndZeroes",
"trailingSeparatorPolicy",
"trimLeadingAndTrailingSpacesAndZeroes"
Expand All @@ -8882,11 +8882,11 @@
"type": "boolean",
"description": "The value indicating whether to validate character Set."
},
"validateEdiTypes": {
"validateEDITypes": {
"type": "boolean",
"description": "The value indicating whether to validate EDI types."
},
"validateXsdTypes": {
"validateXSDTypes": {
"type": "boolean",
"description": "The value indicating whether to validate XSD types."
},
Expand Down
32 changes: 24 additions & 8 deletions specification/logic/resource-manager/readme.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
This is the AutoRest configuration file for Logic.



---

## Getting Started

To build the SDK for Logic, simply [Install AutoRest](https://aka.ms/autorest/install) and in this folder, run:

> `autorest`
Expand All @@ -19,9 +19,8 @@ To see additional help and options, run:

## Configuration



### Basic Information

These are the global settings for the Logic API.

``` yaml
Expand All @@ -40,7 +39,6 @@ directive:

```


### Tag: package-2018-07-preview

These settings apply only when `--package-2018-07-preview` is specified on the command line.
Expand All @@ -50,6 +48,24 @@ input-file:
- Microsoft.Logic/preview/2018-07-01-preview/logic.json
```
## Suppression
``` yaml
directive:
- suppress: R3016
reason: Existing properties, can't be changed without breaking API.
#where:
# - $.definitions.EdifactValidationSettings.properties.validateEDITypes
# - $.definitions.EdifactValidationSettings.properties.validateXSDTypes
# - $.definitions.EdifactValidationOverride.properties.validateEDITypes
# - $.definitions.EdifactValidationOverride.properties.validateXSDTypes
# - $.definitions.X12ValidationSettings.properties.validateEDITypes
# - $.definitions.X12ValidationSettings.properties.validateXSDTypes
# - $.definitions.X12ValidationOverride.properties.validateEDITypes
# - $.definitions.X12ValidationOverride.properties.validateXSDTypes

```

### Tag: package-2016-06

These settings apply only when `--tag=package-2016-06` is specified on the command line.
Expand Down Expand Up @@ -77,10 +93,9 @@ input-file:
- Microsoft.Logic/preview/2015-02-01-preview/logic.json
```


---
# Code Generation

# Code Generation

## Swagger to SDK

Expand All @@ -99,7 +114,6 @@ swagger-to-sdk:
- bundle install && rake arm:regen_all_profiles['azure_mgmt_logic']
```


## C#

These settings apply only when `--csharp` is specified on the command line.
Expand Down Expand Up @@ -130,11 +144,13 @@ python:
package-name: azure-mgmt-logic
clear-output-folder: true
```

``` yaml $(python) && $(python-mode) == 'update'
python:
no-namespace-folders: true
output-folder: $(python-sdks-folder)/azure-mgmt-logic/azure/mgmt/logic
```

``` yaml $(python) && $(python-mode) == 'create'
python:
basic-setup-py: true
Expand Down

0 comments on commit eab6334

Please sign in to comment.