Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LogicApp] Bugfix for swagger/sdk not matching the underlying service API #4769

Merged
merged 2 commits into from
Dec 7, 2018
Merged

[LogicApp] Bugfix for swagger/sdk not matching the underlying service API #4769

merged 2 commits into from
Dec 7, 2018

Conversation

refortie
Copy link
Contributor

@refortie refortie commented Dec 4, 2018 •
edited
Loading

I understand this breaks the naming convention specified, but this is a bugfix not a new feature. Our API returns these 2 acronyms as capitalized words. This causes any case sensitive JSON deserialization in the the SDKs to not be able to deserialize the responses from the API An example of this is calling the GET call in the node SDK.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci azuresdkci requested a review from sarangan12 December 4, 2018 19:25
@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2782

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#507

@refortie refortie changed the title Bugfix for swagger/sdk not matching the underlying service API [LogicApp] Bugfix for swagger/sdk not matching the underlying service API Dec 4, 2018
@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1914

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3646

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4111

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2311

@sarangan12
Copy link
Member

@refortie This needs exception approval from ARM Team. Please contact Gaurav Bhatnagar to get the exception approval

@sarangan12 sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2018
KrisBash
KrisBash approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a bugfix to align to existing service behavior, this is OK from ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 6, 2018
@sarangan12
Copy link
Member

@refortie Since ARM has approved the changes could you please add the exception to the Readme file so the CI will pass. You can use this as reference: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/apimanagement/resource-manager#suppression-1

@sarangan12 sarangan12 merged commit eab6334 into Azure:master Dec 7, 2018
@refortie refortie mentioned this pull request Jan 10, 2019
Merged
5 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@refortie @AnuTalluri
[LogicApp] Bugfix for swagger/sdk not matching the underlying service…
55f1f65 
… API (Azure#4769)

* Bugfix for swagger/sdk not matching the underlying service API

* Add in approved override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refortie @AutorestCI @azuresdkci @sarangan12 @KrisBash