Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding service fabric api version 2020-12-01-preview. #10230

Closed
wants to merge 5 commits into from

Conversation

alexgshaw
Copy link

@alexgshaw alexgshaw commented Jul 22, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@alexgshaw alexgshaw requested a review from samedder as a code owner July 22, 2020 20:58
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 22, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@ghost
Copy link

ghost commented Jul 22, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ alexgshaw sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 22, 2020
@a-santamaria
Copy link
Member

*** /openapibot sdkautomation ***

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@chiragg4u
Copy link
Contributor

Thanks for copying the existing version before doing the change. New API's are looking good, signing off from ARM side.

@chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 11, 2020
@njuCZ
Copy link
Contributor

njuCZ commented Sep 3, 2020

@alexgshaw there is a conflict for this PR. Could you please fix it so we could do further review?

@njuCZ
Copy link
Contributor

njuCZ commented Nov 2, 2020

@alexgshaw long time no updates for this thread, is this PR still valid?

@alexgshaw
Copy link
Author

Hi, yes the PR should still be valid. I was interning at Microsoft when I made this PR. I'll email some members of my team to see if they can take it over. Sorry for the delay, and thanks for your help!

@a-santamaria could you help with this?

@a-santamaria
Copy link
Member

@alexgshaw sorry for the delay. I have taken your branch and rebased with master to fix the conflicts and update the paths here #11614. @njuCZ I'm closing this pr so we can follow up in the new one I created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants