-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding service fabric api version 2020-12-01-preview. #10230
Conversation
You don't have permission to trigger SDK Automation. |
[Staging] Swagger Validation Report
️✔️ |
|
*** /openapibot sdkautomation *** |
Can one of the admins verify this patch? |
Thanks for copying the existing version before doing the change. New API's are looking good, signing off from ARM side. |
@alexgshaw there is a conflict for this PR. Could you please fix it so we could do further review? |
@alexgshaw long time no updates for this thread, is this PR still valid? |
Hi, yes the PR should still be valid. I was interning at Microsoft when I made this PR. I'll email some members of my team to see if they can take it over. Sorry for the delay, and thanks for your help! @a-santamaria could you help with this? |
@alexgshaw sorry for the delay. I have taken your branch and rebased with master to fix the conflicts and update the paths here #11614. @njuCZ I'm closing this pr so we can follow up in the new one I created. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.