Adding service fabric api version 2020-12-01-preview - rebased with master #11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| OperationId should contain the verb: 'listupgradableversions' in:'ListUpgradableVersions_Post'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2020-12-01-preview/cluster.json#L467 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/servicefabric/resource-manager/readme.md tag: specification/servicefabric/resource-manager/readme.md#tag-package-2020-03 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 69 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2019-11-01-preview/application.json <---> new: preview/2020-12-01-preview/application.json
- original: preview/2019-11-01-preview/cluster.json <---> new: preview/2020-12-01-preview/cluster.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L37:5 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L81:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L125:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L179:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L226:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L269:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L316:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L374:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L424:9 |
|
| The new version is removing enum value(s) '2019-11-01-preview' from the old version. Old: Microsoft.ServiceFabric/preview/2019-11-01-preview/application.json#L470:9 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 69 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-03-01/application.json <---> new: preview/2020-12-01-preview/application.json
- original: stable/2020-03-01/cluster.json <---> new: preview/2020-12-01-preview/cluster.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L37:5 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L81:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L125:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L179:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L226:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L269:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L316:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L374:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L424:9 |
|
| The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L470:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 61 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ApplicationTypeVersionsCleanupPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'AvailableOperationDisplay' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'AzureActiveDirectory' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'CertificateDescription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ClientCertificateCommonName' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ClientCertificateThumbprint' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ClusterCodeVersionsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ClusterCodeVersionsResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ClusterListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2020-12-preview", "details":"The schema 'ClusterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @yungezz |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
azure-sdk-for-java
|
azure-sdk-for-go
|
azure-sdk-for-js
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Nov 10, 2020
hi @msyyc, is it ok for Python SDK? I don't have concern here. thanks. |
yungezz
approved these changes
Feb 12, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
hi @a-santamaria I rerun CI and seems more CI failed, could you pls fix CI failure? For Python SDK breaking change, you're right, it's caused by previous PR, I think it's ok. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@yungezz I think they should be fixed now, but not all of them have run. Some checks say "Expected — Waiting for status to be reported" |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@yungezz I re-ran ci tasks. Only swagger APIDocPreview gets stuck. Can we merge, please? |
|
@yungezz any update? |
yungezz
approved these changes
Feb 23, 2021
This was referenced Feb 23, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the pr here #10230 and rebased with master to fix the conflicts. Also, update the paths and example to reflect the changes we made on the RP.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
I took @alexgshaw pr here #10230 and rebased with master to fix the conflicts. Also, update the paths and example to reflect the changes we made on the RP
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.