Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Stable version from Preview version #10321

Merged
merged 4 commits into from
Aug 14, 2020

Conversation

navysingla
Copy link
Contributor

@navysingla navysingla commented Aug 3, 2020

In this PR, we are creating new version 2020-09-01 from 2019-10-01-preview version.
We are not adding all the APIs in stable version from preview version but only the subset of APIs from preview version.
Preview version has these APIs -

  1. Cancel SUb
  2. Rename Sub
  3. Enable Sub
  4. Create Subscription Alias
  5. Get Subscription Alias
  6. List Subscription Alias
  7. Delete Subscription Alias
  8. Create Legacy Subscription
  9. Create Modern Subscription
  10. Create Csp Subscription
  11. Get subscription Operation

We are adding only following APIs in stable version -

  1. Cancel SUb
  2. Rename Sub
  3. Enable Sub
  4. Create Subscription Alias
  5. Get Subscription Alias
  6. List Subscription Alias
  7. Delete Subscription Alias

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 3, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 3, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service account [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10321/azure-cli-extensions/Azure/azure-cli-extensions/account/account-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from a2ea883 with merge commit 409fc85. Azure CLI Automation 13.0.17.20200807.2
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Location' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LocationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Subscription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionPolicies' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SubscriptionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantIdDescription' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TenantListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CanceledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RenamedSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EnabledSubscriptionId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasRequestProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasResponseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PutAliasListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Subscription/put/CreateAlias
    [AutoRest]     - name: /Subscription/get/GetAlias
    [AutoRest]     - name: /Subscription/get/GetAlias
    [AutoRest]     - name: /Subscription/post/cancelSubscription
    [AutoRest]     - name: /Subscription/post/enableSubscription
    [AutoRest]     - name: /Subscription/post/renameSubscription
    [AutoRest]     - name: /Subscriptions/get/getSubscription
    [AutoRest]     - name: /Subscriptions/get/listLocations
    [AutoRest]     - name: /Subscriptions/get/listSubscriptions
    [AutoRest]     - name: /Tenants/get/listTenants
    [AutoRest]     - name: /Subscription/delete/DeleteAlias
    [AutoRest] --------------------------------------------------------

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 3, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from a2ea883 with merge commit 409fc85. SDK Automation 13.0.17.20200807.2
  • ⚠️azure-mgmt-subscription [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-subscription
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-subscription
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 41.507% size of original (original: 9107 chars, delta: 3780 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation SubscriptionOperations.get_alias
    [ChangeLog]   - Added operation SubscriptionOperations.list_alias
    [ChangeLog]   - Added operation SubscriptionOperations.create_alias
    [ChangeLog]   - Added operation SubscriptionOperations.delete_alias
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription_in_enrollment_account
    [ChangeLog]   - Removed operation SubscriptionOperations.create_csp_subscription
    [ChangeLog]   - Removed operation SubscriptionOperations.create_subscription
    [ChangeLog]   - Removed operation group SubscriptionOperationOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 3, 2020

azure-sdk-for-net - Release

failed [Logs] [Expand Details]
  • Generate from a2ea883 with merge commit 409fc85. SDK Automation 13.0.17.20200807.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • Microsoft.Azure.Management.Subscription [View full logs]  [Release SDK Changes]
      Failed to create the package Microsoft.Azure.Management.Subscription.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=subscription /v:n /p:SkipTests=true , {} 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 3, 2020

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 3, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 3, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 3, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 3, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from a2ea883 with merge commit 409fc85. SDK Automation 13.0.17.20200807.2
    • ️✔️@azure/arm-subscriptions [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/subscriptionClient.js → ./dist/arm-subscriptions.js...
      [npmPack] created ./dist/arm-subscriptions.js in 235ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-subscriptions@2.0.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 45.6kB dist/arm-subscriptions.js                        
      [npmPack] npm notice 14.8kB dist/arm-subscriptions.min.js                    
      [npmPack] npm notice 345B   esm/models/index.js                              
      [npmPack] npm notice 483B   esm/operations/index.js                          
      [npmPack] npm notice 15.3kB esm/models/mappers.js                            
      [npmPack] npm notice 1.5kB  esm/operations/operations.js                     
      [npmPack] npm notice 458B   esm/models/operationsMappers.js                  
      [npmPack] npm notice 1.7kB  esm/models/parameters.js                         
      [npmPack] npm notice 990B   rollup.config.js                                 
      [npmPack] npm notice 1.6kB  esm/subscriptionClient.js                        
      [npmPack] npm notice 2.2kB  esm/subscriptionClientContext.js                 
      [npmPack] npm notice 7.5kB  esm/operations/subscriptionOperations.js         
      [npmPack] npm notice 651B   esm/models/subscriptionOperationsMappers.js      
      [npmPack] npm notice 3.8kB  esm/operations/subscriptions.js                  
      [npmPack] npm notice 498B   esm/models/subscriptionsMappers.js               
      [npmPack] npm notice 2.2kB  esm/operations/tenants.js                        
      [npmPack] npm notice 441B   esm/models/tenantsMappers.js                     
      [npmPack] npm notice 1.7kB  package.json                                     
      [npmPack] npm notice 457B   tsconfig.json                                    
      [npmPack] npm notice 98.5kB dist/arm-subscriptions.js.map                    
      [npmPack] npm notice 14.7kB dist/arm-subscriptions.min.js.map                
      [npmPack] npm notice 6.4kB  esm/models/index.d.ts.map                        
      [npmPack] npm notice 204B   esm/operations/index.d.ts.map                    
      [npmPack] npm notice 126B   esm/models/index.js.map                          
      [npmPack] npm notice 219B   esm/operations/index.js.map                      
      [npmPack] npm notice 1.2kB  esm/models/mappers.d.ts.map                      
      [npmPack] npm notice 8.9kB  esm/models/mappers.js.map                        
      [npmPack] npm notice 663B   esm/operations/operations.d.ts.map               
      [npmPack] npm notice 908B   esm/operations/operations.js.map                 
      [npmPack] npm notice 215B   esm/models/operationsMappers.d.ts.map            
      [npmPack] npm notice 228B   esm/models/operationsMappers.js.map              
      [npmPack] npm notice 443B   esm/models/parameters.d.ts.map                   
      [npmPack] npm notice 1.2kB  esm/models/parameters.js.map                     
      [npmPack] npm notice 699B   esm/subscriptionClient.d.ts.map                  
      [npmPack] npm notice 852B   esm/subscriptionClient.js.map                    
      [npmPack] npm notice 424B   esm/subscriptionClientContext.d.ts.map           
      [npmPack] npm notice 1.2kB  esm/subscriptionClientContext.js.map             
      [npmPack] npm notice 3.0kB  esm/operations/subscriptionOperations.d.ts.map   
      [npmPack] npm notice 4.6kB  esm/operations/subscriptionOperations.js.map     
      [npmPack] npm notice 340B   esm/models/subscriptionOperationsMappers.d.ts.map
      [npmPack] npm notice 353B   esm/models/subscriptionOperationsMappers.js.map  
      [npmPack] npm notice 1.8kB  esm/operations/subscriptions.d.ts.map            
      [npmPack] npm notice 2.4kB  esm/operations/subscriptions.js.map              
      [npmPack] npm notice 244B   esm/models/subscriptionsMappers.d.ts.map         
      [npmPack] npm notice 257B   esm/models/subscriptionsMappers.js.map           
      [npmPack] npm notice 1.0kB  esm/operations/tenants.d.ts.map                  
      [npmPack] npm notice 1.4kB  esm/operations/tenants.js.map                    
      [npmPack] npm notice 199B   esm/models/tenantsMappers.d.ts.map               
      [npmPack] npm notice 212B   esm/models/tenantsMappers.js.map                 
      [npmPack] npm notice 3.3kB  README.md                                        
      [npmPack] npm notice 17.3kB esm/models/index.d.ts                            
      [npmPack] npm notice 167B   esm/operations/index.d.ts                        
      [npmPack] npm notice 16.7kB src/models/index.ts                              
      [npmPack] npm notice 451B   src/operations/index.ts                          
      [npmPack] npm notice 1.6kB  esm/models/mappers.d.ts                          
      [npmPack] npm notice 12.4kB src/models/mappers.ts                            
      [npmPack] npm notice 1.1kB  esm/operations/operations.d.ts                   
      [npmPack] npm notice 2.3kB  src/operations/operations.ts                     
      [npmPack] npm notice 148B   esm/models/operationsMappers.d.ts                
      [npmPack] npm notice 422B   src/models/operationsMappers.ts                  
      [npmPack] npm notice 475B   esm/models/parameters.d.ts                       
      [npmPack] npm notice 1.7kB  src/models/parameters.ts                         
      [npmPack] npm notice 999B   esm/subscriptionClient.d.ts                      
      [npmPack] npm notice 1.6kB  src/subscriptionClient.ts                        
      [npmPack] npm notice 649B   esm/subscriptionClientContext.d.ts               
      [npmPack] npm notice 2.0kB  src/subscriptionClientContext.ts                 
      [npmPack] npm notice 6.0kB  esm/operations/subscriptionOperations.d.ts       
      [npmPack] npm notice 12.6kB src/operations/subscriptionOperations.ts         
      [npmPack] npm notice 341B   esm/models/subscriptionOperationsMappers.d.ts    
      [npmPack] npm notice 619B   src/models/subscriptionOperationsMappers.ts      
      [npmPack] npm notice 4.0kB  esm/operations/subscriptions.d.ts                
      [npmPack] npm notice 7.7kB  src/operations/subscriptions.ts                  
      [npmPack] npm notice 188B   esm/models/subscriptionsMappers.d.ts             
      [npmPack] npm notice 463B   src/models/subscriptionsMappers.ts               
      [npmPack] npm notice 2.0kB  esm/operations/tenants.d.ts                      
      [npmPack] npm notice 4.0kB  src/operations/tenants.ts                        
      [npmPack] npm notice 131B   esm/models/tenantsMappers.d.ts                   
      [npmPack] npm notice 406B   src/models/tenantsMappers.ts                     
      [npmPack] npm notice 1.1kB  LICENSE.txt                                      
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-subscriptions                
      [npmPack] npm notice version:       2.0.0                                   
      [npmPack] npm notice filename:      azure-arm-subscriptions-2.0.0.tgz       
      [npmPack] npm notice package size:  45.6 kB                                 
      [npmPack] npm notice unpacked size: 357.8 kB                                
      [npmPack] npm notice shasum:        cd3feee0a342563180cf5909c838e8c9c751801e
      [npmPack] npm notice integrity:     sha512-WX+ZU2ZDgnHAP[...]rl8FP3yHmJNcQ==

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Confirmed identical to 2019-10-01-preview. Signed off from ARM side.

    @majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 3, 2020
    @navysingla navysingla changed the title Creating Stable version from Preview version [DO NOT MERGE] Creating Stable version from Preview version Aug 3, 2020
    @fengzhou-msft fengzhou-msft added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 6, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @navysingla
    Copy link
    Contributor Author

    @fengzhou-msft Not sure why sdk-net check is failing now, can you check ?

    @navysingla
    Copy link
    Contributor Author

    @fengzhou-msft Not sure why sdk-net check is failing now, can you check ?

    @fengzhou-msft can you help here fixing sdk error, seems like some sdkautomation. And can we merge this PR

    @fengzhou-msft
    Copy link
    Member

    @navysingla sdk-net failure can be ignored.

    @fengzhou-msft fengzhou-msft removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 14, 2020
    @fengzhou-msft fengzhou-msft merged commit 409fc85 into Azure:master Aug 14, 2020
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 14, 2020

    azure-resource-manager-schemas - Release

    failed [Logs] [Expand Details]
    • Generate from a2ea883 with merge commit 409fc85. Schema Automation 13.0.17.20200807.2
    • subscription [View full logs
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5609 passing (1m)
        AzureResourceSchema has no registered package commands.
        SDK Repository Package Error: HttpError: Resource not accessible by integration, {"name":"HttpError","status":403,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 14 Aug 2020 05:37:05 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"403 Forbidden","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0880:3CFE:24907F6:3E54390:5F362301","x-ratelimit-limit":"15000","x-ratelimit-remaining":"14534","x-ratelimit-reset":"1597384376","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/repos/Azure/azure-resource-manager-schemas/pulls","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{\"base\":\"master\",\"head\":\"AzureSDKAutomation:sdkAutomation/subscription\",\"title\":\"[ReleasePR subscription] Creating Stable version from Preview version\",\"body\":\"Created to release subscription.Reopen this PR to release the SDK.\\nIf you can't reopen it, click here to create a new one.\",\"maintainer_can_modify\":false}","request":{"validate":{"base":{"required":true,"type":"string"},"body":{"type":"string"},"draft":{"type":"boolean"},"head":{"required":true,"type":"string"},"maintainer_can_modify":{"type":"boolean"},"owner":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"title":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants