Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-mgmt-subscription broken: Subscription Creation Functionality Removed With No Replacement #14638

Closed
sas-adstut opened this issue Oct 20, 2020 · 4 comments
Closed

azure-mgmt-subscription broken: Subscription Creation Functionality Removed With No Replacement #14638

sas-adstut opened this issue Oct 20, 2020 · 4 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Subscription

Comments

@sas-adstut
Copy link

  • azure-mgmt-subscription:
  • 0.7.0:
  • All:
  • 3:

Describe the bug
A breaking change was committed, merged, and released with no justification and no alternative functionality provided. This change broke our automation used for creating new subscriptions and is forcing us to pin an old version of this package in our automation, which is less than ideal for many reasons.

Relevant commit, pull, and release:
380ae62
#14426
https://github.com/Azure/azure-sdk-for-python/releases/tag/azure-mgmt-subscription_0.7.0

To Reproduce
Steps to reproduce the behavior:

  1. Install latest azure-mgmt-subscription
  2. Attempt to use any of these functions, which were removed without an alternative being provided:
  • Removed operation SubscriptionOperations.create_subscription_in_enrollment_account
  • Removed operation SubscriptionOperations.create_subscription
  • Removed operation SubscriptionOperations.create_csp_subscription
  • Removed operation group SubscriptionOperationOperations

Expected behavior
Expect to be able to use the aforementioned functions for subscription creation or have an alternative function provided. Removing functionality without warning and providing no alternative is not expected behavior for any SDK.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 20, 2020
@kaerm kaerm added Mgmt This issue is related to a management-plane library. needs-team-triage Workflow: This issue needs the team to triage. Subscription labels Oct 20, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 20, 2020
@changlong-liu changlong-liu added the Service Attention Workflow: This issue is responsible by Azure service team. label Oct 23, 2020
@ghost
Copy link

ghost commented Oct 23, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anuragdalmia, @ShilpiGautam, @ramaganesan-rg.

@changlong-liu
Copy link
Member

Hi service team, the breaking changes come from this PR: Azure/azure-rest-api-specs#10321

Would you help to check whether it's by design?

@anuragdalmia
Copy link

we have released our GA version for subscription creation APIs which is to use New-AzSubscriptionAlias cmdlet for subscription creation automations. You can see this documented in detail at https://docs.microsoft.com/en-us/azure/cost-management-billing/manage/programmatically-create-subscription-enterprise-agreement?tabs=rest-getEnrollments%2Crest-EA.

We are asking everyone to move to adopt to this new cmdlet which is GA. We will keep the preview cmdlet around (only in older versions) until folks have had the chance to migrate and dont have a timeline when we will stop supporting preview versions.

@anuragdalmia
Copy link

Please re-activate if this doesnt address your issue.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jul 1, 2021
CodeGen from PR 14638 in Azure/azure-rest-api-specs
e3956a2 
Move RestorePoint properties into new properties bag for restore point (Azure#14638)
msyyc pushed a commit that referenced this issue Jul 8, 2021
[AutoRelease] t2-compute-2021-07-08-85328 (#19715)
47acc05 
* CodeGen from PR 14638 in Azure/azure-rest-api-specs
Move RestorePoint properties into new properties bag for restore point (#14638)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
xiangyan99 added a commit that referenced this issue Jul 8, 2021
@xiangyan99 @chlowell
@mccoyp @msyyc @azure-sdk @annatisch @scbedd @dependabot
Get latest main (#19733)
3b6d22f 
* Credentials accept tenant_id argument to get_token (#19602)

* Update changelog for azure-identity 1.7.0b2 (#19693)

* [Key Vault] Drop 3.5 support for keys (#19712)

* [AutoRelease] t2-compute-2021-07-08-85328 (#19715)

* CodeGen from PR 14638 in Azure/azure-rest-api-specs
Move RestorePoint properties into new properties bag for restore point (#14638)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* debug_guide for python SDK (#19716)

* Increment package version after release of azure-servicebus (#19709)

* Increment package version after release of azure-identity (#19721)

* Prevent DeprecationWarning in Identity tests (#19723)

* move _utils.py (#19431)

* move _utils.py

* update

* [QnA] Initial SDK (#19544)

* Template + first code gen

* Basic client

* First tests

* Added async client + tests

* Added answerspan test

* Added authoring APIs

* Some updates

* Pure generated clients

* Test updates

* Update test imports

* Clean working recordings

* Renamed directory

* Removed authoring for now

* Use unreleased core

* Remove conversation + ci yaml

* Some CI updates

* update language __init__.py to not have a space in the name

* Setup.py

* Updated core dependency

* CI fixes

* Added language nspkg

* Fix Python 2.7

* Added some more tests

* Test fixes

* Added live configuration

* Bumped msrest

* readme + samples

* No pypi or refdocs yet

* Review feedback

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* fix broken rest due to utils movement (#19728)

* handle details "null" (#19430)

* handle details "null"

* update

* Bump aiohttp from 3.5.4 to 3.7.4 in /common/smoketest (#19330)

Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.5.4 to 3.7.4.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.5.4...v3.7.4)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
xiangyan99 added a commit that referenced this issue Jul 9, 2021
@xiangyan99 @chlowell
@mccoyp @msyyc @azure-sdk @annatisch @scbedd @dependabot
leave stream open in response (#19711)
a3f454d 
* leave stream open in response

* update

* Get latest main (#19733)

* Credentials accept tenant_id argument to get_token (#19602)

* Update changelog for azure-identity 1.7.0b2 (#19693)

* [Key Vault] Drop 3.5 support for keys (#19712)

* [AutoRelease] t2-compute-2021-07-08-85328 (#19715)

* CodeGen from PR 14638 in Azure/azure-rest-api-specs
Move RestorePoint properties into new properties bag for restore point (#14638)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* debug_guide for python SDK (#19716)

* Increment package version after release of azure-servicebus (#19709)

* Increment package version after release of azure-identity (#19721)

* Prevent DeprecationWarning in Identity tests (#19723)

* move _utils.py (#19431)

* move _utils.py

* update

* [QnA] Initial SDK (#19544)

* Template + first code gen

* Basic client

* First tests

* Added async client + tests

* Added answerspan test

* Added authoring APIs

* Some updates

* Pure generated clients

* Test updates

* Update test imports

* Clean working recordings

* Renamed directory

* Removed authoring for now

* Use unreleased core

* Remove conversation + ci yaml

* Some CI updates

* update language __init__.py to not have a space in the name

* Setup.py

* Updated core dependency

* CI fixes

* Added language nspkg

* Fix Python 2.7

* Added some more tests

* Test fixes

* Added live configuration

* Bumped msrest

* readme + samples

* No pypi or refdocs yet

* Review feedback

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* fix broken rest due to utils movement (#19728)

* handle details "null" (#19430)

* handle details "null"

* update

* Bump aiohttp from 3.5.4 to 3.7.4 in /common/smoketest (#19330)

Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.5.4 to 3.7.4.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.5.4...v3.7.4)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this issue Jul 16, 2021
@rakshith91
[AutoRelease] t2-compute-2021-07-08-85328 (Azure#19715)
a919309 
* CodeGen from PR 14638 in Azure/azure-rest-api-specs
Move RestorePoint properties into new properties bag for restore point (Azure#14638)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this issue Jul 16, 2021
@xiangyan99 @chlowell
@mccoyp @msyyc @azure-sdk @annatisch @scbedd @dependabot @rakshith91
leave stream open in response (Azure#19711)
5fcb56f 
* leave stream open in response

* update

* Get latest main (Azure#19733)

* Credentials accept tenant_id argument to get_token (Azure#19602)

* Update changelog for azure-identity 1.7.0b2 (Azure#19693)

* [Key Vault] Drop 3.5 support for keys (Azure#19712)

* [AutoRelease] t2-compute-2021-07-08-85328 (Azure#19715)

* CodeGen from PR 14638 in Azure/azure-rest-api-specs
Move RestorePoint properties into new properties bag for restore point (Azure#14638)

* version,CHANGELOG

* test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

* debug_guide for python SDK (Azure#19716)

* Increment package version after release of azure-servicebus (Azure#19709)

* Increment package version after release of azure-identity (Azure#19721)

* Prevent DeprecationWarning in Identity tests (Azure#19723)

* move _utils.py (Azure#19431)

* move _utils.py

* update

* [QnA] Initial SDK (Azure#19544)

* Template + first code gen

* Basic client

* First tests

* Added async client + tests

* Added answerspan test

* Added authoring APIs

* Some updates

* Pure generated clients

* Test updates

* Update test imports

* Clean working recordings

* Renamed directory

* Removed authoring for now

* Use unreleased core

* Remove conversation + ci yaml

* Some CI updates

* update language __init__.py to not have a space in the name

* Setup.py

* Updated core dependency

* CI fixes

* Added language nspkg

* Fix Python 2.7

* Added some more tests

* Test fixes

* Added live configuration

* Bumped msrest

* readme + samples

* No pypi or refdocs yet

* Review feedback

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* fix broken rest due to utils movement (Azure#19728)

* handle details "null" (Azure#19430)

* handle details "null"

* update

* Bump aiohttp from 3.5.4 to 3.7.4 in /common/smoketest (Azure#19330)

Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.5.4 to 3.7.4.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.5.4...v3.7.4)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Azure CLI Bot <azclibot@microsoft.com>
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Subscription
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anuragdalmia @kaerm @sas-adstut @changlong-liu