[Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview #10773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
This was referenced Sep 13, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
Comment on lines
216
to
218
| "200": { | ||
| "description": "Downloaded activation file" | ||
| }, |
There was a problem hiding this comment.
What is the schema of the response? I assume as a "download" there had to be something in response.
There was a problem hiding this comment.
Actual file download (binary).
There was a problem hiding this comment.
But you need to specify it somehow? Else how SDK knows that there is a binary file as reponse?
Usually it is
"schema": {
"type": "file"
}
Also
"produces": [
"application/octet-stream"
],
| "$ref": "#/definitions/OnPremiseIotSensor" | ||
| } | ||
| }, | ||
| "201": { |
There was a problem hiding this comment.
Is this long-running operation?
There was a problem hiding this comment.
No, it's a synchronous operation that completes immediately.
added 2 commits
September 15, 2020 07:30
…urity-2020-08-06-preview
|
Azure Pipelines successfully started running 1 pipeline(s). |
…urity-2020-08-06-preview
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
added
ARMSignedOff
pilor
approved these changes
Sep 22, 2020
…urity-2020-08-06-preview
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@pilor @weidongxu-microsoft can you please merge the PR? (Fixed the merge conflict. Plus, the failed SDK Go check isn't related to these changes [also fails in the |
weidongxu-microsoft
approved these changes
Sep 23, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
…preview/2020-08-06-preview (Azure#10773) * Add onPremiseSensors * Suppress * Specify file download schema * Fix validaiton Co-authored-by: Liran Chen <lirche@microsoft.com>
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 14, 2020
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (52 commits) rename synapse model in java (Azure#10911) [Microsoft.Storage] Adding support for ResourceAccessRules (Azure#10868) add fix (Azure#10906) Revert "[Do Not Merge][Really To Review] add a new apis (Azure#10756)" (Azure#10908) [Do Not Merge][Really To Review] add a new apis (Azure#10756) Add documentation for downloading invoices through Microsoft.Billing API (Azure#10585) Add api-version of 2019-10-01/comsuption to go SDK (Azure#10749) Add location info for cross region compute feature (Azure#10816) Operationalinsights/data export delete all tables param (Azure#10775) Update SDKAutomation.yml for Azure Pipelines (Azure#10904) [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10902) [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-05-01-preview (Azure#10891) Add readme.azureresourceschema.md for sample rp (Azure#10764) [Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview (Azure#10773) DataFactory: Update Rest Sink properties based on ship room comments. (Azure#10815) Bring up ACS eventgrid events swagger (Azure#10880) Assignment config (Azure#10850) .md for python (Azure#10881) Fixed ActionRule's polymorphism via discriminator (Azure#10829) Fixed S360 issues related to ARM & SDK swagger linting errors for Microsoft.Solutions. (Azure#10804) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.