-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microsoft.Storage] Adding support for ResourceAccessRules #10868
Conversation
[Microsoft.Storage] Adding support for ResourceAccessRules
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'resourceAccessRules' in response that was not found in the old version. New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L2061:7 Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L2048:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
...nager/Microsoft.Storage/preview/2020-08-01-preview/examples/StorageAccountGetProperties.json
Show resolved
Hide resolved
...source-manager/Microsoft.Storage/preview/2020-08-01-preview/examples/StorageAccountList.json
Show resolved
Hide resolved
...urce-manager/Microsoft.Storage/preview/2020-08-01-preview/examples/StorageAccountUpdate.json
Show resolved
Hide resolved
...urce-manager/Microsoft.Storage/preview/2020-08-01-preview/examples/StorageAccountUpdate.json
Show resolved
Hide resolved
@@ -1979,6 +1979,19 @@ | |||
], | |||
"description": "The encryption settings on the storage account." | |||
}, | |||
"ResourceAccessRule": { | |||
"properties": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add action
property similar with VirtualNetworkRule and IPRule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not part of the spec.
Hi @priyapansrp , please add in storage readme file to make CI pass. Here is an example https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/data-plane/readme.python.md.
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
* [Microsoft.Storage] Adding support for ResourceAccessRules [Microsoft.Storage] Adding support for ResourceAccessRules * PrettierCheck failure
Hi all, apologies for posting in this PR, but I'm trying to use autorest to process the Microsoft.Storage spec with a custom plugin and I notice that there's discussion about the I'm currently hitting an issue described in #10979 where autorest fails to process the Microsoft.Storage spec, with the following error:
However, I notice that CI here has passed. Do any of the contributors here know how I might mitigate the duplicate object schema errors I'm seeing? |
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (52 commits) rename synapse model in java (Azure#10911) [Microsoft.Storage] Adding support for ResourceAccessRules (Azure#10868) add fix (Azure#10906) Revert "[Do Not Merge][Really To Review] add a new apis (Azure#10756)" (Azure#10908) [Do Not Merge][Really To Review] add a new apis (Azure#10756) Add documentation for downloading invoices through Microsoft.Billing API (Azure#10585) Add api-version of 2019-10-01/comsuption to go SDK (Azure#10749) Add location info for cross region compute feature (Azure#10816) Operationalinsights/data export delete all tables param (Azure#10775) Update SDKAutomation.yml for Azure Pipelines (Azure#10904) [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10902) [Hub Generated] Review request for Microsoft.Insights to add version preview/2020-05-01-preview (Azure#10891) Add readme.azureresourceschema.md for sample rp (Azure#10764) [Hub Generated] Review request for Microsoft.Security to add version preview/2020-08-06-preview (Azure#10773) DataFactory: Update Rest Sink properties based on ship room comments. (Azure#10815) Bring up ACS eventgrid events swagger (Azure#10880) Assignment config (Azure#10850) .md for python (Azure#10881) Fixed ActionRule's polymorphism via discriminator (Azure#10829) Fixed S360 issues related to ARM & SDK swagger linting errors for Microsoft.Solutions. (Azure#10804) ...
Hi, are you using trying to generate track2 related SDK or something else? To bypass the issue, you need to configure modelerfour. Here is to generate python SDK and the following configuration should work https://github.com/Azure/azure-rest-api-specs/blob/master/specification/storage/resource-manager/readme.python.md#python. |
[Microsoft.Storage] Adding support for ResourceAccessRules
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.