-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Factory]Add logSettings and upgrade Concur linked service for ADF public swagger #10903
Conversation
Merge from origin
Merge from origin
Merge from origin
Merge from origin
Merge from origin
Merge from origin
Merge from master
Merge from origin
Merge from origin
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@@ -1475,9 +1475,13 @@ | |||
"$ref": "#/definitions/RedirectIncompatibleRowSettings" | |||
}, | |||
"logStorageSettings": { | |||
"description": "Log storage settings customer need to provide when enabling session log.", | |||
"description": "(Deprecated. Please use LogSettings) Log storage settings customer need to provide when enabling session log.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this property deprecated in ADF service? Will it break existing customers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Existing customers will still be supported with this property.
@rickysun93 please help fix the CI error to get the PR ready to merge. |
@qianwens I didn't do any changes to the model of RestSink". Don't know why it reports a breaking change. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Could you please fix the pretty check failure? |
Azure Pipelines successfully started running 1 pipeline(s). |
7748d93
to
591d372
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.