Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory]Added publicNetworkAccess property to datafactory and added logSettings property into CopyActivity #15961

Merged
merged 11 commits into from
Oct 19, 2020

Conversation

Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Oct 14, 2020

swagger pr:

Copy link
Member

@YalinLi0312 YalinLi0312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One minor comment, you may forget to update the related tests.

@Jingshu923
Copy link
Contributor Author

Update a related test

@Jingshu923 Jingshu923 changed the title [DataFactory]Added publicNetworkAccess property to datafactory [DataFactory]Added publicNetworkAccess property to datafactory and added logSettings property into CopyActivity Oct 16, 2020
@YalinLi0312 YalinLi0312 merged commit 00028aa into Azure:master Oct 19, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants