-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. #11392
Merged
leni-msft
merged 2 commits into
Azure:dev-storagesync-Microsoft.StorageSync-2020-09-01
from
Manishd79:manidu-initialuploadpolicy
Oct 27, 2020
Merged
Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. #11392
leni-msft
merged 2 commits into
Azure:dev-storagesync-Microsoft.StorageSync-2020-09-01
from
Manishd79:manidu-initialuploadpolicy
Oct 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'initialUploadPolicy' in response that was not found in the old version. New: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4357:7 Old: Microsoft.StorageSync/preview/2020-09-01/storagesync.json#L4353:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @Manishd79 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
azure-sdk-for-js
|
Azure CLI Extension Generation
|
azure-sdk-for-java
|
azure-sdk-for-net
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 26, 2020
This was referenced Oct 26, 2020
Manishd79
changed the title
DONOT COMMIT: Update Microsoft.StorageSync (2020-09-01 API version) for initialuploadpolicy property for SEP
Update Microsoft.StorageSync (2020-09-01 API version) for initialuploadpolicy property for SEP
Oct 26, 2020
ankushbindlish2
changed the title
Update Microsoft.StorageSync (2020-09-01 API version) for initialuploadpolicy property for SEP
Microsoft.StorageSync : Update Api Version 2020-09-01 for InitialUploadPolicy feature.
Oct 26, 2020
ankushbindlish2
changed the title
Microsoft.StorageSync : Update Api Version 2020-09-01 for InitialUploadPolicy feature.
Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature.
Oct 26, 2020
Manishd79
changed the title
Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature.
DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature.
Oct 26, 2020
ankushbindlish2
changed the base branch from
master
to
dev-storagesync-Microsoft.StorageSync-2020-09-01
October 27, 2020 04:34
ankushbindlish2
approved these changes
Oct 27, 2020
ankushbindlish2
changed the title
DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature.
Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature.
Oct 27, 2020
leni-msft
merged commit Oct 27, 2020
e61c491
into
Azure:dev-storagesync-Microsoft.StorageSync-2020-09-01
This was referenced May 13, 2021
PhoenixHe-NV
pushed a commit
that referenced
this pull request
Jun 10, 2021
* DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. (#11392) * update initialuploadpolicy * Update test for InitialUploadPolicy setting Co-authored-by: Manish Duggal <manidu@microsoft.com> * [Microsoft.StorageSync] change enumeration protocol changes for 2020-09-01 (#12793) * change eumeration protocol changes * fix unexpected changes * StorageSync new api version 2020-09-01 (#14005) * change * del * revert * Remove systemData changes (postponed to future API version) * run prettier * Address breaking changes and S360 item for default values * run prettier Co-authored-by: Andre Pinto <anpint@microsoft.com> Co-authored-by: Manishd79 <duggal_sunny@yahoo.com> Co-authored-by: Manish Duggal <manidu@microsoft.com> Co-authored-by: ankushbindlish2 <34896519+ankushbindlish2@users.noreply.github.com>
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. (Azure#11392) * update initialuploadpolicy * Update test for InitialUploadPolicy setting Co-authored-by: Manish Duggal <manidu@microsoft.com> * [Microsoft.StorageSync] change enumeration protocol changes for 2020-09-01 (Azure#12793) * change eumeration protocol changes * fix unexpected changes * StorageSync new api version 2020-09-01 (Azure#14005) * change * del * revert * Remove systemData changes (postponed to future API version) * run prettier * Address breaking changes and S360 item for default values * run prettier Co-authored-by: Andre Pinto <anpint@microsoft.com> Co-authored-by: Manishd79 <duggal_sunny@yahoo.com> Co-authored-by: Manish Duggal <manidu@microsoft.com> Co-authored-by: ankushbindlish2 <34896519+ankushbindlish2@users.noreply.github.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. (Azure#11392) * update initialuploadpolicy * Update test for InitialUploadPolicy setting Co-authored-by: Manish Duggal <manidu@microsoft.com> * [Microsoft.StorageSync] change enumeration protocol changes for 2020-09-01 (Azure#12793) * change eumeration protocol changes * fix unexpected changes * StorageSync new api version 2020-09-01 (Azure#14005) * change * del * revert * Remove systemData changes (postponed to future API version) * run prettier * Address breaking changes and S360 item for default values * run prettier Co-authored-by: Andre Pinto <anpint@microsoft.com> Co-authored-by: Manishd79 <duggal_sunny@yahoo.com> Co-authored-by: Manish Duggal <manidu@microsoft.com> Co-authored-by: ankushbindlish2 <34896519+ankushbindlish2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.