Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix readme Configuration Tags for Authorization #12590

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix readme Configuration Tags for Authorization #12590

merged 1 commit into from
Jan 26, 2021

Conversation

ctaggart
Copy link
Contributor

This just fixes parsing of the readme. A Tag must be directly below a Configuration, not Suppression.

@ctaggart ctaggart requested a review from lirenhe as a code owner January 25, 2021 01:09
@openapi-workflow-bot
Copy link

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fa41e3e. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-26 07:05:53 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
cmderr	[generate.py] 2021-01-26 07:05:53 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-26 07:05:53 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[generate.py] 2021-01-26 07:06:29 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-26 07:06:29 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-26 07:06:29 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-26 07:06:29 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-26 07:06:29 INFO [POM][Skip] pom already has module sdk/authorization
cmderr	[generate.py] 2021-01-26 07:06:29 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-authorization-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-26 07:08:36 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
cmderr	[Inst] 2021-01-26 07:08:36 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-26 07:08:36 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-26 07:08:36 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-26 07:08:36 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-26 07:08:36 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12590/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fa41e3e. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
cmderr	[npmPack] created ./dist/arm-authorization.js in 210ms
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fa41e3e. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RoleAssignment has a new parameter created_by
info	[Changelog]   - Model RoleAssignment has a new parameter updated_on
info	[Changelog]   - Model RoleAssignment has a new parameter created_on
info	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
info	[Changelog]   - Model RoleAssignment has a new parameter updated_by
info	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
info	[Changelog]   - Added operation group AccessReviewInstancesOperations
info	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
info	[Changelog]   - Added operation group AccessReviewInstanceOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations
info	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
info	[Changelog]   - Added operation group Operations
info	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fa41e3e. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️authorization/mgmt/2015-07-01/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fa41e3e. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
    • ️✔️authorization [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jan 25, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @ctaggart ctaggart mentioned this pull request Jan 25, 2021
    Closed
    11 tasks
    @qianwens qianwens merged commit fa41e3e into Azure:master Jan 26, 2021
    This was referenced Jan 26, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @ctaggart ctaggart deleted the tags-Authorization branch January 26, 2021 21:33
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @cataggar @mkarmark
    fix readme Configuration Tags for Authorization (Azure#12590)
    5e84beb
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qianwens qianwens qianwens approved these changes

    @lirenhe lirenhe Awaiting requested review from lirenhe

    Assignees

    @qianwens qianwens

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @ctaggart @qianwens @cataggar