Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing services due to invalid readme formatting #159

Closed
11 tasks done
ctaggart opened this issue Jan 25, 2021 · 3 comments
Closed
11 tasks done

missing services due to invalid readme formatting #159

ctaggart opened this issue Jan 25, 2021 · 3 comments
Assignees
@ctaggart
Labels
CodeGen Issues that relate to code generation

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Jan 25, 2021 •
edited
Loading

Several services are missing because of incorrect formatting in the readme files. The ### Tag:s are supposed to be under ## Configuration in the readme files. Unfortunately, several readme files have put them under ## Suppression or ## Composite packages. To fix the readme files, another ### should be used for those headings when they are underneath ## Configuration. I've added pull requests to fix the readme files. We could also loosen up our parser and support ### Tag:s anywhere in the file even in incorrect hierarchies.

data-plane

resource-management
@ctaggart ctaggart changed the title missing services do to invalid readme formatting missing services due to invalid readme formatting Jan 25, 2021
@rylev rylev added the CodeGen Issues that relate to code generation label Jan 27, 2021
@ctaggart ctaggart self-assigned this Jan 27, 2021
@ctaggart
Copy link
Contributor Author

My last PR finally got merged yesterday.

@rylev
Copy link
Contributor

rylev commented Mar 24, 2021

Can we close this then?

@ctaggart
Copy link
Contributor Author

Recently also fixed adp Azure/azure-rest-api-specs#13850 and opened a pull request for subscription Azure/azure-rest-api-specs#14001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctaggart ctaggart

Labels
CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctaggart @rylev