Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme Configuration Tags for security #12595

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

ctaggart
Copy link
Contributor

This just fixes parsing of the readme. A Tag must be directly below a Configuration, not Suppression.

@ctaggart ctaggart requested a review from lirenhe as a code owner January 25, 2021 01:39
@openapi-workflow-bot
Copy link

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5bb191. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/security/mgmt/v3.0/security [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog] - New function `AlertsClient.UpdateSubscriptionLevelStateToActivate(context.Context, string) (autorest.Response, error)`
      info	[Changelog] - New function `AlertsClient.UpdateResourceGroupLevelStateToActivateSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `AlertsClient.GetSubscriptionLevelResponder(*http.Response) (Alert, error)`
      info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsActiveConnectionsNotInAllowedRange() (*ActiveConnectionsNotInAllowedRange, bool)`
      info	[Changelog] - New function `AlertsClient.UpdateSubscriptionLevelStateToActivateSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsCustomAlertRule() (*CustomAlertRule, bool)`
      info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsBasicCustomAlertRule() (BasicCustomAlertRule, bool)`
      info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
      info	[Changelog] - New function `AlertSimulatorRequestProperties.AsBasicAlertSimulatorRequestProperties() (BasicAlertSimulatorRequestProperties, bool)`
      info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsAllowlistCustomAlertRule() (*AllowlistCustomAlertRule, bool)`
      info	[Changelog] - New function `DenylistCustomAlertRule.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
      info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsQueuePurgesNotInAllowedRange() (*QueuePurgesNotInAllowedRange, bool)`
      info	[Changelog] - New function `TimeWindowCustomAlertRule.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
      info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsDenylistCustomAlertRule() (*DenylistCustomAlertRule, bool)`
      info	[Changelog] - New function `AlertsClient.UpdateSubscriptionLevelStateToDismiss(context.Context, string) (autorest.Response, error)`
      info	[Changelog] - New function `FileUploadsNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
      info	[Changelog] - New struct `AdditionalWorkspacesProperties`
      info	[Changelog] - New struct `AlertSimulatorBundlesRequestProperties`
      info	[Changelog] - New struct `AlertSimulatorRequestBody`
      info	[Changelog] - New struct `AlertSimulatorRequestProperties`
      info	[Changelog] - New struct `AlertsSimulateFuture`
      info	[Changelog] - New struct `ConnectionFromIPNotAllowed`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ServerVulnerabilityAssessmentDeleteFuture`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New field `SystemData` in struct `IoTSecuritySolutionModel`
      info	[Changelog] - New field `Name` in struct `IotAlertModel`
      info	[Changelog] - New field `Type` in struct `IotAlertModel`
      info	[Changelog] - New field `ID` in struct `IotAlertModel`
      info	[Changelog] - New field `Target` in struct `CloudErrorBody`
      info	[Changelog] - New field `Details` in struct `CloudErrorBody`
      info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
      info	[Changelog] - New field `ID` in struct `IotAlert`
      info	[Changelog] - New field `Name` in struct `IotAlert`
      info	[Changelog] - New field `Type` in struct `IotAlert`
      info	[Changelog] - New field `IsEnterpriseSensor` in struct `IotSensorProperties`
      info	[Changelog] - New field `AdditionalWorkspaces` in struct `IoTSecuritySolutionProperties`
      info	[Changelog]
      info	[Changelog] Total 50 breaking change(s), 165 additive change(s).
      info	[Changelog]
    • ️✔️preview/security/mgmt/v2.0/security [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog] - Const `Alerts` has been removed
      info	[Changelog] - Const `SecureScores` has been removed
      info	[Changelog] - Const `SubAssessments` has been removed
      info	[Changelog] - Const `Assessments` has been removed
      info	[Changelog] - Const `SettingKindAlertSuppressionSetting` has been removed
      info	[Changelog] - Const `SettingKindDataExportSetting` has been removed
      info	[Changelog] - Function `SettingResource.MarshalJSON` has been removed
      info	[Changelog] - Function `PossibleSettingKindValues` has been removed
      info	[Changelog] - Struct `SettingResource` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `KindSetting`
      info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessment`
      info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessmentSnapshot`
      info	[Changelog] - New const `KindDataExportSetting`
      info	[Changelog] - New const `EventSourceAssessments`
      info	[Changelog] - New const `EventSourceSecureScoreControls`
      info	[Changelog] - New const `EventSourceSecureScores`
      info	[Changelog] - New const `EventSourceSecureScoreControlsSnapshot`
      info	[Changelog] - New const `EventSourceSubAssessments`
      info	[Changelog] - New const `EventSourceSecureScoresSnapshot`
      info	[Changelog] - New const `EventSourceAlerts`
      info	[Changelog] - New function `DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)`
      info	[Changelog] - New function `Setting.AsSetting() (*Setting, bool)`
      info	[Changelog] - New function `DataExportSetting.AsSetting() (*Setting, bool)`
      info	[Changelog] - New function `Setting.AsDataExportSetting() (*DataExportSetting, bool)`
      info	[Changelog] - New function `DataExportSetting.AsBasicSetting() (BasicSetting, bool)`
      info	[Changelog] - New function `Setting.AsBasicSetting() (BasicSetting, bool)`
      info	[Changelog] - New function `PossibleKindEnum1Values() []KindEnum1`
      info	[Changelog] - New function `*SettingModel.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*SettingsList.UnmarshalJSON([]byte) error`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `SettingModel`
      info	[Changelog] - New field `Target` in struct `CloudErrorBody`
      info	[Changelog] - New field `Details` in struct `CloudErrorBody`
      info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
      info	[Changelog]
      info	[Changelog] Total 29 breaking change(s), 26 additive change(s).
      info	[Changelog]
    • ️✔️preview/security/mgmt/v1.0/security [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog] - Const `SubAssessments` has been removed
      info	[Changelog] - Const `SettingKindAlertSuppressionSetting` has been removed
      info	[Changelog] - Const `SecureScores` has been removed
      info	[Changelog] - Const `Alerts` has been removed
      info	[Changelog] - Const `SettingKindDataExportSetting` has been removed
      info	[Changelog] - Const `Assessments` has been removed
      info	[Changelog] - Function `SettingResource.MarshalJSON` has been removed
      info	[Changelog] - Function `PossibleSettingKindValues` has been removed
      info	[Changelog] - Struct `SettingResource` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `EventSourceSecureScoresSnapshot`
      info	[Changelog] - New const `EventSourceSecureScoreControlsSnapshot`
      info	[Changelog] - New const `EventSourceSecureScoreControls`
      info	[Changelog] - New const `EventSourceSubAssessments`
      info	[Changelog] - New const `EventSourceSecureScores`
      info	[Changelog] - New const `KindSetting`
      info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessmentSnapshot`
      info	[Changelog] - New const `EventSourceAlerts`
      info	[Changelog] - New const `EventSourceAssessments`
      info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessment`
      info	[Changelog] - New const `KindDataExportSetting`
      info	[Changelog] - New function `Setting.AsDataExportSetting() (*DataExportSetting, bool)`
      info	[Changelog] - New function `DataExportSetting.AsBasicSetting() (BasicSetting, bool)`
      info	[Changelog] - New function `DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)`
      info	[Changelog] - New function `*SettingModel.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `*SettingsList.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PossibleKindEnum1Values() []KindEnum1`
      info	[Changelog] - New function `Setting.AsSetting() (*Setting, bool)`
      info	[Changelog] - New function `DataExportSetting.AsSetting() (*Setting, bool)`
      info	[Changelog] - New function `Setting.AsBasicSetting() (BasicSetting, bool)`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `SettingModel`
      info	[Changelog] - New field `Target` in struct `CloudErrorBody`
      info	[Changelog] - New field `Details` in struct `CloudErrorBody`
      info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
      info	[Changelog]
      info	[Changelog] Total 29 breaking change(s), 26 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e5bb191. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter additional_workspaces
      info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter system_data
      info	[Changelog]   - Model IotAlert has a new parameter id
      info	[Changelog]   - Model IotAlert has a new parameter type
      info	[Changelog]   - Model IotAlert has a new parameter name
      info	[Changelog]   - Model PackageDownloads has a new parameter authorized_devices_import_template
      info	[Changelog]   - Model PackageDownloads has a new parameter device_information_update_import_template
      info	[Changelog]   - Model PackageDownloads has a new parameter snmp
      info	[Changelog]   - Model PackageDownloads has a new parameter wmi_tool
      info	[Changelog]   - Model IotAlertModel has a new parameter id
      info	[Changelog]   - Model IotAlertModel has a new parameter type
      info	[Changelog]   - Model IotAlertModel has a new parameter name
      info	[Changelog]   - Added operation IotDefenderSettingsOperations.download_manager_activation
      info	[Changelog]   - Added operation IotSensorsOperations.trigger_ti_package_update
      info	[Changelog]   - Added operation IotSensorsOperations.download_reset_password
      info	[Changelog]   - Added operation OnPremiseIotSensorsOperations.download_reset_password
      info	[Changelog]   - Added operation AlertsOperations.update_resource_group_level_state_to_dismiss
      info	[Changelog]   - Added operation AlertsOperations.simulate
      info	[Changelog]   - Added operation AlertsOperations.list_resource_group_level_by_region
      info	[Changelog]   - Added operation AlertsOperations.get_subscription_level
      info	[Changelog]   - Added operation AlertsOperations.get_resource_group_level
      info	[Changelog]   - Added operation AlertsOperations.update_resource_group_level_state_to_activate
      info	[Changelog]   - Added operation AlertsOperations.update_subscription_level_state_to_dismiss
      info	[Changelog]   - Added operation AlertsOperations.update_subscription_level_state_to_activate
      info	[Changelog]   - Added operation AlertsOperations.list_subscription_level_by_region
      info	[Changelog]   - Added operation group IotSitesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation IotSensorsOperations.create_or_update has a new signature
      info	[Changelog]   - Removed operation AlertsOperations.get_subscription_level_alert
      info	[Changelog]   - Removed operation AlertsOperations.list_subscription_level_alerts_by_region
      info	[Changelog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state_to_dismiss
      info	[Changelog]   - Removed operation AlertsOperations.get_resource_group_level_alerts
      info	[Changelog]   - Removed operation AlertsOperations.list_resource_group_level_alerts_by_region
      info	[Changelog]   - Removed operation AlertsOperations.update_resource_group_level_alert_state_to_reactivate
      info	[Changelog]   - Removed operation AlertsOperations.update_subscription_level_alert_state_to_reactivate
      info	[Changelog]   - Removed operation AlertsOperations.update_subscription_level_alert_state_to_dismiss
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5bb191. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/security/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.SecurityCenter [View full logs]  [Release SDK Changes]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5bb191. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/security/resource-manager/readme.md
    • ️✔️security [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
      cmderr	[resource-manager]  ERR! code ELIFECYCLE
      cmderr	[resource-manager] npm ERR! errno 1
      cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
      cmderr	[resource-manager] npm ERR! Exit status 1
      cmderr	[resource-manager] npm ERR!
      cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
      cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      cmderr	[resource-manager]  A complete log of this run can be found in:
      cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-02-26T06_17_21_879Z-debug.log
      cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
      cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
      cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
      cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
      cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
      cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
      cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
      cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
      cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
      cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
      cmderr	[resource-manager]   status: 1,
      cmderr	[resource-manager]   signal: null,
      cmderr	[resource-manager]   output: [ null, null, null ],
      cmderr	[resource-manager]   pid: 3343,
      cmderr	[resource-manager]   stdout: null,
      cmderr	[resource-manager]   stderr: null
      cmderr	[resource-manager] }
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e5bb191. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/security/resource-manager/readme.md
    • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
      cmderr	[npmPack] created ./dist/arm-security.js in 1.3s
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @ctaggart
    Copy link
    Contributor Author

    ctaggart commented Feb 6, 2021

    @ruowan, this was opened 12 days ago. Can you please review these changes.

    @ghost
    Copy link

    ghost commented Feb 21, 2021

    Hi, @ctaggart. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Feb 21, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants