Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

Merged
merged 23 commits into from
Feb 20, 2021
Merged

EventGrid: Fix multiple linter and swagger correctness/completeness issues for latest preview and stable API versions #12767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b9693fc
fix example
Nov 11, 2020
8760d97
Merge remote-tracking branch 'upstream/master'
Feb 1, 2021
69b51d3
Fix multiple linter and swagger correctness/completeness issues for l…
Feb 1, 2021
6cdf899
Fix format
Feb 1, 2021
0ad8a2b
fix examples
Feb 1, 2021
2b135a0
fix validation model errors
Feb 2, 2021
a35eabb
fix validation model errors
Feb 2, 2021
ca30817
fix example
Feb 2, 2021
abdb2ea
remove default
Feb 2, 2021
6336734
revert 2020-06 changes
Feb 2, 2021
5a098e8
Merge remote-tracking branch 'upstream/master'
Feb 16, 2021
4ffba9d
fix eventgrid swagger file with multiple linter and correctness fixes
Feb 17, 2021
a4d76ef
fix 2020-06-01 stable swagger
Feb 17, 2021
73fdf74
fix 2020-06-01 stable swagger -- part 2
Feb 17, 2021
9533036
fix format
Feb 17, 2021
a9183e2
fix prettier check
Feb 17, 2021
db1705f
additional format fix
Feb 17, 2021
fa17739
Merge remote-tracking branch 'upstream/master'
Feb 17, 2021
588bfc0
fix examples and wrong response code
Feb 17, 2021
200028b
Merge remote-tracking branch 'upstream/master'
Feb 17, 2021
cc1be5b
fix validator
Feb 17, 2021
109ed6d
fix validator
Feb 17, 2021
1d2f8f1
Merge remote-tracking branch 'upstream/master'
Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 81 additions & 11 deletions .../eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Accepted"
},
Expand Down Expand Up @@ -619,6 +622,9 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Accepted"
},
Expand Down Expand Up @@ -1382,6 +1388,9 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Accepted"
},
Expand Down Expand Up @@ -1816,6 +1825,9 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Accepted"
},
Expand Down Expand Up @@ -2811,6 +2823,9 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Accepted"
},
Expand Down Expand Up @@ -4444,6 +4459,9 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Accepted"
},
Expand Down Expand Up @@ -5176,6 +5194,9 @@
"schema": {
"$ref": "#/definitions/ExtensionTopic"
}
},
"default": {
"description": "*** Error Responses: ***\n\n * 400 Bad Request.\n\n * 500 Internal Server Error."
}
},
"x-ms-examples": {
Expand Down Expand Up @@ -5378,7 +5399,8 @@
"x-ms-enum": {
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"default": "Enabled"
},
"inboundIpRules": {
"description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
Expand Down Expand Up @@ -5501,12 +5523,12 @@
"readOnly": true
},
"name": {
"description": "Name of the resource",
"description": "Name of the resource.",
"type": "string",
"readOnly": true
},
"type": {
"description": "Type of the resource",
"description": "Type of the resource.",
"type": "string",
"readOnly": true
}
Expand Down Expand Up @@ -5725,7 +5747,8 @@
},
"sku": {
"$ref": "#/definitions/ResourceSku",
"description": "The Sku pricing tier for the domain."
"description": "The Sku pricing tier for the domain.",
"default": "Basic"
},
"identity": {
"$ref": "#/definitions/IdentityInfo",
Expand Down Expand Up @@ -5773,7 +5796,8 @@
"x-ms-enum": {
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"default": "Enabled"
},
"inboundIpRules": {
"description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
Expand Down Expand Up @@ -6251,6 +6275,12 @@
"$ref": "#/definitions/EventChannelProperties",
"description": "Properties of the EventChannel.",
"x-ms-client-flatten": true
},
"systemData": {
"description": "The system metadata relating to Event Channel resource.",
"type": "object",
"readOnly": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down Expand Up @@ -6324,6 +6354,7 @@
},
"eventDeliverySchema": {
"description": "The event delivery schema for the event subscription.",
"default": "EventGridSchema",
"enum": [
"EventGridSchema",
"CustomInputSchema",
Expand Down Expand Up @@ -6454,7 +6485,8 @@
"properties": {
"endpointUrl": {
"description": "The URL that represents the endpoint of the destination of an event subscription.",
"type": "string"
"type": "string",
"x-ms-secret": true
},
"endpointBaseUrl": {
"description": "The base URL that represents the endpoint of the destination of an event subscription.",
Expand All @@ -6464,11 +6496,13 @@
"maxEventsPerBatch": {
"format": "int32",
"description": "Maximum number of events per batch.",
"default": 1,
"type": "integer"
},
"preferredBatchSizeInKilobytes": {
"format": "int32",
"description": "Preferred batch size in Kilobytes.",
"default": 64,
"type": "integer"
},
"azureActiveDirectoryTenantId": {
Expand Down Expand Up @@ -6700,11 +6734,13 @@
"maxEventsPerBatch": {
"format": "int32",
"description": "Maximum number of events per batch.",
"default": 1,
"type": "integer"
},
"preferredBatchSizeInKilobytes": {
"format": "int32",
"description": "Preferred batch size in Kilobytes.",
"default": 64,
"type": "integer"
}
}
Expand Down Expand Up @@ -6766,6 +6802,12 @@
"$ref": "#/definitions/EventSubscriptionProperties",
"description": "Properties of the event subscription.",
"x-ms-client-flatten": true
},
"systemData": {
"description": "The system metadata relating to Event Subscription resource.",
"type": "object",
"readOnly": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down Expand Up @@ -6954,6 +6996,12 @@
"$ref": "#/definitions/PartnerNamespaceProperties",
"description": "Properties of the partner namespace.",
"x-ms-client-flatten": true
},
"systemData": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this property really exist in the API response ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does..

"description": "The system metadata relating to Partner Namespace resource.",
"type": "object",
"readOnly": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down Expand Up @@ -7110,6 +7158,12 @@
"$ref": "#/definitions/PartnerRegistrationProperties",
"description": "Properties of the partner registration.",
"x-ms-client-flatten": true
},
"systemData": {
"description": "The system metadata relating to Partner Registration resource.",
"type": "object",
"readOnly": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down Expand Up @@ -7300,6 +7354,12 @@
"$ref": "#/definitions/PartnerTopicProperties",
"description": "Properties of the partner topic.",
"x-ms-client-flatten": true
},
"systemData": {
"description": "The system metadata relating to Partner Topic resource.",
"type": "object",
"readOnly": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down Expand Up @@ -7432,11 +7492,11 @@
"type": "string"
},
"name": {
"description": "Name of the resource",
"description": "Name of the resource.",
"type": "string"
},
"type": {
"description": "Type of the resource",
"description": "Type of the resource.",
"type": "string"
}
}
Expand Down Expand Up @@ -7530,6 +7590,12 @@
"$ref": "#/definitions/SystemTopicProperties",
"description": "Properties of the system topic.",
"x-ms-client-flatten": true
},
"systemData": {
"description": "The system metadata relating to System Topic resource.",
"type": "object",
"readOnly": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down Expand Up @@ -7628,7 +7694,8 @@
"x-ms-enum": {
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"default": "Enabled"
},
"inboundIpRules": {
"description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
Expand All @@ -7655,7 +7722,8 @@
},
"sku": {
"$ref": "#/definitions/ResourceSku",
"description": "The Sku pricing tier for the topic."
"description": "The Sku pricing tier for the topic.",
"default": "Basic"
},
"identity": {
"$ref": "#/definitions/IdentityInfo",
Expand Down Expand Up @@ -7703,7 +7771,8 @@
"x-ms-enum": {
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"default": "Enabled"
},
"inboundIpRules": {
"description": "This can be used to restrict traffic from specific IPs instead of all IPs. Note: These are considered only if PublicNetworkAccess is enabled.",
Expand Down Expand Up @@ -7904,6 +7973,7 @@
"description": "The number of results to return per page for the list operation. Valid range for top parameter is 1 to 100. If not specified, the default number of results to be returned is 20 items per page.",
"required": false,
"type": "integer",
"format": "int32",
"x-ms-parameter-location": "method"
}
},
Expand Down
1 change: 1 addition & 0 deletions ...-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/DomainTopics_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"api-version": "2020-04-01-preview"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
Expand Down
1 change: 1 addition & 0 deletions ...ource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/Domains_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"api-version": "2020-04-01-preview"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
Expand Down
1 change: 1 addition & 0 deletions ...ger/Microsoft.EventGrid/preview/2020-04-01-preview/examples/PartnerNamespaces_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"api-version": "2020-04-01-preview"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
Expand Down
1 change: 1 addition & 0 deletions ....EventGrid/preview/2020-04-01-preview/examples/PartnerTopicEventSubscriptions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"api-version": "2020-04-01-preview"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
Expand Down
1 change: 1 addition & 0 deletions ...t.EventGrid/preview/2020-04-01-preview/examples/SystemTopicEventSubscriptions_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"api-version": "2020-04-01-preview"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
Expand Down
1 change: 1 addition & 0 deletions ...-manager/Microsoft.EventGrid/preview/2020-04-01-preview/examples/SystemTopics_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"api-version": "2020-04-01-preview"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
Expand Down
Loading