Feature/cplat 2021 04 01 - Capacity Reservation related changes #15058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hari-bodicherla
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @hari-bodicherla Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-04-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️❌[Staging] SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "$ref":"#/components/schemas/schemas:1501", "description":"The Offer Promotion Code." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Error: Plugin prechecker reported failure." |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Jul 1, 2021
11 tasks
specification/compute/resource-manager/Microsoft.Compute/stable/2021-04-01/compute.json
Outdated
Show resolved
Hide resolved
specification/compute/resource-manager/Microsoft.Compute/stable/2021-04-01/compute.json
Show resolved
Hide resolved
specification/compute/resource-manager/Microsoft.Compute/stable/2021-04-01/compute.json
Show resolved
Hide resolved
|
@ArcturusZhang @Sandido will you help me review this PR? |
smotwani
reviewed
Jul 2, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-04-01/compute.json
Outdated
Show resolved
Hide resolved
smotwani
reviewed
Jul 2, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-04-01/compute.json
Outdated
Show resolved
Hide resolved
11 tasks
smotwani
approved these changes
Jul 2, 2021
26 tasks
ArcturusZhang
pushed a commit
that referenced
this pull request
Jul 15, 2021
* initial copy of old files to new folder 2021-04-01 * api version update * Add SpotRestorePolicy to CRP's VM Scale Set Resource (#14692) * Resolve merge conflicts after branch recreation * Fix Lint error * update with changes mae in 2021-03-01 * Update compute.json * Update CreateAVmWithNetworkInterfaceConfiguration.json update example file also to fix breaking change naming issue. * Feature/cplat 2021 04 01 - Capacity Reservation related changes (#15058) * updated code * updated swagger with cr changes * updated swagger with cr changes * updated swagger with cr changes * updated swagger * updated swagger * updated swagger * Feature/cplat 2021 04 01 (#15070) * 2021-04 initial * 2021-04 examples and readme * adding CR VMSS changes * updating api version in example and description of CR profile Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json * syncronizing 2021-04-01 swagger with changes made in 2021-03-01 Co-authored-by: Sandeep Vishnu <sandeepkv93@gmail.com> Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com> Co-authored-by: micahjo <69926788+micahjo@users.noreply.github.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* initial copy of old files to new folder 2021-04-01 * api version update * Add SpotRestorePolicy to CRP's VM Scale Set Resource (Azure#14692) * Resolve merge conflicts after branch recreation * Fix Lint error * update with changes mae in 2021-03-01 * Update compute.json * Update CreateAVmWithNetworkInterfaceConfiguration.json update example file also to fix breaking change naming issue. * Feature/cplat 2021 04 01 - Capacity Reservation related changes (Azure#15058) * updated code * updated swagger with cr changes * updated swagger with cr changes * updated swagger with cr changes * updated swagger * updated swagger * updated swagger * Feature/cplat 2021 04 01 (Azure#15070) * 2021-04 initial * 2021-04 examples and readme * adding CR VMSS changes * updating api version in example and description of CR profile Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json * syncronizing 2021-04-01 swagger with changes made in 2021-03-01 Co-authored-by: Sandeep Vishnu <sandeepkv93@gmail.com> Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com> Co-authored-by: micahjo <69926788+micahjo@users.noreply.github.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.