Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated SDK modules and recorded tests for Capacity Reservation and Capacity reservation in VM - API version 2021-04-01 #22383

Merged
merged 8 commits into from
Jul 7, 2021

Conversation

hari-bodicherla
Copy link
Contributor

@hari-bodicherla hari-bodicherla commented Jul 1, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Compute label Jul 1, 2021
@hari-bodicherla
Copy link
Contributor Author

Pull request for related Swagger changes : Azure/azure-rest-api-specs#15058

@check-enforcer
Copy link

check-enforcer bot commented Jul 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@allenjzhang allenjzhang marked this pull request as draft July 2, 2021 23:03
@allenjzhang allenjzhang assigned grizzlytheodore and unassigned m-nash Jul 2, 2021
@grizzlytheodore grizzlytheodore marked this pull request as ready for review July 6, 2021 23:15
@grizzlytheodore
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@grizzlytheodore grizzlytheodore merged commit e70666d into Azure:feature/cplat-2021-04-01 Jul 7, 2021
allenjzhang pushed a commit that referenced this pull request Jul 20, 2021
* code generation

* avail

* updates

* RECORDINGS

* new recordings

* new recording

* new recording

* recordings

* updated test because it seems like the market place offer/sku does not exist anymore then re-recorded test

* Add new Property SpotRestorePolicy to VMScaleSets (#21928)

* Generated Files

* Tests for Spot Restore Policy

* Versioning changes

* Scenario Test record

* customization (#22054)

* update

* add capacity Reservation update

* customizations

* fix duplicates, Capaciy Reservation for vmss

* Generated SDK modules and recorded tests for Capacity Reservation and Capacity reservation in VM - API version 2021-04-01 (#22383)

* updated sdk tests

* updated sdk

* updated sdk

* udpated cpe

* regenerated the sdk and re recorded the tests

* updated sdk

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Capacity Res. for Vmss (#22429)

* starting changes for vmss sdk test for CR

* updating vmss test base with cr items

* adding vmss changes to vmss scenario test correctly

* adding vmss passing test

* adding tests and version updates

* moving cr location in param

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* assembly version update

* remove duplicate definition in tests/helpers.cs

* update with CapacityReservations_Update 202 status return

* sdk gen from latest swagger change

* new recording for new test just added

* RestorePoint test recording

* code gen again to check diff

* Update compute_resource-manager.txt

update commit info to use latest compute swagger

* added morescription to package release note. updated compute_resource-manager.txt right commit.  re-generated sdk with CapacityReservationGroupInstanceViewTypes, CapacityReservationInstanceViewTypes, and ExpandTypesForGetCapacityReservationGroups changed to modelAsString true

* Update AzSdk.RP.props

Co-authored-by: Sandeep Vishnu <sandeepkv93@gmail.com>
Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com>
Co-authored-by: micahjo <69926788+micahjo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants