Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-04-16 #15072

Merged
merged 4 commits into from
Jul 5, 2021
Merged

[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-04-16 #15072

merged 4 commits into from
Jul 5, 2021

Conversation

avjerafi
Copy link
Contributor

@avjerafi avjerafi commented Jul 3, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @avjerafi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 3, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 10 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules/{ruleName}' removed or restructured?
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L37:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/microsoft.insights/scheduledQueryRules' removed or restructured?
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L229:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules' removed or restructured?
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L272:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L37:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L229:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L272:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L320:5
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L320:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L346:9
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L345:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L381:9
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L379:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L346:9
    Old: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L345:9
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List rules
    Location: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L310


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/autoscalesettings'
    Location: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L39
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/autoscalesettings/{autoscaleSettingName}'
    Location: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L81
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/autoscalesettings'
    Location: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L264
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/providers/microsoft.insights/operations'
    Location: Microsoft.Insights/stable/2015-04-01/operations_API.json#L39
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents/{incidentName}'
    Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L39
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents'
    Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L88
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/logprofiles/{logProfileName}'
    Location: Microsoft.Insights/stable/2016-03-01/logProfiles_API.json#L39
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/logprofiles'
    Location: Microsoft.Insights/stable/2016-03-01/logProfiles_API.json#L189
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/diagnosticSettings/{name}'
    Location: Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json#L39
    ❌ R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/diagnosticSettings'
    Location: Microsoft.Insights/preview/2017-05-01-preview/diagnosticsSettings_API.json#L161
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-2021-04
    ️❌ModelValidation: 26 Errors, 0 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    JsonUrl: stable/2018-04-16/examples/createOrUpdateScheduledQueryRules.json#L47
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    JsonUrl: stable/2018-04-16/examples/createOrUpdateScheduledQueryRules.json#L47
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    JsonUrl: stable/2018-04-16/examples/createOrUpdateScheduledQueryRules.json#L91
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    JsonUrl: stable/2018-04-16/examples/createOrUpdateScheduledQueryRules.json#L91
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    JsonUrl: stable/2018-04-16/examples/createOrUpdateScheduledQueryRuleswithCrossResource.json#L46
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Url: Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json#L370
    JsonUrl: stable/2018-04-16/examples/createOrUpdateScheduledQueryRuleswithCrossResource.json#L46
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-04",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-04",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ AutorestCore/Exception "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2021-04",
    "details":"Error: Invalid reference token: ResourceGroupNameParameter"
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:629",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true,
    properties.etag: undefined => "$ref":"#/components/schemas/schemas:630",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ AutorestCore/Exception "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2020-03",
    "details":"Error: Plugin prechecker reported failure."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:650",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true,
    properties.etag: undefined => "$ref":"#/components/schemas/schemas:651",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ AutorestCore/Exception "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-11",
    "details":"Error: Plugin prechecker reported failure."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:629",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true,
    properties.etag: undefined => "$ref":"#/components/schemas/schemas:630",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ AutorestCore/Exception "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-06",
    "details":"Error: Plugin prechecker reported failure."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-03",
    "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:626",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true,
    properties.etag: undefined => "$ref":"#/components/schemas/schemas:627",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ AutorestCore/Exception "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2019-03",
    "details":"Error: Plugin prechecker reported failure."
    ❌ PreCheck/DuplicateSchema "readme":"monitor/resource-manager/readme.md",
    "tag":"package-2018-11-preview",
    "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:634",
    "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported,
    the resource provider must validate and persist this value.",
    "readOnly":true,
    properties.etag: undefined => "$ref":"#/components/schemas/schemas:635",
    "description":"The etag field is not required. If it is provided in the response body,
    it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19),
    If-Match (section 14.24),
    If-None-Match (section 14.26),
    and If-Range (section 14.27) header fields. ",
    "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 3, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-monitor - 2.0.0
    ️✔️azure-sdk-for-go - monitor/mgmt/2020-10-01/insights - v55.5.0
    ️✔️azure-sdk-for-go - preview/monitor/mgmt/2021-04-01-preview/insights - v55.5.0
    ❌azure-sdk-for-go - preview/monitor/mgmt/2019-11-01-preview/insights - v55.5.0
    ❌azure-sdk-for-go - preview/monitor/mgmt/2019-06-01/insights - v55.5.0
    ❌azure-sdk-for-go - preview/monitor/mgmt/2019-03-01/insights - v55.5.0
    ❌azure-sdk-for-go - preview/monitor/mgmt/2018-11-01-preview/insights - v55.5.0
    ❌azure-sdk-for-go - preview/monitor/mgmt/2018-09-01/insights - v55.5.0
    ❌azure-sdk-for-go - preview/monitor/mgmt/2018-03-01/insights - v55.5.0
    ️✔️azure-sdk-for-go - preview/monitor/mgmt/2017-05-01-preview/insights - v55.5.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 9ed9f07. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/monitor/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Monitor        [View full logs]         [Release SDK Changes]      
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 9ed9f07. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-monitor        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DataCollectionRuleResourceProperties has a new parameter immutable_id
info	[Changelog]   - Model DiagnosticSettingsCategoryResource has a new parameter system_data
info	[Changelog]   - Model DiagnosticSettingsCategoryResource has a new parameter category_groups
info	[Changelog]   - Model MetricTrigger has a new parameter metric_resource_location
info	[Changelog]   - Model MetricTrigger has a new parameter divide_per_instance
info	[Changelog]   - Model MetricAlertResourcePatch has a new parameter is_migrated
info	[Changelog]   - Model Baseline has a new parameter timestamps
info	[Changelog]   - Model Baseline has a new parameter prediction_result_type
info	[Changelog]   - Model Baseline has a new parameter error_type
info	[Changelog]   - Model DataCollectionRuleResource has a new parameter system_data
info	[Changelog]   - Model DataCollectionRuleResource has a new parameter immutable_id
info	[Changelog]   - Model DataCollectionRuleResource has a new parameter kind
info	[Changelog]   - Model AlertRuleResourcePatch has a new parameter provisioning_state
info	[Changelog]   - Model AlertRuleResourcePatch has a new parameter action
info	[Changelog]   - Model AutoscaleSettingResourcePatch has a new parameter target_resource_location
info	[Changelog]   - Model RuleMetricDataSource has a new parameter resource_location
info	[Changelog]   - Model RuleMetricDataSource has a new parameter legacy_resource_id
info	[Changelog]   - Model RuleMetricDataSource has a new parameter metric_namespace
info	[Changelog]   - Model CalculateBaselineResponse has a new parameter statistics
info	[Changelog]   - Model CalculateBaselineResponse has a new parameter error_type
info	[Changelog]   - Model CalculateBaselineResponse has a new parameter internal_operation_id
info	[Changelog]   - Model SubscriptionDiagnosticSettingsResource has a new parameter system_data
info	[Changelog]   - Model SubscriptionDiagnosticSettingsResource has a new parameter marketplace_partner_id
info	[Changelog]   - Model SubscriptionLogSettings has a new parameter category_group
info	[Changelog]   - Model LogSettings has a new parameter category_group
info	[Changelog]   - Model BaselineResponse has a new parameter prediction_result_type
info	[Changelog]   - Model BaselineResponse has a new parameter error_type
info	[Changelog]   - Model BaselineResponse has a new parameter metdata
info	[Changelog]   - Model BaselineResponse has a new parameter internal_operation_id
info	[Changelog]   - Model TimeSeriesBaseline has a new parameter metadata_values
info	[Changelog]   - Model DataCollectionRule has a new parameter immutable_id
info	[Changelog]   - Model ActionGroupResource has a new parameter identity
info	[Changelog]   - Model ActionGroupResource has a new parameter kind
info	[Changelog]   - Model DataCollectionRuleAssociation has a new parameter data_collection_endpoint_id
info	[Changelog]   - Model Metric has a new parameter error_message
info	[Changelog]   - Model Metric has a new parameter error_code
info	[Changelog]   - Model Metric has a new parameter display_description
info	[Changelog]   - Model LogSearchRuleResource has a new parameter etag
info	[Changelog]   - Model LogSearchRuleResource has a new parameter is_legacy_log_analytics_rule
info	[Changelog]   - Model LogSearchRuleResource has a new parameter display_name
info	[Changelog]   - Model LogSearchRuleResource has a new parameter created_with_api_version
info	[Changelog]   - Model LogSearchRuleResource has a new parameter auto_mitigate
info	[Changelog]   - Model LogSearchRuleResource has a new parameter kind
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter is_legacy_log_analytics_rule
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter override_query_time_range
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter display_name
info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter created_with_api_version
info	[Changelog]   - Model DiagnosticSettingsResource has a new parameter system_data
info	[Changelog]   - Model DiagnosticSettingsResource has a new parameter marketplace_partner_id
info	[Changelog]   - Model RuleManagementEventDataSource has a new parameter resource_location
info	[Changelog]   - Model RuleManagementEventDataSource has a new parameter legacy_resource_id
info	[Changelog]   - Model RuleManagementEventDataSource has a new parameter metric_namespace
info	[Changelog]   - Model DataCollectionRuleAssociationProxyOnlyResourceProperties has a new parameter data_collection_endpoint_id
info	[Changelog]   - Model ManagementGroupLogSettings has a new parameter category_group
info	[Changelog]   - Model RuleDataSource has a new parameter resource_location
info	[Changelog]   - Model RuleDataSource has a new parameter legacy_resource_id
info	[Changelog]   - Model RuleDataSource has a new parameter metric_namespace
info	[Changelog]   - Model MetricNamespace has a new parameter classification
info	[Changelog]   - Model ManagementGroupDiagnosticSettingsResource has a new parameter system_data
info	[Changelog]   - Model ManagementGroupDiagnosticSettingsResource has a new parameter marketplace_partner_id
info	[Changelog]   - Model DataCollectionRuleAssociationProxyOnlyResource has a new parameter data_collection_endpoint_id
info	[Changelog]   - Model DataCollectionRuleAssociationProxyOnlyResource has a new parameter system_data
info	[Changelog]   - Model MetricAlertResource has a new parameter is_migrated
info	[Changelog]   - Model MetricDefinition has a new parameter metric_class
info	[Changelog]   - Model MetricDefinition has a new parameter category
info	[Changelog]   - Model MetricDefinition has a new parameter display_description
info	[Changelog]   - Model ExtensionDataSource has a new parameter input_data_sources
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter is_legacy_log_analytics_rule
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter etag
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter override_query_time_range
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter created_with_api_version
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter display_name
info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter kind
info	[Changelog]   - Model AutoscaleSettingResource has a new parameter target_resource_location
info	[Changelog]   - Model AlertRuleResource has a new parameter provisioning_state
info	[Changelog]   - Model AlertRuleResource has a new parameter action
info	[Changelog]   - Added operation group DataCollectionEndpointsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter scopes of model MetricAlertResource is now required
info	[Changelog]   - Operation ActivityLogAlertsOperations.update has a new signature
info	[Changelog]   - Operation ActivityLogAlertsOperations.create_or_update has a new signature
info	[Changelog]   - Model SubscriptionDiagnosticSettingsResource no longer has parameter location
info	[Changelog]   - Model BaselineResponse no longer has parameter metadata
info	[Changelog]   - Model TimeSeriesBaseline no longer has parameter metadata
info	[Changelog]   - Model ManagementGroupDiagnosticSettingsResource no longer has parameter location
info	[Changelog]   - Model PerfCounterDataSource has a new signature
info	[Changelog]   - Model WindowsEventLogDataSource has a new signature
info	[Changelog]   - Model LogAnalyticsDestination has a new signature
info	[Changelog]   - Model ErrorResponse has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 9ed9f07. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-07-05 01:50:43 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-monitor-generated"
cmderr	[generate.py] 2021-07-05 01:50:43 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-07-05 01:50:43 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.30 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/monitor/azure-resourcemanager-monitor-generated --java.namespace=com.azure.resourcemanager.monitor.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/monitor/resource-manager/readme.md
cmderr	[generate.py] 2021-07-05 01:51:45 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-07-05 01:51:45 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-07-05 01:51:45 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-07-05 01:51:45 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-07-05 01:51:45 INFO [POM][Skip] pom already has module sdk/monitor
cmderr	[generate.py] 2021-07-05 01:51:45 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-07-05 01:52:15 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-monitor-generated        [View full logs]         [Release SDK Changes]      
      cmderr	[Inst] 2021-07-05 01:52:19 DEBUG Got artifact_id: azure-resourcemanager-monitor-generated
cmderr	[Inst] 2021-07-05 01:52:19 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-07-05 01:52:19 ERROR Unmatch any jar in artifacts
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 9ed9f07. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️monitor/mgmt/2020-10-01/insights        [View full logs]         [Release SDK Changes]      
      info	[Changelog] No exported changes
    • ️✔️preview/monitor/mgmt/2021-04-01-preview/insights        [View full logs]       
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `MetricStatisticTypeCount`
info	[Changelog] - New const `ScaleTypeServiceAllowedNextValue`
info	[Changelog] - New field `TargetResourceLocation` in struct `AutoscaleSetting`
info	[Changelog] - New field `MetricResourceLocation` in struct `MetricTrigger`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2019-11-01-preview/insights        [View full logs]         Breaking Change Detected
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `Identity` in struct `ActionGroupResource`
info	[Changelog] - New field `Kind` in struct `AlertRuleResource`
info	[Changelog] - New field `Etag` in struct `AlertRuleResource`
info	[Changelog] - New field `Classification` in struct `MetricNamespace`
info	[Changelog] - New field `TargetResourceLocation` in struct `AutoscaleSetting`
info	[Changelog] - New field `Kind` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `Etag` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `IsMigrated` in struct `MetricAlertPropertiesPatch`
info	[Changelog] - New field `DisplayDescription` in struct `Metric`
info	[Changelog] - New field `ErrorCode` in struct `Metric`
info	[Changelog] - New field `ErrorMessage` in struct `Metric`
info	[Changelog]
info	[Changelog] Total 50 breaking change(s), 60 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2019-06-01/insights        [View full logs]         Breaking Change Detected
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `IsMigrated` in struct `MetricAlertProperties`
info	[Changelog] - New field `Kind` in struct `ActionGroupResource`
info	[Changelog] - New field `Identity` in struct `ActionGroupResource`
info	[Changelog] - New field `DividePerInstance` in struct `MetricTrigger`
info	[Changelog] - New field `MetricResourceLocation` in struct `MetricTrigger`
info	[Changelog] - New field `Kind` in struct `Resource`
info	[Changelog] - New field `Etag` in struct `Resource`
info	[Changelog] - New field `Kind` in struct `MetricAlertResource`
info	[Changelog] - New field `Etag` in struct `MetricAlertResource`
info	[Changelog] - New field `TargetResourceLocation` in struct `AutoscaleSetting`
info	[Changelog] - New field `MetadataValues` in struct `TimeSeriesBaseline`
info	[Changelog]
info	[Changelog] Total 51 breaking change(s), 64 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2019-03-01/insights        [View full logs]         Breaking Change Detected
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `Classification` in struct `MetricNamespace`
info	[Changelog] - New field `Kind` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `Etag` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `MetricClass` in struct `MetricDefinition`
info	[Changelog] - New field `DisplayDescription` in struct `MetricDefinition`
info	[Changelog] - New field `Category` in struct `MetricDefinition`
info	[Changelog] - New field `Kind` in struct `LogSearchRuleResource`
info	[Changelog] - New field `Etag` in struct `LogSearchRuleResource`
info	[Changelog] - New field `MetricNamespace` in struct `RuleMetricDataSource`
info	[Changelog] - New field `LegacyResourceID` in struct `RuleMetricDataSource`
info	[Changelog] - New field `ResourceLocation` in struct `RuleMetricDataSource`
info	[Changelog]
info	[Changelog] Total 51 breaking change(s), 64 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2018-11-01-preview/insights        [View full logs]         Breaking Change Detected
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `Etag` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `ResourceLocation` in struct `RuleMetricDataSource`
info	[Changelog] - New field `MetricNamespace` in struct `RuleMetricDataSource`
info	[Changelog] - New field `LegacyResourceID` in struct `RuleMetricDataSource`
info	[Changelog] - New field `DisplayDescription` in struct `Metric`
info	[Changelog] - New field `ErrorCode` in struct `Metric`
info	[Changelog] - New field `ErrorMessage` in struct `Metric`
info	[Changelog] - New field `Kind` in struct `MetricAlertResource`
info	[Changelog] - New field `Etag` in struct `MetricAlertResource`
info	[Changelog] - New field `IsMigrated` in struct `MetricAlertProperties`
info	[Changelog] - New anonymous field `*MetricAlertPropertiesPatch` in struct `MetricAlertResourcePatch`
info	[Changelog]
info	[Changelog] Total 20 breaking change(s), 61 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2018-09-01/insights        [View full logs]         Breaking Change Detected
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `Kind` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `Etag` in struct `ActivityLogAlertResource`
info	[Changelog] - New field `Action` in struct `AlertRule`
info	[Changelog] - New field `ProvisioningState` in struct `AlertRule`
info	[Changelog] - New field `ErrorMessage` in struct `Metric`
info	[Changelog] - New field `DisplayDescription` in struct `Metric`
info	[Changelog] - New field `ErrorCode` in struct `Metric`
info	[Changelog] - New field `ResourceLocation` in struct `RuleManagementEventDataSource`
info	[Changelog] - New field `LegacyResourceID` in struct `RuleManagementEventDataSource`
info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
info	[Changelog] - New field `Timestamps` in struct `Baseline`
info	[Changelog]
info	[Changelog] Total 37 breaking change(s), 80 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2018-03-01/insights        [View full logs]         Breaking Change Detected
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceLocation` in struct `RuleMetricDataSource`
info	[Changelog] - New field `MetricNamespace` in struct `RuleMetricDataSource`
info	[Changelog] - New field `Kind` in struct `ActionGroupResource`
info	[Changelog] - New field `Etag` in struct `ActionGroupResource`
info	[Changelog] - New field `TargetResourceLocation` in struct `AutoscaleSetting`
info	[Changelog] - New field `Kind` in struct `LogSearchRuleResource`
info	[Changelog] - New field `Etag` in struct `LogSearchRuleResource`
info	[Changelog] - New field `Kind` in struct `MetricAlertResource`
info	[Changelog] - New field `Etag` in struct `MetricAlertResource`
info	[Changelog] - New field `MetricResourceLocation` in struct `MetricTrigger`
info	[Changelog] - New field `DividePerInstance` in struct `MetricTrigger`
info	[Changelog]
info	[Changelog] Total 20 breaking change(s), 56 additive change(s).
info	[Changelog]
    • ️✔️preview/monitor/mgmt/2017-05-01-preview/insights        [View full logs]       
            Only show 14 items here, please refer to log for details.
      info	[Changelog] - New field `ErrorCode` in struct `Metric`
info	[Changelog] - New field `ErrorMessage` in struct `Metric`
info	[Changelog] - New field `MetricNamespace` in struct `RuleDataSource`
info	[Changelog] - New field `LegacyResourceID` in struct `RuleDataSource`
info	[Changelog] - New field `ResourceLocation` in struct `RuleDataSource`
info	[Changelog] - New field `MetricNamespace` in struct `RuleManagementEventDataSource`
info	[Changelog] - New field `LegacyResourceID` in struct `RuleManagementEventDataSource`
info	[Changelog] - New field `ResourceLocation` in struct `RuleManagementEventDataSource`
info	[Changelog] - New field `LegacyResourceID` in struct `RuleMetricDataSource`
info	[Changelog] - New field `ResourceLocation` in struct `RuleMetricDataSource`
info	[Changelog] - New field `MetricNamespace` in struct `RuleMetricDataSource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 15 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 9ed9f07. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/monitor/resource-manager/readme.md
    • ️✔️@azure/arm-monitor        [View full logs]         [Release SDK Changes]      
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/monitorManagementClient.js → ./dist/arm-monitor.js...
cmderr	[npmPack] created ./dist/arm-monitor.js in 883ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 9ed9f07. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh]
cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
cmderr	[initScript.sh]
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️monitor        [View full logs]         [Release Schema Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


    





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @avjerafi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. 
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
     If you want to know the production traffic statistic, please see ARM Traffic statistic. 
     If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    NewApiVersionRequired reason:
     
    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.  

     EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 3, 2021

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Jul 3, 2021
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    





    

      
    
  
      

    

  
    
  @avjerafi


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
    Contributor


      

  Author


  
    

  
    
    
    
      

      
            avjerafi
  

      

      

      commented


        Jul 3, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    @weidongxu-microsoft
    

    The sole purpose of this submission was to add suppression for a reported linting error in S360 (commit d911a18).
    

    The rest of the changes that were committed were only in order to resolve the validation errors I've received by running the validation tools locally before submitting the PR.
    

    I was instructed to camel case the provider name so it was modified from microsoft.insights to Microsoft.Insights, which then triggered the RemovedPath and AddedPath errors. Can these be ignored?
    

    Additionally, unrelated to my changes, old examples now trigger an OBJECT_ADDITIONAL_PROPERTIES. The nature of these errors is not clear to me as it is: location and tags are reported as additional properties in LogSearchRuleResource, but I can see that they are defined in the parent Resource. So how come they are considered additional properties? Am I missing something?
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
        



    

      
    
  
      

    

  
    
  @weidongxu-microsoft


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    
    
      

      
            weidongxu-microsoft
  

      

      

      commented


        Jul 5, 2021


      
  •

  
    
    
      
    
        
          edited
          
        
        
      
    
        
    
      
        
      Loading

      
    
  
    
    

    
    

  
    

    


      
    

        

    
  
    
    
      
          
    OBJECT_ADDITIONAL_PROPERTIES is caused by confusion of the Resource defined in your json and the other Resource defined in types.json which does not have location and tags (even if you may not use that definition).
    

    I will flag it as false alert, though I won't be able to know whether S360 will alert it or not.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @weidongxu-microsoft
weidongxu-microsoft




            added
      

  Approved-LintDiff


      

  Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374

  labels


      Jul 5, 2021

    
    
  
    





    

      
    
  
      

    

  
    
  @weidongxu-microsoft


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Change on "microsoft.insights to Microsoft.Insights" should not be breaking changes.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            


  
    
  
    
    
  
    
  
    


        @weidongxu-microsoft
  weidongxu-microsoft



        merged commit 9ed9f07
      into

      
  
    Azure:master
  


    Jul 5, 2021

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Jul 5, 2021
    

    


    
  


  
    
      
   Merged

  
    

    




  
    

    




    



        
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 5, 2021

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  

    
  
    
  
  
    
    
  mkarmark 

      pushed a commit
        to mkarmark/azure-rest-api-specs
      that referenced
      this pull request

    
      Jul 21, 2021
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @avjerafi
      
        @mkarmark
  
    

    


      
    
        
          [Hub Generated] Review request for Microsoft.Insights to add version …
        

          
            
          

      
    

      
    
          

    
    
    

  

      
    

      
    
      
    

      
      
    
        
          141cd64
        
      
    
    
    
  
    
    
    
      
    …stable/2018-04-16 (Azure#15072)

* Added suppression for R4005 linting error

* Using Pascal case for resource provider

* Added all missing type:object

* Added supperssion for R3016 - camel case for odata.type

Co-authored-by: Avi Jerafi <avjerafi@microsoft.com>
    
    
    

    

    
    
  
    

    

  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @weidongxu-microsoft
  
    weidongxu-microsoft



          
            
              
            
          
          weidongxu-microsoft approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @weidongxu-microsoft
  
    weidongxu-microsoft
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
  

    Approved-LintDiff

  

    Approved-ModelValidation

  

    CI-BreakingChange-Go

  

    FixS360



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

          

    

  
      
    
  
    
    
    
      2 participants
    
    
    
    
        
          @avjerafi 
        
          @weidongxu-microsoft