Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-04-16 #15072

Merged
merged 4 commits into from
Jul 5, 2021
Merged

[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-04-16 #15072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d911a18
Added suppression for R4005 linting error
Jul 3, 2021
270b4f2
Using Pascal case for resource provider
Jul 3, 2021
eb5e28c
Added all missing type:object
Jul 3, 2021
1b3db52
Added supperssion for R3016 - camel case for odata.type
Jul 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...monitor/resource-manager/Microsoft.Insights/stable/2018-04-16/scheduledQueryRule_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}
},
"paths": {
"/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules/{ruleName}": {
"/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Insights/scheduledQueryRules/{ruleName}": {
"put": {
"description": "Creates or updates an log search rule.",
"tags": [
Expand Down Expand Up @@ -226,7 +226,7 @@
}
}
},
"/subscriptions/{subscriptionId}/providers/microsoft.insights/scheduledQueryRules": {
"/subscriptions/{subscriptionId}/providers/Microsoft.Insights/scheduledQueryRules": {
"get": {
"tags": [
"scheduledQueryRules"
Expand Down Expand Up @@ -269,7 +269,7 @@
"x-ms-odata": "#/definitions/LogSearchRuleResource"
}
},
"/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/scheduledQueryRules": {
"/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Insights/scheduledQueryRules": {
"get": {
"tags": [
"scheduledQueryRules"
Expand Down Expand Up @@ -318,6 +318,7 @@
},
"definitions": {
"Resource": {
"type": "object",
"properties": {
"id": {
"type": "string",
Expand All @@ -343,6 +344,7 @@
]
},
"tags": {
"type": "object",
"additionalProperties": {
"type": "string"
},
Expand Down Expand Up @@ -385,8 +387,10 @@
"description": "The Log Search Rule resource."
},
"LogSearchRuleResourcePatch": {
"type": "object",
"properties": {
"tags": {
"type": "object",
"additionalProperties": {
"type": "string"
},
Expand All @@ -401,6 +405,7 @@
"description": "The log search rule resource for patch operations."
},
"LogSearchRuleResourceCollection": {
"type": "object",
"properties": {
"value": {
"type": "array",
Expand Down Expand Up @@ -583,6 +588,7 @@
"description": "Set value to 'ResultAccount'"
},
"LogSearchRule": {
"type": "object",
"description": "Log Search Rule Definition",
"properties": {
"createdWithApiVersion": {
Expand Down Expand Up @@ -660,6 +666,7 @@
]
},
"LogSearchRulePatch": {
"type": "object",
"description": "Log Search Rule Definition for Patching",
"properties": {
"enabled": {
Expand Down
7 changes: 7 additions & 0 deletions specification/monitor/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,13 @@ directive:
where: $.paths
from: scheduledQueryRule_API.json
reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
- suppress: R4005
where: $.definitions.Dimension.properties.operator
from: scheduledQueryRule_API.json
reason: 'The discrepancy in the enum values is with an enum which is defined for a different service of a different team'
- suppress: R3016
where: $.definitions.Action.properties["odata.type"]
reason: 'This is an old field in a stable api version which is not camel cased'
- suppress: EnumInsteadOfBoolean
where: $.definitions.AlertRuleProperties.properties.enabled
from: activityLogAlerts_API.json
Expand Down