[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

susolank · 2021-09-14T21:57:36Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-09-14T21:57:38Z

Hi, @susolank Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-09-14T21:57:38Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2021-06-01-preview/keys.json compared with base:preview/2021-06-01-preview/keys.json

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'release_policy' in response that was not found in the old version. New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7 Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'release_policy' that was not found in the old version. New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7 Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'exportable' that was not found in the old version. New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L436:7 Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L432:7

️⚠️LintDiff: 2 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- keyvault/resource-manager/readme.md tag:package-preview-2021-06
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- keyvault/resource-manager/readme.md tag:package-preview-2021-06

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: exportable Location: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L481
⚠️ R4021 - DescriptionAndTitleMissing	'KeyReleasePolicy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L626

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.KeyVault/preview/2021-06-01-preview/secrets.json#L306
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.KeyVault/preview/2021-06-01-preview/secrets.json#L312
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.KeyVault/preview/2021-06-01-preview/secrets.json#L318
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.KeyVault/preview/2021-06-01-preview/secrets.json#L324
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/common.json#L10
`❌` R4037 - MissingTypeObject	The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/common.json#L19
`❌` R4037 - MissingTypeObject	The schema 'SystemData' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/common.json#L33
`❌` R4037 - MissingTypeObject	The schema 'PrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1959
`❌` R4037 - MissingTypeObject	The schema 'PrivateLinkResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1944
`❌` R4037 - MissingTypeObject	The schema 'PrivateLinkServiceConnectionState' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1877
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1867
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpointConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1850
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpointConnection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1814
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1639
`❌` R4037 - MissingTypeObject	The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/common.json#L19
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/common.json#L10
`❌` R4037 - MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1035
`❌` R4037 - MissingTypeObject	The schema 'AccessPolicyEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1068
`❌` R4037 - MissingTypeObject	The schema 'Permissions' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1096
`❌` R4037 - MissingTypeObject	The schema 'VaultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1213
`❌` R4037 - MissingTypeObject	The schema 'VaultPatchProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1324
`❌` R4037 - MissingTypeObject	The schema 'VaultAccessPolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1394
`❌` R4037 - MissingTypeObject	The schema 'DeletedVaultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1409
`❌` R4037 - MissingTypeObject	The schema 'VaultCreateOrUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1449
`❌` R4037 - MissingTypeObject	The schema 'VaultPatchParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1474
`❌` R4037 - MissingTypeObject	The schema 'VaultAccessPolicyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1491
`❌` R4037 - MissingTypeObject	The schema 'Vault' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1524
`❌` R4037 - MissingTypeObject	The schema 'DeletedVault' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1567
`❌` R4037 - MissingTypeObject	The schema 'VaultListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1591
`❌` R4037 - MissingTypeObject	The schema 'DeletedVaultListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.KeyVault/preview/2021-06-01-preview/keyvault.json#L1607

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-09-14T21:57:38Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-09-14T21:57:39Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-keyvault - 9.1.0
❌azure-sdk-for-go - keyvault/mgmt/2019-09-01/keyvault - v57.2.0

️✔️azure-sdk-for-go - keyvault/mgmt/2018-02-14/keyvault - v57.2.0
️✔️azure-sdk-for-go - keyvault/mgmt/2016-10-01/keyvault - v57.2.0
️✔️azure-sdk-for-go - keyvault/mgmt/2015-06-01/keyvault - v57.2.0
❌azure-sdk-for-go - preview/keyvault/mgmt/2020-04-01-preview/keyvault - v57.2.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from c566c79. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/keyvault/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.KeyVault [View full logs] [Release SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(927,36): error CS0029: Cannot implicitly convert type 'Microsoft.Rest.Azure.CloudError' to 'Microsoft.Azure.Management.KeyVault.Models.VaultAccessPolicyParameters' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Generated/VaultsOperations.cs(2530,29): error CS1061: 'AzureOperationResponse' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'AzureOperationResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/keyvault/Microsoft.Azure.Management.KeyVault/src/Microsoft.Azure.Management.KeyVault.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from c566c79. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-keyvault [View full logs] [Release SDK Changes]
- azure-mgmt-keyvault-9.1.0.zip
- azure_mgmt_keyvault-9.1.0-py2.py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from c566c79. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-09-18 02:26:36 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-keyvault-generated"
cmderr	[generate.py] 2021-09-18 02:26:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-09-18 02:26:36 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/keyvault/azure-resourcemanager-keyvault-generated --java.namespace=com.azure.resourcemanager.keyvault.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/keyvault/resource-manager/readme.md
cmderr	[generate.py] 2021-09-18 02:27:09 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-09-18 02:27:09 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-09-18 02:27:09 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-09-18 02:27:09 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-09-18 02:27:09 INFO [POM][Skip] pom already has module sdk/keyvault
cmderr	[generate.py] 2021-09-18 02:27:09 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-09-18 02:29:04 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-keyvault-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-09-18 02:29:07 DEBUG Got artifact_id: azure-resourcemanager-keyvault-generated
cmderr	[Inst] 2021-09-18 02:29:07 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-09-18 02:29:07 DEBUG Got artifact: azure-resourcemanager-keyvault-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-09-18 02:29:07 DEBUG Got artifact: azure-resourcemanager-keyvault-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-09-18 02:29:07 DEBUG Match jar package: azure-resourcemanager-keyvault-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-09-18 02:29:07 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16042/azure-sdk-for-java/azure-resourcemanager-keyvault-generated/azure-resourcemanager-keyvault-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-keyvault-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-keyvault-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-keyvault-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c566c79. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️keyvault/mgmt/2019-09-01/keyvault [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `VaultProvisioningStateRegisteringDNS`
info	[Changelog] - New const `VaultProvisioningStateSucceeded`
info	[Changelog] - New function `PossibleVaultProvisioningStateValues() []VaultProvisioningState`
info	[Changelog] - New struct `DimensionProperties`
info	[Changelog] - New struct `MetricSpecification`
info	[Changelog] - New field `ID` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `PurgeProtectionEnabled` in struct `DeletedVaultProperties`
info	[Changelog] - New field `IgnoreMissingVnetServiceEndpoint` in struct `VirtualNetworkRule`
info	[Changelog] - New field `MetricSpecifications` in struct `ServiceSpecification`
info	[Changelog] - New field `ActionsRequired` in struct `PrivateLinkServiceConnectionState`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `ProvisioningState` in struct `VaultProperties`
info	[Changelog] - New field `HsmPoolResourceID` in struct `VaultProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 15 additive change(s).
info	[Changelog]

️✔️keyvault/mgmt/2018-02-14/keyvault [View full logs]
```
info	[Changelog] No exported changes
```
️✔️keyvault/mgmt/2016-10-01/keyvault [View full logs]
```
info	[Changelog] No exported changes
```
️✔️keyvault/mgmt/2015-06-01/keyvault [View full logs]
```
info	[Changelog] No exported changes
```

️✔️preview/keyvault/mgmt/2020-04-01-preview/keyvault [View full logs] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `VaultProvisioningStateSucceeded`
info	[Changelog] - New const `VaultProvisioningStateRegisteringDNS`
info	[Changelog] - New function `PossibleVaultProvisioningStateValues() []VaultProvisioningState`
info	[Changelog] - New struct `DimensionProperties`
info	[Changelog] - New struct `MetricSpecification`
info	[Changelog] - New field `MetricSpecifications` in struct `ServiceSpecification`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `PurgeProtectionEnabled` in struct `DeletedVaultProperties`
info	[Changelog] - New field `IgnoreMissingVnetServiceEndpoint` in struct `VirtualNetworkRule`
info	[Changelog] - New field `ID` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `ActionsRequired` in struct `PrivateLinkServiceConnectionState`
info	[Changelog] - New field `HsmPoolResourceID` in struct `VaultProperties`
info	[Changelog] - New field `ProvisioningState` in struct `VaultProperties`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 15 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c566c79. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/keyvault/resource-manager/readme.md

️✔️@azure/arm-keyvault [View full logs] [Release SDK Changes]

azure-arm-keyvault-1.3.2.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/keyVaultManagementClient.js → ./dist/arm-keyvault.js...
cmderr	[npmPack] created ./dist/arm-keyvault.js in 506ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from c566c79. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2953) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2953) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2953) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

️✔️keyvault [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-09-14T21:59:24Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-09-14T21:59:52Z

Hi @susolank, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

heaths

One change to consider, but I won't block the PR based solely on that.

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/keys.json

openapi-workflow-bot · 2021-09-16T02:14:20Z

Hi @susolank, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

susolank · 2021-09-16T17:33:13Z

@ruowan I feel this breaking change review process is not applicable to this PR because new properties are being added the KeyCreateParameters object. No existing properties are being modified or removed. No existing customers will be impacted by this change. This change is allow customers to create Secure Key Release (SKR) keys using ARM template.

susolank · 2021-09-16T17:44:49Z

Rule	Message
❌ 1041 - AddedPropertyInResponse	The new version has a new property 'release_policy' in response that was not found in the old version.New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7
❌ 1045 - AddedOptionalProperty	The new version has a new optional property 'release_policy' that was not found in the old version.New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L354:7
❌ 1045 - AddedOptionalProperty	The new version has a new optional property 'exportable' that was not found in the old version.New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L436:7Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L432:7
💬 1001 - NoVersionChange	The versions have not changed.New: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L1:1Old: Microsoft.KeyVault/preview/2021-06-01-preview/keys.json#L1:1

heaths · 2021-09-16T23:57:29Z

@lmazuel can you help merge this? As with other KV REST PRs, the remaining issues are, unfortunately, expected.

ruowan · 2021-09-17T02:54:31Z

There are no cusomer impact. Here is the reason for adding new property breaking change: #16042 (comment).

ruowan · 2021-09-17T02:57:47Z

@JeffreyRichter could you please help to review this breaking change?

…Vault to add version preview/2021-06-01-preview (#1922) Create to sync Azure/azure-rest-api-specs#16042 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/keyvault?expand=1)

…preview/2021-06-01-preview (Azure#16042) * Added exportable attribute and release policy to CP Swagger doc * Specify type as object for ReleasePolicy * Address code review comments * Add suppression code for camelCase * Prettier check

Added exportable attribute and release policy to CP Swagger doc

6a97dc0

openapi-pipeline-app bot added the NewApiVersionRequired label Sep 14, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 14, 2021

susolank marked this pull request as ready for review September 14, 2021 22:03

susolank requested review from heaths, jlichwa and RandalliLama as code owners September 14, 2021 22:03

openapi-assignment-bot bot assigned zhenglaizhang Sep 14, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 14, 2021

Specify type as object for ReleasePolicy

0082761

openapi-sdkautomation bot mentioned this pull request Sep 14, 2021

[AutoPR azure-resourcemanager-keyvault-generated] [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview AzureSDKAutomation/azure-sdk-for-java#10688

Closed

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Sep 14, 2021

susolank requested review from jkapil and dalzhao September 14, 2021 22:10

heaths approved these changes Sep 14, 2021

View reviewed changes

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/keys.json Outdated Show resolved Hide resolved

Address code review comments

e63de79

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 14, 2021

susolank requested review from adarce and liuqingb September 14, 2021 22:47

adarce requested a review from qinl-li September 14, 2021 22:55

heaths approved these changes Sep 15, 2021

View reviewed changes

zhenglaizhang assigned ruowan and unassigned zhenglaizhang Sep 15, 2021

Add suppression code for camelCase

4352993

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Sep 15, 2021

Prettier check

8379e90

ruowan added the BreakingChangeReviewRequired label Sep 16, 2021

ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 17, 2021

ruowan removed the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 17, 2021

ruowan requested a review from JeffreyRichter September 17, 2021 02:57

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 17, 2021

ruowan approved these changes Sep 18, 2021

View reviewed changes

ruowan merged commit c566c79 into Azure:main Sep 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

susolank commented Sep 14, 2021 •

edited

Loading

openapi-workflow-bot bot commented Sep 14, 2021

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading

openapi-workflow-bot bot commented Sep 14, 2021

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Sep 14, 2021

openapi-workflow-bot bot commented Sep 14, 2021

heaths left a comment

openapi-workflow-bot bot commented Sep 16, 2021

susolank commented Sep 16, 2021

susolank commented Sep 16, 2021

heaths commented Sep 16, 2021

ruowan commented Sep 17, 2021

ruowan commented Sep 17, 2021

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #16042

Conversation

susolank commented Sep 14, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 14, 2021

openapi-pipeline-app bot commented Sep 14, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Sep 14, 2021

openapi-pipeline-app bot commented Sep 14, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Sep 14, 2021

openapi-workflow-bot bot commented Sep 14, 2021

heaths left a comment

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Sep 16, 2021

susolank commented Sep 16, 2021

susolank commented Sep 16, 2021

heaths commented Sep 16, 2021

ruowan commented Sep 17, 2021

ruowan commented Sep 17, 2021

susolank commented Sep 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading