Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.KeyVault to add version …
Browse files Browse the repository at this point in the history
…preview/2021-06-01-preview (Azure#16042)

* Added exportable attribute and release policy to CP Swagger doc

* Specify type as object for ReleasePolicy

* Address code review comments

* Add suppression code for camelCase

* Prettier check
  • Loading branch information
susolank authored and LeiWang3 committed Mar 31, 2022
1 parent 2b582e4 commit dd553d7
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,10 @@
"rotationPolicy": {
"$ref": "#/definitions/RotationPolicy",
"description": "Key rotation policy in response. It will be used for both output and input. Omitted if empty"
},
"release_policy": {
"$ref": "#/definitions/KeyReleasePolicy",
"description": "Key release policy in response. It will be used for both output and input. Omitted if empty"
}
},
"description": "The properties of the key.",
Expand Down Expand Up @@ -473,6 +477,10 @@
},
"readOnly": true,
"x-nullable": false
},
"exportable": {
"type": "boolean",
"description": "Indicates if the private key can be exported."
}
},
"description": "The object attributes managed by the Azure Key Vault service.",
Expand Down Expand Up @@ -614,6 +622,21 @@
}
},
"type": "object"
},
"KeyReleasePolicy": {
"properties": {
"contentType": {
"description": "Content type and version of key release policy",
"type": "string",
"default": "application/json; charset=utf-8"
},
"data": {
"description": "Blob encoding the policy rules under which the key can be released.",
"type": "string",
"format": "base64url"
}
},
"type": "object"
}
},
"parameters": {
Expand Down
5 changes: 3 additions & 2 deletions specification/keyvault/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,12 @@ input-file:
``` yaml
directive:
- suppress:
- R3016 # The 'release_policy' property for KeyCreateParameters does not support camelCase.
- R3026 # The 'PrivateEndpointConnection' and 'PrivateLinkResource' sub-resources don't define PATCH as per Network Team's specification.
- R3025 # The 'PrivateLinkResource' is only accessible via List operation; does not define GET as per Network Team's specification.
- R4015 # The 'MHSMPrivateEndpointConnection' sub-resource doesn't define List as per Network Team's specification.
- R2005 # The 'ManagedHsms_PurgeDeleted' operation should not return a mix of 202 and syncronous return types (200, 201, 204) as directed by SDK team.
- R4009 # Vault object is the only one that need to be tracked with SystemData
- R2005 # The 'ManagedHsms_PurgeDeleted' operation should not return a mix of 202 and syncronous return types (200, 201, 204) as directed by SDK team.
- R4009 # Vault object is the only one that need to be tracked with SystemData
```

---
Expand Down

0 comments on commit dd553d7

Please sign in to comment.