Sfmc add node optional parameter UseTempDastaDisk 2021 11 01 preview

[a-santamaria]

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No refresh required for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

• Removing API(s) in a stable version
• Removing properties in a stable version
• Removing API version(s) in a stable version
• Updating API in a stable or public preview version with Breaking Change Validation errors
• Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 27 Errors, 0 Warnings failed [Detail]

• Compared Swaggers (Based on Oad v0.9.1)
  • current:Microsoft.OperationalInsights/preview/2021-12-01-preview compared with base:Microsoft.OperationalInsights/preview/2021-12-01-preview

Rule	Message
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.OperationalInsights/operations' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/tables' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Tables.json#L37:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/tables/{tableName}' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Tables.json#L82:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.OperationalInsights/workspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L37:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L76:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L118:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.OperationalInsights/deletedWorkspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L319:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/deletedWorkspaces' removed or restructured? Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Workspaces.json#L358:5
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Schema' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SearchResults' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'RestoredLogs' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ResultStatistics' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'TableProperties' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Table' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'WorkspaceSku' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'WorkspaceCapping' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'WorkspaceProperties' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'WorkspaceFeatures' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Workspace' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'WorkspacePatch' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'PublicNetworkAccessType' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L37:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L74:3
❌ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3
❌ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TableNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3
❌ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3
❌ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3
❌ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? New: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L38:3 Old: Microsoft.OperationalInsights/preview/2021-12-01-preview/Operations.json#L123:3

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2021-06

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️⌛SDK Breaking Change Tracking pending [Detail]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 08738b2. SDK Automation 14.0.0

  warn	Skip initScript due to not configured
  command	sudo apt-get install -y dotnet-sdk-6.0
  command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied

• ️✔️Microsoft.Azure.Management.ServiceFabricManagedClusters [View full logs]  [Release SDK Changes]
  • Microsoft.Azure.Management.ServiceFabricManagedClusters.1.0.0.nupkg
  • Microsoft.Azure.Management.ServiceFabricManagedClusters.1.0.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 08738b2. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh] npm notice
  cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
  cmderr	[automation_generate.sh] npm notice

• ️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes]
  • azure-mgmt-servicefabricmanagedclusters-0.1.0.zip
  • azure_mgmt_servicefabricmanagedclusters-0.1.0-py3-none-any.whl

  info	[Changelog] **Features**
  info	[Changelog]
  info	[Changelog]   - Added operation group ManagedUnsupportedVMSizesOperations
  info	[Changelog]   - Added operation group NodeTypeSkusOperations
  info	[Changelog]   - Model ManagedCluster has a new parameter auxiliary_subnets
  info	[Changelog]   - Model ManagedCluster has a new parameter enable_ipv6
  info	[Changelog]   - Model ManagedCluster has a new parameter enable_service_public_ip
  info	[Changelog]   - Model ManagedCluster has a new parameter ip_tags
  info	[Changelog]   - Model ManagedCluster has a new parameter ipv6_address
  info	[Changelog]   - Model ManagedCluster has a new parameter service_endpoints
  info	[Changelog]   - Model ManagedCluster has a new parameter subnet_id
  info	[Changelog]   - Model NetworkSecurityRule has a new parameter destination_address_prefix
  info	[Changelog]   - Model NetworkSecurityRule has a new parameter destination_port_range
  info	[Changelog]   - Model NetworkSecurityRule has a new parameter source_address_prefix
  info	[Changelog]   - Model NetworkSecurityRule has a new parameter source_port_range
  info	[Changelog]   - Model NodeType has a new parameter additional_data_disks
  info	[Changelog]   - Model NodeType has a new parameter data_disk_letter
  info	[Changelog]   - Model NodeType has a new parameter enable_accelerated_networking
  info	[Changelog]   - Model NodeType has a new parameter enable_encryption_at_host
  info	[Changelog]   - Model NodeType has a new parameter frontend_configurations
  info	[Changelog]   - Model NodeType has a new parameter network_security_rules
  info	[Changelog]   - Model NodeType has a new parameter sku
  info	[Changelog]   - Model NodeType has a new parameter use_default_public_load_balancer
  info	[Changelog]   - Model NodeType has a new parameter use_temp_data_disk
  info	[Changelog]   - Model NodeTypeUpdateParameters has a new parameter sku

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 08738b2. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh] WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

• ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

[openapi-workflow-bot]

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

[msyyc]

/azp run

[openapi-workflow-bot]

Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.