add useTempDataDisk, remove dataDiskSizeGB from required and add exam…

…ples (Azure#16704) Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
LeiWang3 · Mar 31, 2022 · 02d9d49 · 02d9d49
1 parent 1531e52
commit 02d9d49
Show file tree

Hide file tree

Showing 3 changed files with 132 additions and 4 deletions.
diff --git a/...viceFabric/preview/2021-11-01-preview/examples/NodeTypePutOperationStateless_example.json b/...viceFabric/preview/2021-11-01-preview/examples/NodeTypePutOperationStateless_example.json
@@ -0,0 +1,114 @@
+{
+  "parameters": {
+    "subscriptionId": "00000000-0000-0000-0000-000000000000",
+    "resourceGroupName": "resRg",
+    "clusterName": "myCluster",
+    "nodeTypeName": "BE",
+    "api-version": "2021-11-01-preview",
+    "parameters": {
+      "properties": {
+        "isPrimary": false,
+        "vmSize": "Standard_DS3",
+        "vmImagePublisher": "MicrosoftWindowsServer",
+        "vmImageOffer": "WindowsServer",
+        "vmImageSku": "2016-Datacenter-Server-Core",
+        "vmImageVersion": "latest",
+        "vmInstanceCount": 10,
+        "enableEncryptionAtHost": true,
+        "isStateless": true,
+        "useTempDataDisk": true,
+        "multiplePlacementGroups": true,
+        "vmExtensions": [
+          {
+            "name": "Microsoft.Azure.Geneva.GenevaMonitoring",
+            "properties": {
+              "autoUpgradeMinorVersion": true,
+              "publisher": "Microsoft.Azure.Geneva",
+              "type": "GenevaMonitoring",
+              "typeHandlerVersion": "2.0",
+              "settings": {}
+            }
+          }
+        ]
+      }
+    }
+  },
+  "responses": {
+    "202": {
+      "headers": {
+        "Location": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationResults/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview",
+        "Azure-AsyncOperation": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationStatus/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview"
+      },
+      "body": {
+        "type": "Microsoft.ServiceFabric/managedClusters/nodeTypes",
+        "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/resRg/providers/Microsoft.ServiceFabric/managedClusters/myCluster/nodeTypes/BE",
+        "name": "BE",
+        "tags": {},
+        "properties": {
+          "provisioningState": "Updating",
+          "isPrimary": false,
+          "vmSize": "Standard_DS3",
+          "vmImagePublisher": "MicrosoftWindowsServer",
+          "vmImageOffer": "WindowsServer",
+          "vmImageSku": "2016-Datacenter-Server-Core",
+          "vmImageVersion": "latest",
+          "vmInstanceCount": 10,
+          "enableEncryptionAtHost": true,
+          "isStateless": true,
+          "useTempDataDisk": true,
+          "multiplePlacementGroups": true,
+          "vmExtensions": [
+            {
+              "name": "Microsoft.Azure.Geneva.GenevaMonitoring",
+              "properties": {
+                "autoUpgradeMinorVersion": true,
+                "publisher": "Microsoft.Azure.Geneva",
+                "type": "GenevaMonitoring",
+                "typeHandlerVersion": "2.0",
+                "settings": {}
+              }
+            }
+          ]
+        }
+      }
+    },
+    "200": {
+      "headers": {
+        "Location": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationResults/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview",
+        "Azure-AsyncOperation": "http://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.ServiceFabric/locations/eastus/managedClusterOperationStatus/1ca6e48d-70ca-4e43-b652-3b0522f64d67?api-version=2021-11-01-preview"
+      },
+      "body": {
+        "type": "Microsoft.ServiceFabric/managedClusters/nodeTypes",
+        "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/resRg/providers/Microsoft.ServiceFabric/managedClusters/myCluster/nodeTypes/BE",
+        "name": "BE",
+        "tags": {},
+        "properties": {
+          "provisioningState": "Creating",
+          "isPrimary": false,
+          "vmSize": "Standard_DS3",
+          "vmImagePublisher": "MicrosoftWindowsServer",
+          "vmImageOffer": "WindowsServer",
+          "vmImageSku": "2016-Datacenter-Server-Core",
+          "vmImageVersion": "latest",
+          "vmInstanceCount": 10,
+          "enableEncryptionAtHost": true,
+          "isStateless": true,
+          "useTempDataDisk": true,
+          "multiplePlacementGroups": true,
+          "vmExtensions": [
+            {
+              "name": "Microsoft.Azure.Geneva.GenevaMonitoring",
+              "properties": {
+                "autoUpgradeMinorVersion": true,
+                "publisher": "Microsoft.Azure.Geneva",
+                "type": "GenevaMonitoring",
+                "typeHandlerVersion": "2.0",
+                "settings": {}
+              }
+            }
+          ]
+        }
+      }
+    }
+  }
+}
diff --git a/...t.ServiceFabric/preview/2021-11-01-preview/examples/NodeTypePutOperation_example_max.json b/...t.ServiceFabric/preview/2021-11-01-preview/examples/NodeTypePutOperation_example_max.json
@@ -72,7 +72,15 @@
             "diskSizeGB": 150,
             "diskLetter": "G"
           }
-        ]
+        ],
+        "enableAcceleratedNetworking": true,
+        "frontendConfigurations": [
+          {
+            "loadBalancerBackendAddressPoolId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/loadBalancers/test-LB/backendAddressPools/LoadBalancerBEAddressPool",
+            "loadBalancerInboundNatPoolId": " /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/loadBalancers/test-LB/inboundNatPools/LoadBalancerNATPool"
+          }
+        ],
+        "useDefaultPublicLoadBalancer": true
       }
     }
   },

diff --git a/...lusters/resource-manager/Microsoft.ServiceFabric/preview/2021-11-01-preview/nodetype.json b/...lusters/resource-manager/Microsoft.ServiceFabric/preview/2021-11-01-preview/nodetype.json
@@ -397,6 +397,9 @@
           },
           "Put a node type with auto-scale parameters": {
             "$ref": "./examples/NodeTypePutOperationAutoScale_example.json"
+          },
+          "Put an stateless node type with temporary disk for service fabric": {
+            "$ref": "./examples/NodeTypePutOperationStateless_example.json"
           }
         },
         "x-ms-long-running-operation": true,
@@ -684,8 +687,7 @@
       "type": "object",
       "required": [
         "isPrimary",
-        "vmInstanceCount",
-        "dataDiskSizeGB"
+        "vmInstanceCount"
       ],
       "properties": {
         "isPrimary": {
@@ -702,7 +704,7 @@
         "dataDiskSizeGB": {
           "type": "integer",
           "format": "int32",
-          "description": "Disk size for each vm in the node type in GBs."
+          "description": "Disk size for the managed disk attached to the vms on the node type in GBs."
         },
         "dataDiskType": {
           "$ref": "#/definitions/DiskType",
@@ -825,6 +827,10 @@
         "useDefaultPublicLoadBalancer": {
           "type": "boolean",
           "description": "Specifies whether the use public load balancer. If not specified and the node type doesn't have its own frontend configuration, it will be attached to the default load balancer. If the node type uses its own Load balancer and useDefaultPublicLoadBalancer is true, then the frontend has to be an Internal Load Balancer. If the node type uses its own Load balancer and useDefaultPublicLoadBalancer is false or not set, then the custom load balancer must include a public load balancer to provide outbound connectivity."
+        },
+        "useTempDataDisk": {
+          "type": "boolean",
+          "description": "Specifies whether to use the temporary disk for the service fabric data root, in which case no managed data disk will be attached and the temporary disk will be used. It is only allowed for stateless node types."
         }
       },
       "description": "Describes a node type in the cluster, each node type represents sub set of nodes in the cluster."