Fix s360 error in Reservation Recommendations #16767

pednekarpraj · 2021-11-15T23:25:07Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-11-15T23:25:10Z

Hi, @pednekarpraj Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-11-15T23:25:10Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-11-15T23:25:10Z

Swagger Validation Report

️❌BreakingChange: 5 Errors, 2 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-10-01/consumption.json compared with base:stable/2021-10-01/consumption.json

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3468:9 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3466:9
`❌` 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3377:9 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3377:9
`❌` 1030 - DifferentDiscriminator	The new version has a different discriminator than the previous one. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392:5 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392:5
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'scope' that was not found in the old version. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3377:9 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3377:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'scope' that was not found in the old version. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392:5 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392:5
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3377:9 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3377:9
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392:5 Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3392:5

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- consumption/resource-manager/readme.md tag:package-2021-10
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- consumption/resource-manager/readme.md tag:package-2021-10

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R3017 - GuidUsage	Guid used in model definition 'LegacySingleScopeReservationRecommendationProperties' for property 'subscriptionId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3490

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L424
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1418
`❌` R4037 - MissingTypeObject	The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1787
`❌` R4037 - MissingTypeObject	The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1866
`❌` R4037 - MissingTypeObject	The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1904
`❌` R4037 - MissingTypeObject	The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2167
`❌` R4037 - MissingTypeObject	The schema 'ReservationSummariesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2901
`❌` R4037 - MissingTypeObject	The schema 'ReservationSummaryProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2919
`❌` R4037 - MissingTypeObject	The schema 'ReservationDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3026
`❌` R4037 - MissingTypeObject	The schema 'ReservationDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3044
`❌` R4037 - MissingTypeObject	The schema 'ReservationRecommendationDetailsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3136
`❌` R4037 - MissingTypeObject	The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3171
`❌` R4037 - MissingTypeObject	The schema 'ReservationRecommendationDetailsResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3210
`❌` R4037 - MissingTypeObject	The schema 'ReservationRecommendationDetailsSavingsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3248
`❌` R4037 - MissingTypeObject	The schema 'ReservationRecommendationDetailsUsageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3286
`❌` R4037 - MissingTypeObject	The schema 'ReservationRecommendationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3319
`❌` R4037 - MissingTypeObject	The schema 'SkuProperty' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3513
`❌` R4037 - MissingTypeObject	The schema 'ModernReservationRecommendationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3548
`❌` R4037 - MissingTypeObject	The schema 'ModernReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3640
`❌` R4037 - MissingTypeObject	The schema 'LegacyReservationTransactionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3788
`❌` R4037 - MissingTypeObject	The schema 'ReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3931
`❌` R4037 - MissingTypeObject	The schema 'ModernReservationTransactionsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3949
`❌` R4037 - MissingTypeObject	The schema 'TagProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3983
`❌` R4037 - MissingTypeObject	The schema 'Tag' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4005
`❌` R4037 - MissingTypeObject	The schema 'BudgetsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4021
`❌` R4037 - MissingTypeObject	The schema 'BudgetProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4055
`❌` R4037 - MissingTypeObject	The schema 'BudgetTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4126
`❌` R4037 - MissingTypeObject	The schema 'BudgetFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4144
`❌` R4037 - MissingTypeObject	The schema 'BudgetFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4169
`❌` R4037 - MissingTypeObject	The schema 'BudgetComparisonExpression' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L4182

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

consumption/resource-manager/readme.md#package-2021-10

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-11-15T23:25:11Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - consumption/mgmt/2019-10-01/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2019-01-01/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2018-10-01/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2018-08-31/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2018-06-30/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2018-05-31/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2018-03-31/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2018-01-31/consumption - v59.3.0
️✔️azure-sdk-for-go - consumption/mgmt/2017-11-30/consumption - v59.3.0
️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-12-30-preview/consumption - v59.3.0
️✔️azure-sdk-for-go - preview/consumption/mgmt/2017-04-24-preview/consumption - v59.3.0
❌azure-sdk-for-go-track2 - armconsumption - 0.3.0

+	Function `LegacyReservationRecommendationProperties.MarshalJSON` has been removed
+	Type of `LegacyReservationRecommendation.Properties` has been changed from `*LegacyReservationRecommendationProperties` to `LegacyReservationRecommendationPropertiesClassification`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - 8.0.0

+	Parameter scope of model LegacyReservationRecommendation is now required
+	Parameter scope of model LegacyReservationRecommendation is now required

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0d04177. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Consumption [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Consumption.3.0.2.nupkg
- Microsoft.Azure.Management.Consumption.3.0.2.symbols.nupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0d04177. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️consumption/mgmt/2019-10-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2019-01-01/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-10-01/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-08-31/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-06-30/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-05-31/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-03-31/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-01-31/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2017-11-30/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0d04177. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armconsumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `LegacyReservationRecommendation.Properties` has been changed from `*LegacyReservationRecommendationProperties` to `LegacyReservationRecommendationPropertiesClassification`
info	[Changelog] - Function `EventSummary.MarshalJSON` has been removed
info	[Changelog] - Function `LegacyReservationRecommendationProperties.MarshalJSON` has been removed
info	[Changelog] - Function `LotSummary.MarshalJSON` has been removed
info	[Changelog] - Field `Resource` of struct `EventSummary` has been removed
info	[Changelog] - Field `Resource` of struct `ChargeSummary` has been removed
info	[Changelog] - Field `Resource` of struct `LotSummary` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `CultureCodeZhTw`
info	[Changelog] - New const `CultureCodeSvSe`
info	[Changelog] - New const `ThresholdTypeForecasted`
info	[Changelog] - New const `CultureCodeFrFr`
info	[Changelog] - New const `CultureCodeRuRu`
info	[Changelog] - New const `CultureCodeDeDe`
info	[Changelog] - New const `CultureCodeTrTr`
info	[Changelog] - New const `CultureCodeJaJp`
info	[Changelog] - New const `CultureCodeKoKr`
info	[Changelog] - New const `CultureCodeEnGb`
info	[Changelog] - New const `CultureCodeNbNo`
info	[Changelog] - New const `CultureCodeNlNl`
info	[Changelog] - New const `CultureCodeEsEs`
info	[Changelog] - New const `CultureCodeZhCn`
info	[Changelog] - New const `CultureCodeItIt`
info	[Changelog] - New const `CultureCodePtPt`
info	[Changelog] - New const `CultureCodeEnUs`
info	[Changelog] - New const `CultureCodeHuHu`
info	[Changelog] - New const `CultureCodeDaDk`
info	[Changelog] - New const `CultureCodePtBr`
info	[Changelog] - New const `CultureCodePlPl`
info	[Changelog] - New const `CultureCodeCsCz`
info	[Changelog] - New function `*TagsResult.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*LegacyReservationRecommendationProperties.GetLegacyReservationRecommendationProperties() *LegacyReservationRecommendationProperties`
info	[Changelog] - New function `*LegacySingleScopeReservationRecommendationProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `LegacySharedScopeReservationRecommendationProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleCultureCodeValues() []CultureCode`
info	[Changelog] - New function `*ProxyResource.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `CultureCode.ToPtr() *CultureCode`
info	[Changelog] - New function `LegacySingleScopeReservationRecommendationProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*Budget.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `LegacySharedScopeReservationRecommendationProperties`
info	[Changelog] - New struct `LegacySingleScopeReservationRecommendationProperties`
info	[Changelog] - New field `Overage` in struct `LegacyReservationTransactionProperties`
info	[Changelog] - New field `BillingMonth` in struct `LegacyReservationTransactionProperties`
info	[Changelog] - New field `MonetaryCommitment` in struct `LegacyReservationTransactionProperties`
info	[Changelog] - New anonymous field `ProxyResource` in struct `ChargeSummary`
info	[Changelog] - New anonymous field `ProxyResource` in struct `LotSummary`
info	[Changelog] - New anonymous field `ProxyResource` in struct `EventSummary`
info	[Changelog] - New field `Locale` in struct `Notification`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 41 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 0d04177. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ChargeSummary has a new parameter e_tag
info	[Changelog]   - Model Tag has a new parameter value
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model CreditBalanceSummary has a new parameter estimated_balance_in_billing_currency
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter download
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter location_properties_location
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter sku_name
info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
info	[Changelog]   - Model ModernUsageDetail has a new parameter effective_price
info	[Changelog]   - Model ModernUsageDetail has a new parameter benefit_name
info	[Changelog]   - Model ModernUsageDetail has a new parameter provider
info	[Changelog]   - Model ModernUsageDetail has a new parameter benefit_id
info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
info	[Changelog]   - Model ModernUsageDetail has a new parameter pricing_model
info	[Changelog]   - Model ModernUsageDetail has a new parameter cost_allocation_rule_name
info	[Changelog]   - Model ModernChargeSummary has a new parameter e_tag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter additional_info
info	[Changelog]   - Model UsageDetail has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
info	[Changelog]   - Model LegacyUsageDetail has a new parameter pay_g_price
info	[Changelog]   - Model LegacyUsageDetail has a new parameter pricing_model
info	[Changelog]   - Model Notification has a new parameter locale
info	[Changelog]   - Model OperationDisplay has a new parameter description
info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model LegacyChargeSummary has a new parameter e_tag
info	[Changelog]   - Model LegacyReservationTransaction has a new parameter overage
info	[Changelog]   - Model LegacyReservationTransaction has a new parameter billing_month
info	[Changelog]   - Model LegacyReservationTransaction has a new parameter monetary_commitment
info	[Changelog]   - Model ReservationRecommendationsListResult has a new parameter previous_link
info	[Changelog]   - Model CreditSummary has a new parameter etag
info	[Changelog]   - Model CreditSummary has a new parameter billing_currency
info	[Changelog]   - Model CreditSummary has a new parameter credit_currency
info	[Changelog]   - Model CreditSummary has a new parameter e_tag
info	[Changelog]   - Model CreditSummary has a new parameter reseller
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model LotSummary has a new parameter e_tag_properties_e_tag
info	[Changelog]   - Model LotSummary has a new parameter billing_currency
info	[Changelog]   - Model LotSummary has a new parameter closed_balance_in_billing_currency
info	[Changelog]   - Model LotSummary has a new parameter original_amount_in_billing_currency
info	[Changelog]   - Model LotSummary has a new parameter credit_currency
info	[Changelog]   - Model LotSummary has a new parameter e_tag
info	[Changelog]   - Model LotSummary has a new parameter purchased_date
info	[Changelog]   - Model LotSummary has a new parameter reseller
info	[Changelog]   - Model LotSummary has a new parameter status
info	[Changelog]   - Model Budget has a new parameter forecast_spend
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ReservationTransaction has a new parameter overage
info	[Changelog]   - Model ReservationTransaction has a new parameter billing_month
info	[Changelog]   - Model ReservationTransaction has a new parameter monetary_commitment
info	[Changelog]   - Model EventSummary has a new parameter charges_in_billing_currency
info	[Changelog]   - Model EventSummary has a new parameter new_credit_in_billing_currency
info	[Changelog]   - Model EventSummary has a new parameter e_tag_properties_e_tag
info	[Changelog]   - Model EventSummary has a new parameter billing_currency
info	[Changelog]   - Model EventSummary has a new parameter lot_id
info	[Changelog]   - Model EventSummary has a new parameter closed_balance_in_billing_currency
info	[Changelog]   - Model EventSummary has a new parameter billing_profile_display_name
info	[Changelog]   - Model EventSummary has a new parameter credit_currency
info	[Changelog]   - Model EventSummary has a new parameter e_tag
info	[Changelog]   - Model EventSummary has a new parameter canceled_credit
info	[Changelog]   - Model EventSummary has a new parameter credit_expired_in_billing_currency
info	[Changelog]   - Model EventSummary has a new parameter reseller
info	[Changelog]   - Model EventSummary has a new parameter lot_source
info	[Changelog]   - Model EventSummary has a new parameter adjustments_in_billing_currency
info	[Changelog]   - Model EventSummary has a new parameter billing_profile_id
info	[Changelog]   - Added operation LotsOperations.list_by_billing_profile
info	[Changelog]   - Added operation LotsOperations.list_by_billing_account
info	[Changelog]   - Added operation EventsOperations.list_by_billing_profile
info	[Changelog]   - Added operation EventsOperations.list_by_billing_account
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter scope of model LegacyReservationRecommendation is now required
info	[Changelog]   - Parameter scope of model LegacyReservationRecommendation is now required
info	[Changelog]   - Operation ReservationRecommendationDetailsOperations.get has a new signature
info	[Changelog]   - Model ChargeSummary no longer has parameter tags
info	[Changelog]   - Model ModernChargeSummary no longer has parameter tags
info	[Changelog]   - Model LegacyChargeSummary no longer has parameter tags
info	[Changelog]   - Model LotSummary no longer has parameter tags
info	[Changelog]   - Model EventSummary no longer has parameter tags
info	[Changelog]   - Removed operation LotsOperations.list
info	[Changelog]   - Removed operation EventsOperations.list
info	[Changelog]   - Removed operation group ForecastsOperations

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0d04177. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-11-23 02:00:20 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-consumption;1.0.0-beta.2;1.0.0-beta.3"
cmderr	[generate.py] 2021-11-23 02:00:20 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
cmderr	[generate.py] 2021-11-23 02:00:20 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.40 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [POM][Skip] pom already has module sdk/consumption
cmderr	[generate.py] 2021-11-23 02:00:57 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-11-23 02:02:33 DEBUG Got artifact_id: azure-resourcemanager-consumption
cmderr	[Inst] 2021-11-23 02:02:33 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-11-23 02:02:33 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.3-sources.jar
cmderr	[Inst] 2021-11-23 02:02:33 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.3-javadoc.jar
cmderr	[Inst] 2021-11-23 02:02:33 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.3.jar
cmderr	[Inst] 2021-11-23 02:02:33 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.3.jar
cmderr	[Inst] 2021-11-23 02:02:33 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16767/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.3.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0d04177. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes]

azure-arm-consumption-8.0.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
cmderr	[npmPack] created ./dist/arm-consumption.js in 593ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 0d04177. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2407) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2018-01-31/Microsoft.Consumption.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2407) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2407) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
warn	No file changes detected after generation

️✔️consumption [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-15T23:27:12Z

Hi @pednekarpraj, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-11-15T23:27:40Z

Hi @pednekarpraj, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

pednekarpraj · 2021-11-16T23:07:32Z

@jianyexi Look like validation checks are stuck in 'Queued' state from yesterday. Could you please unblock them, I would like to get this PR merged as soon as possible?

jianyexi · 2021-11-18T01:59:57Z

/azp run

azure-pipelines · 2021-11-18T02:00:24Z

Azure Pipelines successfully started running 1 pipeline(s).

zhenglaizhang · 2021-11-22T06:10:06Z

/azp run

azure-pipelines · 2021-11-22T06:10:16Z

Azure Pipelines successfully started running 1 pipeline(s).

pednekarpraj · 2021-11-22T20:02:10Z

@jianyexi Can you merge the PR ? Also, model validations errors (two errors in reservation transactions and one in Operations_List API) are not related to my changes. Those are existing files and I didn't modify them.

* Fix s360 error * Fix errors * Fix errors

Fix s360 error

aa9fde1

pednekarpraj requested a review from kjeur as a code owner November 15, 2021 23:25

openapi-assignment-bot bot assigned ruowan Nov 15, 2021

openapi-workflow-bot bot added the FixS360 label Nov 15, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Nov 15, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Nov 15, 2021

Fix errors

9b9bfc8

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Nov 15, 2021

openapi-sdkautomation bot mentioned this pull request Nov 15, 2021

[AutoPR track2_azure-mgmt-consumption] Fix s360 error in Reservation Recommendations AzureSDKAutomation/azure-sdk-for-python#8107

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Nov 15, 2021

Fix errors

c15c009

ruowan assigned jianyexi and unassigned ruowan Nov 16, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 16, 2021

thramu self-requested a review November 18, 2021 21:51

thramu approved these changes Nov 22, 2021

View reviewed changes

pednekarpraj removed the request for review from kjeur November 22, 2021 20:53

jianyexi merged commit 0d04177 into Azure:main Nov 23, 2021

LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022

Fix s360 error in Reservation Recommendations (Azure#16767)

002a8b7

* Fix s360 error * Fix errors * Fix errors

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix s360 error in Reservation Recommendations #16767

Fix s360 error in Reservation Recommendations #16767

pednekarpraj commented Nov 15, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 15, 2021

openapi-workflow-bot bot commented Nov 15, 2021

openapi-pipeline-app bot commented Nov 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 15, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Nov 15, 2021

openapi-workflow-bot bot commented Nov 15, 2021

pednekarpraj commented Nov 16, 2021

jianyexi commented Nov 18, 2021

azure-pipelines bot commented Nov 18, 2021

zhenglaizhang commented Nov 22, 2021

azure-pipelines bot commented Nov 22, 2021

pednekarpraj commented Nov 22, 2021

Fix s360 error in Reservation Recommendations #16767

Fix s360 error in Reservation Recommendations #16767

Conversation

pednekarpraj commented Nov 15, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 15, 2021

openapi-workflow-bot bot commented Nov 15, 2021

openapi-pipeline-app bot commented Nov 15, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 15, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Nov 15, 2021

openapi-workflow-bot bot commented Nov 15, 2021

pednekarpraj commented Nov 16, 2021

jianyexi commented Nov 18, 2021

azure-pipelines bot commented Nov 18, 2021

zhenglaizhang commented Nov 22, 2021

azure-pipelines bot commented Nov 22, 2021

pednekarpraj commented Nov 22, 2021

pednekarpraj commented Nov 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 15, 2021 •

edited

Loading