Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s360 error in Reservation Recommendations #16767

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3391,6 +3391,8 @@
},
"LegacyReservationRecommendationProperties": {
"description": "The properties of the reservation recommendation.",
"type": "object",
"discriminator": "scope",
"properties": {
"lookBackPeriod": {
"description": "The number of days of usage to look back for recommendation.",
Expand Down Expand Up @@ -3465,8 +3467,7 @@
},
"scope": {
"description": "Shared or single recommendation.",
"type": "string",
"readOnly": true
"type": "string"
},
"skuProperties": {
"description": "List of sku properties",
Expand All @@ -3476,7 +3477,38 @@
},
"readOnly": true
}
}
},
"required": [
"scope"
]
},
"LegacySingleScopeReservationRecommendationProperties": {
"description": "The properties of the legacy reservation recommendation for single scope.",
"type": "object",
"x-ms-discriminator-value": "Single",
"properties": {
"subscriptionId": {
"description": "Subscription id associated with single scoped recommendation.",
"type": "string",
"format": "uuid",
"readOnly": true
}
},
"allOf": [
{
"$ref": "#/definitions/LegacyReservationRecommendationProperties"
}
]
},
"LegacySharedScopeReservationRecommendationProperties": {
"description": "The properties of the legacy reservation recommendation for shared scope.",
"type": "object",
"x-ms-discriminator-value": "Shared",
"allOf": [
{
"$ref": "#/definitions/LegacyReservationRecommendationProperties"
}
]
},
"SkuProperty": {
"description": "The Sku property",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"totalCostWithReservedInstances": 0.0,
"netSavings": 4.634521202630137,
"firstUsageDate": "2018-03-06T00:00:00Z",
"scope": "Single"
"scope": "Single",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
}
},
{
Expand All @@ -42,7 +43,8 @@
"totalCostWithReservedInstances": 0.0,
"netSavings": 7.2893157231780812,
"firstUsageDate": "2018-03-06T00:00:00Z",
"scope": "Single"
"scope": "Single",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
}
}
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"totalCostWithReservedInstances": 0.0,
"netSavings": 4.634521202630137,
"firstUsageDate": "2018-03-06T00:00:00Z",
"scope": "Single"
"scope": "Single",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
}
},
{
Expand All @@ -42,7 +43,8 @@
"totalCostWithReservedInstances": 0.0,
"netSavings": 7.2893157231780812,
"firstUsageDate": "2018-03-06T00:00:00Z",
"scope": "Single"
"scope": "Single",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
}
}
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"name": "Ram",
"value": "1"
}
]
],
"subscriptionId": "00000000-0000-0000-0000-000000000000"
}
},
{
Expand Down Expand Up @@ -63,7 +64,8 @@
"name": "CPU",
"value": "1"
}
]
],
"subscriptionId": "00000000-0000-0000-0000-000000000000"
}
}
],
Expand Down