add enableNamespaceResources in Managed Cluster #16835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Anumita Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @Anumita, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Anumita
force-pushed
the
ansheno/2021-11-01-preview-enableNamespaceResources
branch
from
5e91758 to
d14ad42
Compare
This was referenced Nov 22, 2021
krdhruva
reviewed
Nov 22, 2021
.../resource-manager/Microsoft.ContainerService/preview/2021-11-01-preview/managedClusters.json
Outdated
Show resolved
Hide resolved
krdhruva
approved these changes
Nov 22, 2021
.../resource-manager/Microsoft.ContainerService/preview/2021-11-01-preview/managedClusters.json
Outdated
Show resolved
Hide resolved
Anumita
force-pushed
the
ansheno/2021-11-01-preview-enableNamespaceResources
branch
from
cec5e13 to
fd91a15
Compare
shashankbarsin
approved these changes
Nov 22, 2021
matthchr
requested changes
Nov 22, 2021
| @@ -3752,6 +3755,10 @@ | |||
| "type": "boolean", | |||
| "description": "(DEPRECATING) Whether to enable Kubernetes pod security policy (preview). This feature is set for removal on October 15th, 2020. Learn more at aka.ms/aks/azpodpolicy." | |||
| }, | |||
| "enableNamespaceResources": { | |||
| "type": "boolean", | |||
| "description": "Enable namespace as Azure resource." | |||
There was a problem hiding this comment.
It'd be good to see more of a description than this. I think we should be looking to answer the following questions:
- Do we have an article talking about namespace as a resource and how to use it? If so can we link it here? If not an article, is there at least a REST API reference document for the resource in question that we can point customers to, so they at least know what APIs setting this to true enables them to call?
- Are there requirements on when this can be set? Must it be set only on cluster create? Can it be enabled later? Can it be disabled after it's enabled? If it's disabled after it's enabled what happens?
- What's the default if this parameter is not specified?
There was a problem hiding this comment.
You can use the title/description split if you get a lot and want to split it into a more "summary" doc like you have here and then a "details" doc (which would go into description, the summary into title).
There was a problem hiding this comment.
- On article, here's the documentation link we have created. Will update the target for this aka.ms link to point to the new documentation page for this feature which will be written up when we are closer to the feature release date. @shashankbarsin has the action item on this.
- On when this can be set, the property can be enabled/disabled on cluster create and update. If it is disabled after enabling, user will not be able to see the namespace ARM resources.
- Default value is false.
There was a problem hiding this comment.
On when this can be set, the property can be enabled/disabled on cluster create and update. If it is disabled after enabling, user will not be able to see the namespace ARM resources.
Default value is false.
Can you put those into the documentation/description in the Swagger, so that the customer also knows the answers to these questions?
There was a problem hiding this comment.
@matthchr , updated the title and description
Anumita
force-pushed
the
ansheno/2021-11-01-preview-enableNamespaceResources
branch
from
fd91a15 to
c8fbfdb
Compare
matthchr
approved these changes
Nov 24, 2021
|
Hey @akning-ms , review is done from the relevant folks. Could you please help in reviewing and merging? Thanks! |
akning-ms
merged commit 07dd23b
into
Azure:dev-containerservice-Microsoft.ContainerService-2021-11-01-preview
ArcturusZhang
pushed a commit
that referenced
this pull request
Dec 28, 2021
…2021-11-01-preview (#17104) * Adds base for updating Microsoft.ContainerService from version stable/2021-10-01 to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * feat: define OIDC issuer profile (#16834) * feat: define OIDC issuer profile * fix: add `OIDC` to custom-wrods.txt * doc: update description * style: fix style check * fix: add type * add enableNamespaceResources in Managed Cluster (#16835) * add enableNamespaceResources in Managed Cluster * update example for enableNamespaceResources * changed description of enableNamespaceresources * change description for enableNamespaceResources * feat: define currentKubernetesVersion (#16878) Add property currentKubernetesVersion for feature AliasMinorVersion * add message of the day for Linux nodes (#16942) * [AKS] feat: add python SDK generation for 1001/1101-preview api (#16895) * feat: add python SDK generation for 1001/1101-preview api * fix: missing tag * fix: update path * fix: update path * fix: typo * feat: update readme.python.md * Rebased from main to dev branch (#17081) Co-authored-by: Anumita Shenoy <anumitashenoy@gmail.com> Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com> Co-authored-by: Ace Eldeib <alexeldeib@gmail.com> Co-authored-by: Tong Chen <45081443+tonche@users.noreply.github.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…2021-11-01-preview (Azure#17104) * Adds base for updating Microsoft.ContainerService from version stable/2021-10-01 to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * feat: define OIDC issuer profile (Azure#16834) * feat: define OIDC issuer profile * fix: add `OIDC` to custom-wrods.txt * doc: update description * style: fix style check * fix: add type * add enableNamespaceResources in Managed Cluster (Azure#16835) * add enableNamespaceResources in Managed Cluster * update example for enableNamespaceResources * changed description of enableNamespaceresources * change description for enableNamespaceResources * feat: define currentKubernetesVersion (Azure#16878) Add property currentKubernetesVersion for feature AliasMinorVersion * add message of the day for Linux nodes (Azure#16942) * [AKS] feat: add python SDK generation for 1001/1101-preview api (Azure#16895) * feat: add python SDK generation for 1001/1101-preview api * fix: missing tag * fix: update path * fix: update path * fix: typo * feat: update readme.python.md * Rebased from main to dev branch (Azure#17081) Co-authored-by: Anumita Shenoy <anumitashenoy@gmail.com> Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com> Co-authored-by: Ace Eldeib <alexeldeib@gmail.com> Co-authored-by: Tong Chen <45081443+tonche@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.