Review request for Microsoft.ContainerService to add version preview/2021-11-01-preview #17104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2021-10-01 to version 2021-11-01-preview
* feat: define OIDC issuer profile * fix: add `OIDC` to custom-wrods.txt * doc: update description * style: fix style check * fix: add type
* add enableNamespaceResources in Managed Cluster * update example for enableNamespaceResources * changed description of enableNamespaceresources * change description for enableNamespaceResources
Add property currentKubernetesVersion for feature AliasMinorVersion
…e#16895) * feat: add python SDK generation for 1001/1101-preview api * fix: missing tag * fix: update path * fix: update path * fix: typo * feat: update readme.python.md
…Microsoft.ContainerService-2021-11-01-preview
|
Hi, @bcho Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
25 tasks
|
Hi @bcho, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Dec 15, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mentat9 could you help review above reply? Thanks! |
|
Hi Tong I would strongly suggest to do the rename. When customers write ARM templates to deploy resources , we would like them to have a consistent naming conventions across the board so that it makes it easy for them . When writing an ARM template it is much clearer that the full resource id is required to be passed in this case. Especially since in these cases , the customer would only get the error after the template has deployed and failed. If there are resources not following this pattern then it is a mistake and should be fixed or could be due to legacy reasons. This is a small change that can help customer usage a lot. That said I am adding the arm signed off since this is not something we would block the review on. You can still fix it and then it commit this checkin with my sign off. In reply to: 997664596 |
raosuhas
added
ARMSignedOff
Thanks for your review! I think Tong will address this issue in GA API. For now, we want to move forward with current fields as we had finished the rollout in our end. @akning-ms / @ArcturusZhang could you help review and merge this pr to main branch? Thanks in advance! |
ArcturusZhang
approved these changes
Dec 28, 2021
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
bcho
deleted the
hbc/dev-containerservice-Microsoft.ContainerService-2021-11-01-preview-final
branch
This was referenced Dec 28, 2021
|
/azp run |
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…2021-11-01-preview (Azure#17104) * Adds base for updating Microsoft.ContainerService from version stable/2021-10-01 to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * feat: define OIDC issuer profile (Azure#16834) * feat: define OIDC issuer profile * fix: add `OIDC` to custom-wrods.txt * doc: update description * style: fix style check * fix: add type * add enableNamespaceResources in Managed Cluster (Azure#16835) * add enableNamespaceResources in Managed Cluster * update example for enableNamespaceResources * changed description of enableNamespaceresources * change description for enableNamespaceResources * feat: define currentKubernetesVersion (Azure#16878) Add property currentKubernetesVersion for feature AliasMinorVersion * add message of the day for Linux nodes (Azure#16942) * [AKS] feat: add python SDK generation for 1001/1101-preview api (Azure#16895) * feat: add python SDK generation for 1001/1101-preview api * fix: missing tag * fix: update path * fix: update path * fix: typo * feat: update readme.python.md * Rebased from main to dev branch (Azure#17081) Co-authored-by: Anumita Shenoy <anumitashenoy@gmail.com> Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com> Co-authored-by: Ace Eldeib <alexeldeib@gmail.com> Co-authored-by: Tong Chen <45081443+tonche@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.