IoT Hub - X509CA support #1723

mastermanu · 2017-09-22T01:01:49Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

alvadb

There are multiple linter errors (https://travis-ci.org/Azure/azure-rest-api-specs/jobs/278476257). Please fix.

alvadb · 2017-09-22T20:29:42Z

specification/iothub/resource-manager/Microsoft.Devices/2017-07-01/iothub.json

+            "$ref": "#/parameters/subscriptionId"
+          },
+          {
+            "name": "resourceGroupName",


Please move this to the global parameter section and reference throughout.

alvadb · 2017-09-22T20:29:54Z

specification/iothub/resource-manager/Microsoft.Devices/2017-07-01/iothub.json

+            "type": "string"
+          },
+          {
+            "name": "resourceName",


Please move this to the global parameter section and reference throughout.

alvadb · 2017-09-22T20:30:25Z

specification/iothub/resource-manager/Microsoft.Devices/2017-07-01/iothub.json

+            "type": "string"
+          },
+          {
+            "name": "certificateName",


Please move this to the global parameter section and reference throughout.

mastermanu · 2017-09-22T23:17:29Z

@alvadb - Please see: #1514. (This was the previous PR, but the employee has left the company so I created a new PR). It was agreed that the Linter warnings do not apply in this particular instance and was signed off by Anu

ravbhatnagar · 2017-09-26T04:02:13Z

@mastermanu @manusr I don't see the changes that were requested in the older PR. Properties like subjectname etc should go inside the properties bag. Please make sure the certificate resource complies with the basic shape needed for an ARM resource. Since this is likely a proxy resource, it will have id, name and type properties and all other peoperties will go inside the properties bag

azuresdkciprbot · 2017-09-29T21:57:53Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 17
After the PR: Warning(s): 0 Error(s): 17

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2017-09-29T22:43:50Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 17
After the PR: Warning(s): 0 Error(s): 17

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2017-09-30T00:18:52Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-09-30T00:19:22Z

Azure/azure-sdk-for-python#1496

AutorestCI · 2017-09-30T00:19:49Z

Azure/azure-sdk-for-ruby#1011

amarzavery · 2017-10-02T14:58:28Z

specification/iothub/resource-manager/Microsoft.Devices/2017-07-01/iothub.json

@@ -2138,6 +2441,28 @@
      "description": "The version of the API.",
      "required": true,
      "type": "string"
+    },
+	"resourceGroupName": {


Azure/azure-openapi-validator#84

@amarzavery I've added "x-ms-parameter-location": "method" to the objects that describe parameters that are only used in methods, however I'm losing the "credentials" parameter IotHubClientConfiguration(credentials, subscription_id, base_url) has now become IotHubClientConfiguration(subscription_id, base_url) and this seems to be causing several issues. Any thoughts on how to fix this?

Ah seems to be an autorest option that might be new

andrew-buckley · 2017-10-02T20:58:54Z

specification/iothub/resource-manager/Microsoft.Devices/2017-07-01/iothub.json

+        "tags": [ "Certificates" ],
+        "summary": "Get the certificate list.",
+        "description": "Returns the list of certificates.",
+        "operationId": "Certificates_ListByIoTHub",


should be Certificates_ListByIotHub, autorest generated sdks are getting confused.

manusr added 2 commits September 21, 2017 17:44

Initial checkin

14d6674

Fix syntax error

419fcb0

msftclas added the cla-not-required label Sep 22, 2017

azuresdkci assigned alvadb Sep 22, 2017

Adds id and type to certificate response structure as well

e0d7bed

alvadb suggested changes Sep 22, 2017

View reviewed changes

alvadb reviewed Sep 22, 2017

View reviewed changes

address reviewer comments

9f21044

alvadb added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 23, 2017

alvadb requested a review from ravbhatnagar September 23, 2017 01:35

manusr added 2 commits September 22, 2017 19:00

fixes typo

77481f2

Adds limit on certificate name

afed907

msftgits removed the cla-not-required label Sep 26, 2017

Azure deleted a comment from msftclas Sep 27, 2017

Fixes nesting of etag, name, id properties

eb6f727

adds property reference for certificate description

985809d

alvadb approved these changes Sep 30, 2017

View reviewed changes

alvadb merged commit 1a9d396 into Azure:current Sep 30, 2017

AutorestCI mentioned this pull request Sep 30, 2017

[IoT Hub] - X509CA support Azure/azure-sdk-for-python#1496

Closed

AutorestCI mentioned this pull request Sep 30, 2017

Automatic PR from RestAPI-PR1723 Azure/azure-sdk-for-ruby#1011

Closed

amarzavery reviewed Oct 2, 2017

View reviewed changes

andrew-buckley reviewed Oct 2, 2017

View reviewed changes

andrew-buckley mentioned this pull request Oct 4, 2017

Fixes typos, adds header specifications for etag and a few other options. No new API added here #1793

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IoT Hub - X509CA support #1723

IoT Hub - X509CA support #1723

mastermanu commented Sep 22, 2017 •

edited by azuresdkci

Loading

alvadb left a comment

alvadb Sep 22, 2017

mastermanu Sep 22, 2017

alvadb Sep 22, 2017

mastermanu Sep 22, 2017

alvadb Sep 22, 2017

mastermanu Sep 22, 2017

mastermanu commented Sep 22, 2017

ravbhatnagar commented Sep 26, 2017

azuresdkciprbot commented Sep 29, 2017

azuresdkciprbot commented Sep 29, 2017

AutorestCI commented Sep 30, 2017

AutorestCI commented Sep 30, 2017

AutorestCI commented Sep 30, 2017

amarzavery Oct 2, 2017

andrew-buckley Oct 2, 2017

andrew-buckley Oct 2, 2017 •

edited

Loading

andrew-buckley Oct 2, 2017

IoT Hub - X509CA support #1723

IoT Hub - X509CA support #1723

Conversation

mastermanu commented Sep 22, 2017 • edited by azuresdkci Loading

PR information

Quality of Swagger

alvadb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mastermanu commented Sep 22, 2017

ravbhatnagar commented Sep 26, 2017

azuresdkciprbot commented Sep 29, 2017

azuresdkciprbot commented Sep 29, 2017

AutorestCI commented Sep 30, 2017

AutorestCI commented Sep 30, 2017

AutorestCI commented Sep 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrew-buckley Oct 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mastermanu commented Sep 22, 2017 •

edited by azuresdkci

Loading

andrew-buckley Oct 2, 2017 •

edited

Loading