-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes typos, adds header specifications for etag and a few other options. No new API added here #1793
Conversation
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
This is related to #1723. These changes were discovered after the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part, just curious about the AutoRest issues.
@@ -887,7 +894,7 @@ | |||
"tags": [ "Certificates" ], | |||
"summary": "Get the certificate list.", | |||
"description": "Returns the list of certificates.", | |||
"operationId": "Certificates_ListByIoTHub", | |||
"operationId": "Certificates_ListByIotHub", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what issues did you notice with AutoRest due to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of funny. If we leave it how it was previously spelled, at least the python generator was giving me the function "list_by_io_thub", changing the casing properly gives me "list_by_iot_hub".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I think we are extracting words that start with a capitalized letter or grouping together capitalized letters into a single word, for most cases this is a viable solution while IoT
looks like an exception. I guess this is a preferred workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger