Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typos, adds header specifications for etag and a few other options. No new API added here #1793

Merged
merged 2 commits into from
Oct 4, 2017

Conversation

mastermanu
Copy link
Contributor

@mastermanu mastermanu commented Oct 4, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/iothub/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 17
After the PR: Warning(s): 0 Error(s): 17

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@andrew-buckley
Copy link

This is related to #1723. These changes were discovered after the merge.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, just curious about the AutoRest issues.

@@ -887,7 +894,7 @@
"tags": [ "Certificates" ],
"summary": "Get the certificate list.",
"description": "Returns the list of certificates.",
"operationId": "Certificates_ListByIoTHub",
"operationId": "Certificates_ListByIotHub",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what issues did you notice with AutoRest due to this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of funny. If we leave it how it was previously spelled, at least the python generator was giving me the function "list_by_io_thub", changing the casing properly gives me "list_by_iot_hub".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I think we are extracting words that start with a capitalized letter or grouping together capitalized letters into a single word, for most cases this is a viable solution while IoT looks like an exception. I guess this is a preferred workaround.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 9bc154a into Azure:current Oct 4, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants