-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2021-11-15-preview] Adding restorable apis to list restorables databases,collection and resources for tables and graphs. Also, added Latest restorable timestamp support for Graphs and Tables. #17418
[2021-11-15-preview] Adding restorable apis to list restorables databases,collection and resources for tables and graphs. Also, added Latest restorable timestamp support for Graphs and Tables. #17418
Conversation
…-10-15-preview to version 2021-11-15-preview
Hi, @amisi01 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4039 - ParametersOrder |
The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L38 |
R4039 - ParametersOrder |
The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L78 |
R4039 - ParametersOrder |
The parameters:mongoRoleDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L131 |
R4039 - ParametersOrder |
The parameters:mongoUserDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L219 |
R4039 - ParametersOrder |
The parameters:mongoUserDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L259 |
R4039 - ParametersOrder |
The parameters:mongoUserDefinitionId,resourceGroupName,accountName should be kept in the same order as they present in the path. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L312 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L9585 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/managedCassandra.json#L1458 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L424 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L431 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L542 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/restorable.json#L1590 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/services.json#L377 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/services.json#L411 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/services.json#L445 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.DocumentDB/preview/2021-11-15-preview/services.json#L475 |
Per the Noun_Verb convention for Operation Ids, the noun 'GraphResources' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L1568 |
|
'PUT' operation 'CassandraResources_UpdateCassandraViewThroughput' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L5617 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2021-11-15-preview/dataTransferService.json#L313 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2021-11-15-preview/managedCassandra.json#L1290 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L5667 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L5716 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'GraphResources_CreateUpdateGraph' Request Model: 'GraphResourceCreateUpdateParameters' Response Model: 'GraphResourceGetResults' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L1520 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'SqlResources_CreateUpdateClientEncryptionKey' Request Model: 'ClientEncryptionKeyCreateUpdateParameters' Response Model: 'ClientEncryptionKeyGetResults' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L2012 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'CassandraResources_CreateUpdateCassandraView' Request Model: 'CassandraViewCreateUpdateParameters' Response Model: 'CassandraViewGetResults' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L5486 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'CassandraResources_UpdateCassandraViewThroughput' Request Model: 'ThroughputSettingsUpdateParameters' Response Model: 'ThroughputSettingsGetResults' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L5616 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'MongoDBResources_CreateUpdateMongoRoleDefinition' Request Model: 'MongoRoleDefinitionCreateUpdateParameters' Response Model: 'MongoRoleDefinitionGetResults' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L78 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'MongoDBResources_CreateUpdateMongoUserDefinition' Request Model: 'MongoUserDefinitionCreateUpdateParameters' Response Model: 'MongoUserDefinitionGetResults' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/mongorbac.json#L259 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Service_Create' Request Model: 'ServiceResourceCreateUpdateParameters' Response Model: 'ServiceResource' Location: Microsoft.DocumentDB/preview/2021-11-15-preview/services.json#L80 |
|
OperationId should contain the verb: 'migratetoautoscale' in:'CassandraResources_MigrateCassandraViewToAutoscale'. Consider updating the operationId Location: Microsoft.DocumentDB/preview/2021-11-15-preview/cosmos-db.json#L5669 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/preview/2021-11-15-preview/privateEndpointConnection.json |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️
Cross-Version Breaking Changes: 3 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2021-11-15-preview/cosmos-db.json compared with base:stable/2021-10-15/cosmos-db.json
- current:preview/2021-11-15-preview/cosmos-db.json compared with base:preview/2021-10-15-preview/cosmos-db.json
- current:preview/2021-11-15-preview/dataTransferService.json compared with base:preview/2021-10-15-preview/dataTransferService.json
- current:preview/2021-11-15-preview/managedCassandra.json compared with base:stable/2021-10-15/managedCassandra.json
- current:preview/2021-11-15-preview/managedCassandra.json compared with base:preview/2021-10-15-preview/managedCassandra.json
- current:preview/2021-11-15-preview/mongorbac.json compared with base:preview/2021-10-15-preview/mongorbac.json
- current:preview/2021-11-15-preview/notebook.json compared with base:stable/2021-10-15/notebook.json
- current:preview/2021-11-15-preview/notebook.json compared with base:preview/2021-10-15-preview/notebook.json
- current:preview/2021-11-15-preview/privateEndpointConnection.json compared with base:stable/2021-10-15/privateEndpointConnection.json
- current:preview/2021-11-15-preview/privateEndpointConnection.json compared with base:preview/2021-10-15-preview/privateEndpointConnection.json
- current:preview/2021-11-15-preview/privateLinkResources.json compared with base:stable/2021-10-15/privateLinkResources.json
- current:preview/2021-11-15-preview/privateLinkResources.json compared with base:preview/2021-10-15-preview/privateLinkResources.json
- current:preview/2021-11-15-preview/rbac.json compared with base:stable/2021-10-15/rbac.json
- current:preview/2021-11-15-preview/rbac.json compared with base:preview/2021-10-15-preview/rbac.json
- current:preview/2021-11-15-preview/restorable.json compared with base:stable/2021-10-15/restorable.json
- current:preview/2021-11-15-preview/restorable.json compared with base:preview/2021-10-15-preview/restorable.json
- current:preview/2021-11-15-preview/services.json compared with base:preview/2021-10-15-preview/services.json
Rule | Message |
---|---|
The new version is removing enum value(s) 'AzureStorage' from the old version. New: Microsoft.DocumentDB/preview/2021-11-15-preview/dataTransferService.json#L175:9 Old: Microsoft.DocumentDB/preview/2021-10-15-preview/dataTransferService.json#L175:9 |
|
The new version is removing enum value(s) 'AzureStorage' from the old version. New: Microsoft.DocumentDB/preview/2021-11-15-preview/dataTransferService.json#L175:9 Old: Microsoft.DocumentDB/preview/2021-10-15-preview/dataTransferService.json#L175:9 |
|
The new version is removing enum value(s) 'AzureStorage' from the old version. New: Microsoft.DocumentDB/preview/2021-11-15-preview/dataTransferService.json#L175:9 Old: Microsoft.DocumentDB/preview/2021-10-15-preview/dataTransferService.json#L175:9 |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @amisi01, Your PR has some issues. Please fix the CI sequentially by following the order of
|
4f7f8c3
to
915cad2
Compare
…d resources for tables and graphs. 2. Added Latest restorable timestamp support for Graphs and Tables.
915cad2
to
1ee3281
Compare
Add SqlDataTransferDataSourceSink
Hi, @amisi01 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ArcturusZhang @qiaozha @msyyc could you help confirm the SDK breaking changes |
Hi @ArcturusZhang @qiaozha @msyyc |
8cfc925
to
6dd4519
Compare
…ases,collection and resources for tables and graphs. Also, added Latest restorable timestamp support for Graphs and Tables. (Azure#17418) * Adds base for updating Microsoft.DocumentDB from version preview/2021-10-15-preview to version 2021-11-15-preview * Updates readme * Updates API version in new specs and examples * 1. Adding restorable apis to list restorables databases,collection and resources for tables and graphs. 2. Added Latest restorable timestamp support for Graphs and Tables. * Add SqlDataTransferDataSourceSink * Fix AzureBlobStorage * Update TableResourceList Co-authored-by: Nitesh Vijay <niteshvijay1995@gmail.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.