Add UebaEntityProviders to EntityAnalyticsSettings #18196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @NoaGoren Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'PUT' operation 'ProductSettings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json#L176 |
|
| Based on the response model schema, operation 'ProductSettings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json#L38 |
|
| Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties. Location: Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json#L402 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json#L280 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json#L308 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2022-04-01-preview/Settings.json compared with base:preview/2022-01-01-preview/Settings.json
| Rule | Message |
|---|---|
| The new version is missing a property found in the old version. Was 'isEnabled' renamed or removed? New: Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json#L335:7 Old: Microsoft.SecurityInsights/preview/2022-01-01-preview/Settings.json#L335:7 |
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Mar 13, 2022
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @NoaGoren your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
No need for ARM review since this is not a new api version but an update to an existing so no ARM review is required. seems like a breaking change though so we sign off is required on that side. |
raosuhas
removed
the
WaitForARMFeedback
|
@raosuhas An ARM review is needed for this PR as it's for a new API version. We're working in an aggregative way in a develop branch so that we don't need a huge review with dozens of changes across different teams when we merge to main. This is the way we've been working with ARM for the last 3 versions and it was discussed before with several reviewers. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
pilor
reviewed
Mar 21, 2022
| @@ -333,14 +333,28 @@ | |||
| "EntityAnalyticsProperties": { | |||
| "description": "EntityAnalytics property bag.", | |||
| "properties": { | |||
| "isEnabled": { | |||
There was a problem hiding this comment.
removal of properties is seen as a breaking change and should get flagged as a breaking change when this goes to main if this property existed in the previous API version. You'll have to go through the breaking change process outlined in the PR description and talk to those folks if you need to remove the boolean.
pilor
added
ARMSignedOff
dw511214992
approved these changes
Mar 22, 2022
dw511214992
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Adds base for updating Microsoft.SecurityInsights from version preview/2022-01-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * Fix ThreatInteliignece accordig to latest preview for alignment (#18231) * Add UebaEntityProviders to EntityAnalyticsSettings (#18196) * Add UebaEntityProviders to EntityAnalyticsSettings * remove ueba * Added additionalProperties to itemsKeyValue to resolve autorest issues (#18170) * added additionalProperties to itemsKeyValue to resolve autorest issues * Update Watchlists.json * ran prettier-fix * Remove readonly property from ownerType (#18450) Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com> Co-authored-by: NoaGoren <37895830+NoaGoren@users.noreply.github.com> Co-authored-by: ushasan <69323982+ushasan@users.noreply.github.com>
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Adds base for updating Microsoft.SecurityInsights from version preview/2022-01-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * Fix ThreatInteliignece accordig to latest preview for alignment (Azure#18231) * Add UebaEntityProviders to EntityAnalyticsSettings (Azure#18196) * Add UebaEntityProviders to EntityAnalyticsSettings * remove ueba * Added additionalProperties to itemsKeyValue to resolve autorest issues (Azure#18170) * added additionalProperties to itemsKeyValue to resolve autorest issues * Update Watchlists.json * ran prettier-fix * Remove readonly property from ownerType (Azure#18450) Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com> Co-authored-by: NoaGoren <37895830+NoaGoren@users.noreply.github.com> Co-authored-by: ushasan <69323982+ushasan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.