Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UebaEntityProviders to EntityAnalyticsSettings #18196

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Add UebaEntityProviders to EntityAnalyticsSettings #18196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d58172
Add UebaEntityProviders to EntityAnalyticsSettings
NoaGoren Mar 13, 2022
8edbe56
remove ueba
NoaGoren Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ...ghts/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,14 +333,28 @@
"EntityAnalyticsProperties": {
"description": "EntityAnalytics property bag.",
"properties": {
"isEnabled": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removal of properties is seen as a breaking change and should get flagged as a breaking change when this goes to main if this property existed in the previous API version. You'll have to go through the breaking change process outlined in the PR description and talk to those folks if you need to remove the boolean.

"description": "Determines whether the setting is enable or disabled.",
"readOnly": true,
"type": "boolean"
"entityProviders": {
"description": "The relevant entity providers that are synced",
"items": {
"$ref": "#/definitions/EntityProviders"
},
"type": "array"
}
},
"type": "object"
},
"EntityProviders": {
"description": "The entity provider that is synced.",
"enum": [
"ActiveDirectory",
"AzureActiveDirectory"
],
"type": "string",
"x-ms-enum": {
"modelAsString": true,
"name": "EntityProviders"
}
},
"Ueba": {
"allOf": [
{
Expand Down