Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corect duplicate parent references in timeseriesinsights@2018-08-15-preview #19010

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Corect duplicate parent references in timeseriesinsights@2018-08-15-preview #19010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1e7cb4
Corect duplicate parent references in timeseriesinsights@2018-08-15-p…
jeskew May 10, 2022
0002a16
Remove invalid x-ms-discriminator-value extensions
jeskew May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...e-manager/Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,9 +1612,6 @@
},
{
"$ref": "#/definitions/EnvironmentResourceProperties"
},
{
"$ref": "#/definitions/ResourceProperties"
Comment on lines -1615 to -1617
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
],
"required": [
Expand Down Expand Up @@ -1648,9 +1645,6 @@
"allOf": [
{
"$ref": "#/definitions/EnvironmentResourceProperties"
},
{
"$ref": "#/definitions/ResourceProperties"
}
],
"description": "Properties of the long-term environment."
Expand Down Expand Up @@ -1908,7 +1902,6 @@
},
"EventHubEventSourceUpdateParameters": {
"type": "object",
"x-ms-discriminator-value": "Microsoft.EventHub",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wary of this change, but this should be ok. The parent EventSourceUpdateParameters doesn't have a descriminator field, and we indeed do not support changing the event source kind via PATCH.

"properties": {
"properties": {
"x-ms-client-flatten": true,
Expand All @@ -1924,7 +1917,6 @@
"description": "Parameters supplied to the Update Event Source operation to update an EventHub event source."
},
"IoTHubEventSourceUpdateParameters": {
"x-ms-discriminator-value": "Microsoft.IoTHub",
"type": "object",
"properties": {
"properties": {
Expand Down