Minor changes due to update of the DevOps API version (2022-02-01-preview) #19165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @msdogra Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'devOpsAuditingSettingsName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json#L75 |
|
| 'devOpsAuditingSettingsName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json#L125 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2022-02-01-preview/ServerDevOpsAudit.json compared with base:preview/2021-11-01-preview/ServerDevOpsAudit.json
| Rule | Message |
|---|---|
| The 'constant' status changed from the old version to the new. New: Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json#L75:11 Old: Microsoft.Sql/preview/2021-11-01-preview/ServerDevOpsAudit.json#L75:11 |
|
| The 'constant' status changed from the old version to the new. New: Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json#L125:11 Old: Microsoft.Sql/preview/2021-11-01-preview/ServerDevOpsAudit.json#L119:11 |
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
ghost
added
the
|
Hi @msdogra, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 20, 2022
ericshape
approved these changes
May 20, 2022
|
please update other example files with the new defined enum string |
|
@xiaoxuqi-ms can you help to merge to the dev branch? Thanks! |
xiaoxuqi-ms
approved these changes
May 24, 2022
ericshape
pushed a commit
to ericshape/azure-rest-api-specs
that referenced
this pull request
May 31, 2022
…view) (Azure#19165) * Incorporating changes due to API review comment incorporation * Fixing the Enum case mismatch Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>
ericshape
pushed a commit
to ericshape/azure-rest-api-specs
that referenced
this pull request
May 31, 2022
…view) (Azure#19165) * Incorporating changes due to API review comment incorporation * Fixing the Enum case mismatch Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
June 2022
June 2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.