Minor changes due to update of the DevOps API version (2022-02-01-pre…

…view) (Azure#19165) * Incorporating changes due to API review comment incorporation * Fixing the Enum case mismatch Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>
ericshape · May 31, 2022 · b509ea0 · b509ea0
1 parent 17297f9
commit b509ea0
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 16 deletions.
diff --git a/...tion/sql/resource-manager/Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json b/...tion/sql/resource-manager/Microsoft.Sql/preview/2022-02-01-preview/ServerDevOpsAudit.json
@@ -53,7 +53,7 @@
         },
         "x-ms-examples": {
           "List DevOps audit settings of a server": {
-            "$ref": "./examples/ServerDevOpsAuditSettingsList.json"
+            "$ref": "./examples/ServerDevOpsAuditList.json"
           }
         }
       }
@@ -75,9 +75,15 @@
           {
             "name": "devOpsAuditingSettingsName",
             "in": "path",
-            "description": "The name of the devops audit settings. This should always be 'default'.",
             "required": true,
-            "type": "string"
+            "type": "string",
+            "enum": [
+              "Default"
+            ],
+            "x-ms-enum": {
+              "name": "DevOpsAuditingSettingsName",
+              "modelAsString": true
+            }
           },
           {
             "$ref": "../../../common/v1/types.json#/parameters/SubscriptionIdParameter"
@@ -119,9 +125,15 @@
           {
             "name": "devOpsAuditingSettingsName",
             "in": "path",
-            "description": "The name of the devops audit settings. This should always be 'default'.",
             "required": true,
-            "type": "string"
+            "type": "string",
+            "enum": [
+              "Default"
+            ],
+            "x-ms-enum": {
+              "name": "DevOpsAuditingSettingsName",
+              "modelAsString": true
+            }
           },
           {
             "name": "parameters",

diff --git a/...manager/Microsoft.Sql/preview/2022-02-01-preview/examples/ServerDevOpsAuditCreateMax.json b/...manager/Microsoft.Sql/preview/2022-02-01-preview/examples/ServerDevOpsAuditCreateMax.json
@@ -3,12 +3,12 @@
     "subscriptionId": "00000000-1111-2222-3333-444444444444",
     "resourceGroupName": "devAuditTestRG",
     "serverName": "devOpsAuditTestSvr",
-    "devOpsAuditingSettingsName": "default",
+    "devOpsAuditingSettingsName": "Default",
     "api-version": "2022-02-01-preview",
     "parameters": {
       "properties": {
         "state": "Enabled",
-        "storageAccountAccessKey": "sdlfkjabc+sdlfkjsdlkfsjdfLDKFTERLKFDFKLjsdfksjdflsdkfD2342309432849328476458/3RSD==",
+        "storageAccountAccessKey": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
         "storageEndpoint": "https://mystorage.blob.core.windows.net",
         "storageAccountSubscriptionId": "00000000-1234-0000-5678-000000000000",
         "isAzureMonitorTargetEnabled": true
@@ -19,7 +19,7 @@
     "200": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/devAuditTestRG/providers/Microsoft.Sql/servers/devOpsAuditTestSvr/devOpsAuditingSettings/default",
-        "name": "default",
+        "name": "Default",
         "type": "Microsoft.Sql/servers/devOpsAuditingSettings",
         "properties": {
           "state": "Enabled",
@@ -30,7 +30,7 @@
       }
     },
     "202": {
-      "startTime": "2020-09-22T09:34:54.72Z",
+      "startTime": "2022-04-22T09:34:54.72Z",
       "operation": "UpsertServerDevOpsAuditingSettings"
     }
   }

diff --git a/...manager/Microsoft.Sql/preview/2022-02-01-preview/examples/ServerDevOpsAuditCreateMin.json b/...manager/Microsoft.Sql/preview/2022-02-01-preview/examples/ServerDevOpsAuditCreateMin.json
@@ -3,12 +3,12 @@
     "subscriptionId": "00000000-1111-2222-3333-444444444444",
     "resourceGroupName": "devAuditTestRG",
     "serverName": "devOpsAuditTestSvr",
-    "devOpsAuditingSettingsName": "default",
+    "devOpsAuditingSettingsName": "Default",
     "api-version": "2022-02-01-preview",
     "parameters": {
       "properties": {
         "state": "Enabled",
-        "storageAccountAccessKey": "sdlfkjabc+sdlfkjsdlkfsjdfLDKFTERLKFDFKLjsdfksjdflsdkfD2342309432849328476458/3RSD==",
+        "storageAccountAccessKey": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
         "storageEndpoint": "https://mystorage.blob.core.windows.net"
       }
     }
@@ -17,7 +17,7 @@
     "200": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/devAuditTestRG/providers/Microsoft.Sql/servers/devOpsAuditTestSvr/devOpsAuditingSettings/default",
-        "name": "default",
+        "name": "Default",
         "type": "Microsoft.Sql/servers/devOpsAuditingSettings",
         "properties": {
           "state": "Enabled",
@@ -27,7 +27,7 @@
       }
     },
     "202": {
-      "startTime": "2020-09-09T09:34:54.72Z",
+      "startTime": "2022-04-09T09:34:54.72Z",
       "operation": "UpsertServerDevOpsAuditingSettings"
     }
   }

diff --git a/...ource-manager/Microsoft.Sql/preview/2022-02-01-preview/examples/ServerDevOpsAuditGet.json b/...ource-manager/Microsoft.Sql/preview/2022-02-01-preview/examples/ServerDevOpsAuditGet.json
@@ -3,14 +3,14 @@
     "subscriptionId": "00000000-1111-2222-3333-444444444444",
     "resourceGroupName": "devAuditTestRG",
     "serverName": "devOpsAuditTestSvr",
-    "devOpsAuditingSettingsName": "default",
+    "devOpsAuditingSettingsName": "Default",
     "api-version": "2022-02-01-preview"
   },
   "responses": {
     "200": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/devAuditTestRG/providers/Microsoft.Sql/servers/devOpsAuditTestSvr/devOpsAuditingSettings/default",
-        "name": "default",
+        "name": "Default",
         "type": "Microsoft.Sql/servers/devOpsAuditingSettings",
         "properties": {
           "state": "Disabled",

diff --git a/...amples/ServerDevOpsAuditSettingsList.json → ...eview/examples/ServerDevOpsAuditList.json b/...amples/ServerDevOpsAuditSettingsList.json → ...eview/examples/ServerDevOpsAuditList.json
@@ -11,7 +11,7 @@
         "value": [
           {
             "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/devAuditTestRG/providers/Microsoft.Sql/servers/devOpsAuditTestSvr/devOpsAuditingSettings/default",
-            "name": "default",
+            "name": "Default",
             "type": "Microsoft.Sql/servers/devOpsAuditingSettings",
             "properties": {
               "state": "Disabled",