Updated ExplicitProxySettings to ExplicitProxy on Firewall Policy ver… #19299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Gizachew-Eshetie Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'PUT' operation 'FirewallPolicyIdpsSignaturesOverrides_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L740 |
|
| 'PATCH' operation 'FirewallPolicyIdpsSignaturesOverrides_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L685 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L2111 |
|
| Based on the response model schema, operation 'FirewallPolicyIdpsSignaturesOverrides_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L894 |
|
| OperationId should contain the verb: 'listidpssignatures' in:'FirewallPolicyIdpsSignatures_List'. Consider updating the operationId Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L630 |
|
| OperationId should contain the verb: 'listidpsfilteroptions' in:'FirewallPolicyIdpsSignaturesFilterValues_List'. Consider updating the operationId Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L840 |
|
| 'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L651 |
|
| 'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L844 |
|
| 'SingleQueryResult' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L1984 |
|
| 'Signatures' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L2074 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: query signature overrides Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L886 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: get signature overrides Location: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L933 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 2 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-01-01/firewallPolicy.json compared with base:stable/2021-08-01/firewallPolicy.json
| Rule | Message |
|---|---|
|
The new version is missing a definition that was found in the old version. Was 'ExplicitProxySettings' removed or renamed? New: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L941:3 Old: Microsoft.Network/stable/2021-08-01/firewallPolicy.json#L941:3 |
|
The new version is missing a property found in the old version. Was 'explicitProxySettings' renamed or removed? New: Microsoft.Network/stable/2022-01-01/firewallPolicy.json#L969:7 Old: Microsoft.Network/stable/2021-08-01/firewallPolicy.json#L969:7 |
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 1, 2022
raych1
approved these changes
Jun 10, 2022
lirenhe
pushed a commit
that referenced
this pull request
Jun 23, 2022
* Adds base for updating Microsoft.Network from version stable/2021-08-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * Updated Explicit proxy settings by adding one boolean field to it (#19011) * API for provider port (#19041) * Update readme.md * Create expressRouteProviderPort.json * Create expressRouteProviderPortList.json * Create expressRouteProviderPort.json * Update custom-words.txt * Update expressRouteProviderPort.json * Update expressRouteProviderPortList.json * Update expressRouteProviderPort.json * Add WAF match variable operators (#18925) ### webapplicationfirewall.json * Add GreaterThanOrEquals operator and Any operator to custom rule match conditions in WAF policy spec * Add VirtualHub Router autoscale configuration (#19131) Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> * Adding rule priority to Tls Proxy routing rule object model (#19135) Co-authored-by: Vinay Mundada <vimundad@microsoft.com> * swagger changes for new ssl policies (#19183) * Update Swagger Spec for VMSS Packet Capture (#19202) * Update Swagger Spec for VMSS Packet Capture * Remove extra line * Update Swagger spec for Connection Monitor VMSS (#19203) * Adding new endpoint in ConnectionMonitor * Changing ConnectionMonitor endpoints order * Add flushConnection to NSG (#19085) * Merge NetworkManger into 2022-01-01 (#19169) * Merge NetworkManger into 2022-01-01 * Remove EffectiveVnet APIs * Remove SecurityUser Resource * update readme * Fix as comments * fix as comments * remove network group type * Add new parameter noInternetAdvertise to CustomIPPrefix (#19340) * fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com> * Route Server Integration feature swagger changes (#19215) * Route Server Integration feature swagger changes * prettier run changes * updating api version in examples file * fixing test errors * fixing test errors * fixing modelvalidation errors * fixing test errors * fixing modelvalidation errors * changes based on review comments * fixing lintdiff failure * updating examples * update wrong enum value for customipprefix (#19382) * fix * fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com> * Updated ExplicitProxySettings to ExplicitProxy on Firewall Policy ver2022-01-01 (#19299) Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com> * Add resource type (#19434) Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> * Fix prettier errors (#19462) Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> Co-authored-by: uditmisra52 <103006702+uditmisra52@users.noreply.github.com> Co-authored-by: jashsing-mic <79445297+jashsing-mic@users.noreply.github.com> Co-authored-by: Anurag Kishore <kishore.1337.anurag@gmail.com> Co-authored-by: AndriiKalinichenko <kalinichenkoandrew@gmail.com> Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com> Co-authored-by: Vinay Jayant Mundada <vinaymundada27@gmail.com> Co-authored-by: Vinay Mundada <vimundad@microsoft.com> Co-authored-by: kaushik-ms <103559254+kaushik-ms@users.noreply.github.com> Co-authored-by: snagpal99 <95475229+snagpal99@users.noreply.github.com> Co-authored-by: kumaam <102141910+kumaam@users.noreply.github.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> Co-authored-by: yanfa317 <53584318+yanfa317@users.noreply.github.com> Co-authored-by: Weiheng Li <weihengli.tj@gmail.com> Co-authored-by: Weiheng Li <weihl@microsoft.com> Co-authored-by: Anchal Kapoor <ankapoo@microsoft.com> Co-authored-by: Gizachew-Eshetie <gizchanie@gmail.com> Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.