Mitryakh/network 2022 01 01 #19412
Merged
Mitryakh/network 2022 01 01 #19412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2022-01-01
* Update readme.md * Create expressRouteProviderPort.json * Create expressRouteProviderPortList.json * Create expressRouteProviderPort.json * Update custom-words.txt * Update expressRouteProviderPort.json * Update expressRouteProviderPortList.json * Update expressRouteProviderPort.json
### webapplicationfirewall.json * Add GreaterThanOrEquals operator and Any operator to custom rule match conditions in WAF policy spec
Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>
Co-authored-by: Vinay Mundada <vimundad@microsoft.com>
* Update Swagger Spec for VMSS Packet Capture * Remove extra line
* Adding new endpoint in ConnectionMonitor * Changing ConnectionMonitor endpoints order
* Merge NetworkManger into 2022-01-01 * Remove EffectiveVnet APIs * Remove SecurityUser Resource * update readme * Fix as comments * fix as comments * remove network group type
* fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com>
* Route Server Integration feature swagger changes * prettier run changes * updating api version in examples file * fixing test errors * fixing test errors * fixing modelvalidation errors * fixing test errors * fixing modelvalidation errors * changes based on review comments * fixing lintdiff failure * updating examples
* fix * fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com>
…2022-01-01 (#19299) Co-authored-by: Gizachew Eshetie <v-geshetie@microsoft.com>
|
Hi, @MikhailTryakhov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
1 similar comment
|
Hi, @MikhailTryakhov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
|
Hi, @MikhailTryakhov your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
1 similar comment
|
Hi, @MikhailTryakhov your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
MikhailTryakhov
removed
WaitForARMFeedback
|
No need for ARM review due to this PR contains ~10 PRs which were already reviewed and approved by ARM |
Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>
|
@lirenhe is that all to be merged? Actually can you please approve, but not merge yet, due to the manifest update still going on, we need to wait until June, 25 |
There are still code style errors, and for the cross version breaking change, @raych1 , i didn't see the breaking change approved in #19299, is this expected? |
@MikhailTryakhov, there are code style issues reported in, can someone from your team to fix it? |
|
@AndriiKalinichenko can you please help with examples code style fixes? https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#prettier-check - how to fix. |
Co-authored-by: Andrii Kalinichenko <ankalini@microsoft.com>
|
@lirenhe what do you think about PR now? :) |
|
Hi @MikhailTryakhov, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@MikhailTryakhov , the cross version breaking change introduced in this PR need to get approval from breaking change review board. As the PR was merged, can you get breaking change approval for this PR? |
|
That's a work for a creator of this PR My strong recommendation: if we have breaking changes introduce in the PR like that, we'll need to request this approval reviewing that, not on this stage... |
I totally agree on this though it's missed in the original PR. |
JeffreyRichter
added
the
Approved-BreakingChange
lirenhe
approved these changes
Jun 23, 2022
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monthly release of Azure Networking for new api version 2022-01-01
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.