[Cognitive Services - Health Insights] CADL revision for public preview #22990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @asaflevi-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| 2023-03-01-preview | 2023-03-01-preview(257253b) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L104 |
|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L234 |
|
|
Property 'jobId' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1560 |
|
|
Property 'createdDateTime' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1560 |
|
|
Property 'expirationDateTime' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1560 |
|
|
Property 'lastUpdateDateTime' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1560 |
|
|
Property 'status' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1560 |
|
|
Property 'jobId' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1916 |
|
|
Property 'createdDateTime' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1916 |
|
|
Property 'expirationDateTime' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1916 |
|
|
Property 'lastUpdateDateTime' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1916 |
|
|
Property 'status' is a required property. It should not be marked as 'readonly' Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1916 |
|
| Security definition should have a description. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L43 |
||
Operations with a 202 response should specify x-ms-long-running-operation: true.Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L59 |
||
| header parameter name 'Repeatability-Request-ID' should be kebab case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L70 |
||
| Parameter should have a description. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L76 |
||
| The body parameter is not marked as required. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L76 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L149 |
||
Operations with a 202 response should specify x-ms-long-running-operation: true.Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L189 |
||
| header parameter name 'Repeatability-Request-ID' should be kebab case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L200 |
||
| Parameter should have a description. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L206 |
||
| The body parameter is not marked as required. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L206 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L279 |
||
| Schema should have a description or title. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L380 |
||
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L440 |
||
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L476 |
||
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L489 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1266 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1511 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1516 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 8 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Following response status codes 200 for operation OncoPhenotype_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L85:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulOncoPhenotypeRequest.json#L52:16 |
|
Following response status codes 200 for operation OncoPhenotype_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L85:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulOncoPhenotypeRequest.json#L52:16 |
|
Following response status codes 200 for operation TrialMatcher_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L215:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulTrialMatcherRequest.json#L149:16 |
|
Following response status codes 200 for operation TrialMatcher_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L215:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulTrialMatcherRequest.json#L149:16 |
|
Following response status codes 200 for operation OncoPhenotype_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L85:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulOncoPhenotypeRequest.json#L52:16 |
|
Following response status codes 200 for operation OncoPhenotype_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L85:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulOncoPhenotypeRequest.json#L52:16 |
|
Following response status codes 200 for operation TrialMatcher_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L215:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulTrialMatcherRequest.json#L149:16 |
|
Following response status codes 200 for operation TrialMatcher_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L215:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulTrialMatcherRequest.json#L149:16 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
ghost
added
the
Generated ApiView
|
|
CC: @catalinaperalta |
AzureRestAPISpecReview
added
Cadl
|
Hi @asaflevi-ms, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
|
Hi @asaflevi-ms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
There was a problem hiding this comment.
Files look the same as the PR that was approved by the stewardship board: https://github.com/Azure/azure-rest-api-specs-pr/pull/10411#pullrequestreview-1307536569
specification/cognitiveservices/HealthInsights/cadl-project.yaml
Outdated
Show resolved
Hide resolved
specification/cognitiveservices/HealthInsights/cadl-project.yaml
Outdated
Show resolved
Hide resolved
specification/cognitiveservices/HealthInsights/cancer-profiling-client.cadl
Outdated
Show resolved
Hide resolved
...nitiveservices/HealthInsights/examples/2023-03-01-preview/SuccessfulTrialMatcherRequest.json
Outdated
Show resolved
Hide resolved
specification/cognitiveservices/HealthInsights/models/model.common.shared.cadl
Outdated
Show resolved
Hide resolved
specification/cognitiveservices/HealthInsights/models/model.oncophenotype.cadl
Outdated
Show resolved
Hide resolved
Comment on lines
16
to
17
| Foundations.RetryAfterHeader & | ||
| RepeatabilityResponseHeaders> | TResponse, |
There was a problem hiding this comment.
Same as the other PR, still have some doubts about whether retry after and repeatability response headers should be defined in the template like this or whether they should be passed in a per operation basis as traits. @johanste to weigh in. @asaflevi-ms mentioned that defining the template like this works to represent the service accurately, but passing these headers as traits doesnt add them in the response.
There was a problem hiding this comment.
This is not blocking though, the TypeSpec definition can be updated after the first preview.
specification/cognitiveservices/HealthInsights/routes/route.oncophenotype.cadl
Outdated
Show resolved
Hide resolved
specification/cognitiveservices/data-plane/HealthInsights/readme.md
Outdated
Show resolved
Hide resolved
…s-cadl-split-packages Asaflevi/feature/healthinsights cadl split packages
This was referenced Mar 14, 2023
weshaggard
reviewed
Mar 15, 2023
specification/cognitiveservices/HealthInsights/healthinsights.autorest/cadl-project.yaml
Outdated
Show resolved
Hide resolved
* convert cadl to typespec * update generated openapi spec
…thub.com/asaflevi-ms/azure-rest-api-specs into asaflevi/feature/healthinsights-typespec
lmazuel
approved these changes
Mar 22, 2023
nrafalowski
added a commit
to nrafalowski/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
commit c94569d116a82ee11a94c5dfb190650dd675a1bf
Author: Marina Bashtovaya <7862114+mbashtovaya@users.noreply.github.com>
Date: Wed Mar 22 02:35:49 2023 -0400
NetworkCloud 2022-12-12-preview API corrections (#23086)
* first public preview version for NetworkCloud APIs
* added custom words
* added required attribute to payloads to correct aaz-dev-tool CLI generation
* corrected console patch API payload
* removed invalid child resources list by subscription APIs
commit d0ad5741faee68f00504bf66e22691d90e63589d
Author: Scott Taladay <997923+staladay@users.noreply.github.com>
Date: Tue Mar 21 22:51:13 2023 -0700
[Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2023-02-28 (#22837)
* Adds base for updating Microsoft.HealthcareApis from version stable/2022-12-01 to version 2023-02-28
* Updates readme
* Updates API version in new specs and examples
* Adding "crossTenantCmkApplicationId" property with a new API version and new examples for data sovereign regions.
* Fixing some issues based on automatic validator feedback.
* Removed extra space causing model validation failures.
* Added Azure App ID validation regex for crossTenantCmkApplicationId string property.
commit d42de0c5e72cfaf5e0049c89940ba00f6ac9815c
Author: Jiayi <14067510+jiayi11@users.noreply.github.com>
Date: Tue Mar 21 22:09:06 2023 -0700
Microsoft.AppConfiguration: Add new 2023-03-01 version (#22788)
* Adds base for updating Microsoft.AppConfiguration from version stable/2022-05-01 to version 2023-03-01
* Updates readme
* Updates API version in new specs and examples
* Add new APIs in 2023-03-01
* Delete annotations.json
* Delete assets.json
* Update readme.test.md
* Update basic.yaml
---------
Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>
commit 9c9786a53eb85f49b77f274fb5baf666ef9f6a30
Author: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Date: Wed Mar 22 10:58:20 2023 +0800
Review request for Microsoft.ContainerService/aks to add version 2023-02-01 & 2023-02-02preview (#23189)
* release 2023-02-01 & 2023-02-02-preview
* patch changes to previous API versions
commit cd2b76ce38029e1425ee024cd9403a908c60d71e
Author: Antonio Hernandez <99060535+AntonioHernandez16@users.noreply.github.com>
Date: Tue Mar 21 19:26:31 2023 -0700
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2022-09-01 (#23054)
* Adds base for updating Microsoft.Consumption from version stable/2021-10-01 to version 2022-09-01
* Updates readme
* Updates API version in new specs and examples
* adding new API version (September Copper) to Swagger
* fixing prettier check
commit 4496ceb36cfeff7443f3570274c437acd72a5ded
Author: Aravind Bharatha <bharathaaravind@gmail.com>
Date: Tue Mar 21 22:25:52 2023 -0400
[Hub Generated] Review request for Microsoft.Help to add version preview/2023-01-01-preview (#23056)
* Generate new Service for help
* init commit microsoft.help-2023-01-01-preview
* Updating swagger documentation #1
* Updating swagger documentation #2
* Adding suppressions for Help 2023-01-01-preview api
* Adding suppressions for Help 2023-01-01-preview api #2
* removed unnecessary files
* update examples
commit f76d810c973a3dd4ee6938eba0beae3d4799c48c
Author: MichaelMSWork <126775490+MichaelMSWork@users.noreply.github.com>
Date: Wed Mar 22 04:17:24 2023 +0200
[Hub Generated] Review request for Microsoft.SaaS to add version preview/2018-03-01-beta (#22911)
approved with false breaking change
commit b1806afc5064a18eca79fa14137bccc94937f88f
Author: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Date: Tue Mar 21 18:46:41 2023 -0700
make path and body positional (#23185)
commit aa3618d1bd4b18cdbd308b1572c68393beaca9a6
Author: Asaf Levi <100200009+asaflevi-ms@users.noreply.github.com>
Date: Wed Mar 22 03:09:22 2023 +0200
[Cognitive Services - Health Insights] CADL revision for public preview (#22990)
* health insights cadl + generated openapi spec
* fix PR Comments
* change country to countryOrRegion
* split to multiple cadl projects
* update cadl-project.yaml files
* update example with generic contact details
* update samples with generic contacts
* convert cadl to typespec
* update generated openapi spec
* convert cadl to typespec (#4)
* convert cadl to typespec
* update generated openapi spec
* move ClinicalNoteEvidence to common modules
* remove redundant imports
* fix typespec dependencies
* remove dependencies from main.tsp
* using rest
* move imports from service.tsp to its caller
* fix comment - directive error
* remove imports from service.tsp
commit 806d1616c2ce4c0a93fda266bd020903733ac326
Author: allison-inman <70279908+allison-inman@users.noreply.github.com>
Date: Tue Mar 21 17:58:06 2023 -0700
[Hub Generated] Review request for Microsoft.Quota to add version stable/2023-02-01 (#22367)
* Adds base for updating Microsoft.Quota from version preview/2021-03-15-preview to version 2023-02-01
* Updates readme
* Updates API version in new specs and examples
* Fix version in readme
* Remove stale version, update readme
* Mark parameter as optional
commit 543f1920ac96303cc244d60e1c12f0b56fc646db
Author: Paul Hsu <paulhsu@microsoft.com>
Date: Wed Mar 22 00:40:48 2023 +0800
Add 2023-02-28-preview. (#23093)
* Add 2023-02-28-preview.
* Update cSpell.json
commit 969fd0c2634fbcc1975d7abe3749330a5145a97c
Author: Shannon Hicks <93622349+shanhix1@users.noreply.github.com>
Date: Mon Mar 20 20:30:14 2023 -0700
Edit description of properties.provisioningState (#23146)
commit 94e1f43b5c2b1d43716624f0d1dcc77161f2c2a9
Author: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Date: Tue Mar 21 11:07:30 2023 +0800
Update custom words (#23034)
commit 85fb4ac6f8bfefd179e6c2632976a154b5c9ff04
Author: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Date: Tue Mar 21 10:43:44 2023 +0800
[Go] paloaltonnetworks readme.go.md config (#23187)
commit ddcde53422ff186f5b69fb32338ecac3d11c3bca
Author: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com>
Date: Mon Mar 20 18:48:53 2023 -0700
Make failover group status type object to fix resource sync (#23058)
* Make status object to fix resource sync
* Remove trailing comma
* Move changes to 2023-03-15-preview
---------
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
commit 6272a882add762c6b55338da5c45a0537b812d9b
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date: Mon Mar 20 13:38:46 2023 -0500
add data-plane ServiceBus swagger to main (#23057)
* add back sb swagger
* update api version param defintion
* update api version num
* prettier
* spellcheck/readme
* readme/lint
* suppress x-ms-examples not found err
commit 0080664dbdee831fb21fc817e2acd434fd0fd146
Author: Ismael Navarro-Fuentes <107213645+ismael-ms@users.noreply.github.com>
Date: Mon Mar 20 10:24:44 2023 -0700
Fixes for Features APIs' descriptions (#23001)
* Remove ontology from API descriptions and clarify that properties are defined in the collection definition API
* Specify GET Collection Definition
* Add missing descriptions
* Add more missing descriptions
* Change 'Response' to 'Result'
* Fix casing of descriptions
commit 314d792ae3b61131b33f22e644d059b227af85e8
Author: Jorge Cotillo <jcotillo@microsoft.com>
Date: Mon Mar 20 05:14:47 2023 -0700
OperationalInsights fix missing enum value (#23123)
commit 3fb19df9ee39171e411cbd28af0cf5ac743d143e
Author: prchalla1 <111384538+prchalla1@users.noreply.github.com>
Date: Sun Mar 19 23:59:42 2023 -0700
To add Update Cost Details Field Link in GenerateCostDetailsReport (#23137)
commit ce64ee97437c0af59515e38bc86b45ffedfb1334
Author: Rahul Singh <53578268+rahuls-microsoft@users.noreply.github.com>
Date: Sun Mar 19 23:11:36 2023 -0700
Updating example for Linter Errors. (#23174)
Co-authored-by: Rahul Singh <rahul.station99@gmail.com>
commit 933dbc070dda85e2d115dc42893f07b2ed5b74f6
Author: guptashweta9 <115149822+guptashweta9@users.noreply.github.com>
Date: Mon Mar 20 11:23:51 2023 +0530
G3 G4 SKU removal (#23099)
commit 4c843d69ebb62a67fe430330ae0ff42bf8ae89a1
Author: chcmsft <86343602+chcmsft@users.noreply.github.com>
Date: Mon Mar 20 13:35:51 2023 +0800
update description of geocoding api (#23101)
commit 6999a987a54bd6e1895c3abc9da7637503cb56e7
Author: Xiaogang <xidi@microsoft.com>
Date: Mon Mar 20 10:21:30 2023 +0800
Enable Azure PowerShell CI for liftrqumulo (#22862)
commit b3a9eb662c17cbfc2ae5b7614ea66512bb5022c5
Author: matthohn-msft <89162957+matthohn-msft@users.noreply.github.com>
Date: Sun Mar 19 18:42:51 2023 -0700
[Hub Generated] Review request for Microsoft.Communication to add version preview/2023-03-01-preview (#22996)
* Adds base for updating Microsoft.Communication from version preview/2021-10-01-preview to version 2023-03-01-preview
* Updates readme
* Updates API version in new specs and examples
* Adding version 2023-03-01-preview changes.
* Adding missing readme.md update
* Addressing PR comments.
* Updating to v5 common types
* Incorporating comments from the stable version PR
* Updating description for the provisioning state enum
* Fixing model validation errors
* Removing redundant systemData property.
* Adding 201 response to indicate resource was create successfully
commit 72664c83300dfaf6782e22822a5aae0b0df92735
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Mar 17 13:05:54 2023 -0700
[Language Text] Delete Dynamic Classification from v2022-10-01-preview (#23080)
* [Language Text] Delete Dynamic Classification from v2022-10-01-preview
* remove from dev
commit a42a3d01a056f02e345685f311961a18d5862cd1
Author: minnieliu <minnieliu96@hotmail.com>
Date: Fri Mar 17 11:40:18 2023 -0700
Feature/room api2023 (#22540)
* Modify file for the new patch participants API
* Participant endpoint changes for Rooms Api
Introduce JMP for particpant collection.
* Fix directory structure
* Copy examples from previous version
* update examples
* Update swagger json and examples
* Updated ParticipantsCollection property to use value instead participant and modified its descriptions
* Update rooms json examples according to new changes (#22495)
* Update rooms json examples according to new changes
* Address pipeline validation errors
* Address pipeline validation errors
* Address pipeline validation errors
* revert readme
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Update participant collection (#22498)
* Updated Participant Collection Property to use value in place of participant. Updated API sample
* Updated Rooms_GetParticipants sample
* Ran Prettier
* [Rooms] Removed roomJoinPolicy and renamed RoleType to Role (#22494)
* Added Title Property to RoomModel, CreateRoomRequest, UpdateRoomRequest
* Revert "Added Title Property to RoomModel, CreateRoomRequest, UpdateRoomRequest"
This reverts commit 48e46b0eac97bc5c29f7b782ddeb9c869948499c.
* Added title property to RoomModel, CreateRoomRequest, UpdateRoomRequest (#22513)
* Revert all changes in the 2022-02-01 swagger (#22539)
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Revert all changes in the 2022-02-01 swagger
* Add required request body for patch room (#22589)
* Add required request body for patch room
* Update update room example
* Fix validation checks
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Update authorization description and remove format in Endpoint (#22609)
* Update authorization description
* Remove format in endpoint to align with other ACS services
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Updated Rooms API Specification Per Internal Review (#22608)
* Updated Room API Spec per internal review
* Fixed Validation Check Failures
* Fixed Validation Failures on role type
* Updated default values descriptions
* Updated Readme with new API version
* Clean up and fix communication error in spec (#22621)
* Clean up and fix communication error in spec
* Fix example version
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Removed Room Title Per Internal Review (#22640)
* Add a new participant model with role as optional (#22641)
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* createdAt name change (#22651)
* Remove Rooms 2023-01-01 version to clean up (#22676)
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Remove bad examples (#22682)
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Update current feature branch with the changes from DevEx review (#22859)
* Update current feature branch with the changes from DevEx review
* Update samples
* Merge patch samples
* fix
* Missed comment from devex review
* Missed comment from devex review
* fix grammar
* fix grammar
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Sort models in alphabetical order (#22886)
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Add new get rooms list API (#22936)
* Update format of repeatability-first-sent (#22968)
* Update format of repeatability-first-sent
* Update in correct version
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Update readme file to include previous version (#23002)
* Update readme file to include previous version
* Fix room ids
* nit changes to list rooms API
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Update API Specification per preparation for ARB
* Fix nit
* Renamed Particpants_Patch to Participants_Update
* Fix validation errors
* Create Room should take a map of participants (#23090)
* Create Room should take a map of participants
* Fix Room Id example
---------
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
* Fix validFrom and validUntil exampls
* Add period to descriptions
* Update description
* Update description for create room participants
---------
Co-authored-by: HuangXin-MS <94944762+HuangXin-MS@users.noreply.github.com>
Co-authored-by: anujissarMS <anujissar@microsoft.com>
Co-authored-by: Mike Hang <108955604+mikehang-msft@users.noreply.github.com>
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
Co-authored-by: Mrayyan <t-siddiquim@microsoft.com>
commit fce14bf881523f16b14d8ecf325e004465cdcf56
Author: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Date: Fri Mar 17 11:42:30 2023 +0800
[Go] newrelic config readme.go.md (#23148)
commit 6dbf5dc1c2894ed15293b40495ac4776fdb2ebce
Author: Tom FitzMacken <4007949+tfitzmac@users.noreply.github.com>
Date: Thu Mar 16 18:23:57 2023 -0700
clarify when reserved is required (#22860)
commit 231b725bd2c8fce13c5341e34f7a6329c460dc94
Author: Sena Gungor <senatol@users.noreply.github.com>
Date: Fri Mar 17 04:06:36 2023 +0300
Update operation ids (#23100)
commit a5c02f03ec242a2acef309bbdfd4734c100f1839
Author: croos-msft <117782481+croos-msft@users.noreply.github.com>
Date: Thu Mar 16 11:06:07 2023 -0700
Add Supporting Windows Docker Container Hosted API Services (#22587)
* Add windowsdatacontainer and pipeline changes
* Add pipeline changes
* Fix hardcoded brnch
* Copy git file to whichever Dockerfile path is being used
* Remove changes to data-container pipeline
* Setup windows pipeline
* Update with correct ps1 location
* Fix issues with dockerfile
* Use Windows-styled folders
* Add logic to replace base image
* Add base_image_windows
* Correctly refer to Dockerfile
* Enclose in quotation marks
* Only use servercore:ltsc2022
commit daeb320057bd56a88379c377d934150ef48d143f
Author: Ralf Beckers <bexxx@users.noreply.github.com>
Date: Thu Mar 16 17:31:56 2023 +0100
Add support for ChatGPT to Azure OpenAI authoring APIs (#23076)
* Add old api version as base for new
* Added changes for new version
* Fix reference in readme
commit 27983ba0a242e18b9f7cbb6f654f82e3ed471045
Author: Ralf Beckers <bexxx@users.noreply.github.com>
Date: Thu Mar 16 17:31:20 2023 +0100
Add support for ChatGPT (chats/completion) for Azure OpenAI (#23074)
* Added old spec under new location as base
* Add chat completion API to inference specs
* Add custom word
* Fixed model name and product name
commit 7f5ff3f2011f2f8019ff5db4b6cc00a128c01eb5
Author: ofermoses <87987228+ofermoses@users.noreply.github.com>
Date: Thu Mar 16 10:32:40 2023 +0200
removing mcas from examples in MDC settings api docs as intergration is being deprecated. (#23072)
no changes to actual API client, just docs
Co-authored-by: mosesofer@microsoft.com <mosesofer@microsoft.com>
commit f4d602920b38b342c93141fcfe42fa27d0b216c2
Author: giakas <giakas@microsoft.com>
Date: Thu Mar 16 00:22:40 2023 -0700
Adding a custom tag with older streaming for C#SDK (#23126)
commit 63ec6d9ea3bed80da29f70e5ab27c0b58d07a2ab
Author: anjaliOra <anjalisharma.rsnr@gmail.com>
Date: Thu Mar 16 00:07:00 2023 -0700
[Hub Generated] Publish private branch 'datafactory/anjshar/adfNewSwaggerUpdateForIR' (#23122)
* [AutoSync] ecc97ae10f new process private swagger update
* [AutoSync] 45ff9fdbbb moving additionalProps out of props
* [AutoSync] 0287001cba adding identifier
---------
Co-authored-by: swagger-automation <swagger@microsoft.com>
commit 9565a97e3efbeb3691c9100d5473b0a884c1b786
Author: Tim Lovell-Smith <tilovell@microsoft.com>
Date: Wed Mar 15 22:26:14 2023 -0700
Refactor cache swagger to deduplicate SkuName enum definitions. (#23049)
commit 51b8f2084b05e705baf30f24ea0a40a346e2c5a5
Author: Crystal YU <chunyu@microsoft.com>
Date: Thu Mar 16 11:37:32 2023 +0800
upgrade openapi to typespec library 0.41.0 (#23038)
* upgrade openapi to tyepspec library 0.41.0
* add typespec as custom word
* update package.json
commit 75376d385724a046204f53baccc6fa1bbfdbe73b
Author: Crystal YU <chunyu@microsoft.com>
Date: Thu Mar 16 11:20:14 2023 +0800
upgrade AnomalyDetector to use typespec library 0.41.0 (#23036)
* upgrade AnomalyDetector to use typespec library 0.41
* updated package.json
* remove un-used python emitter dependency
commit 8e7fbe5d8c0e33f99ad365951485107a0ad8a181
Author: jha1bhavna <122248715+jha1bhavna@users.noreply.github.com>
Date: Thu Mar 16 08:34:39 2023 +0530
Adding None as allowed values for TLS (#22949)
commit ebd66fc9cadab5c3165b8610d47e3e863edec13a
Author: himasekhar-ms <124761034+himasekhar-ms@users.noreply.github.com>
Date: Thu Mar 16 08:21:47 2023 +0530
Himasekhar ms mediaservices microsoft.media 2023 01 01 (#22557)
* Adds base for updating Microsoft.Media/Metadata from version stable/2022-08-01 to version 2023-01-01
* Updates readme
* Updates API version in new specs and examples
* Adding new version 2023-01-01 for metadata APIs which includes ecryption scope support in Assets create API
* Updating AssetsAndAssetFilters manifest with new property encryptionScope and adding new test case for asset create with encryption scope
* Fixed text alignment issues in the example file
* Adding new example file in AssetsAndAssetFilters
* Add missing swagger files and update tag name
* Fixing the path for the Swagger file
* Updating stemingService version to 2022-01-01
* Updating stemingService version to 2022-08-01
* Reverting the StremingServive API version changes
* fix the test readMe file
* fix the test readMe input file version
---------
Co-authored-by: giakas <giakas@microsoft.com>
commit ee157d6bbf6e4c4fdc8a47b380e00ddd56a0e852
Author: Oliver Towers <olivert@microsoft.com>
Date: Wed Mar 15 01:41:16 2023 -0700
[Hub Generated] Review request for Microsoft.DocumentDB to add version preview/2023-03-01-preview (#23081)
* Adds base for updating Microsoft.DocumentDB from version preview/2022-11-15-preview to version 2023-03-01-preview
* Updates readme
* Updates API version in new specs and examples
* Apply 2023-03-01-preview addditions
* Apply mongocluster additions
* Minor changes.
* Fixes fo go and Lintdiff/descriptions.
* Add back canceled provisioningState
commit 5342f4101b09fc87f595b980bb4bb59f8d143027
Author: Moshe Malka <moshemal@gmail.com>
Date: Wed Mar 15 09:27:05 2023 +0200
[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2023-03-01 (#22284)
* Adds base for updating Microsoft.AlertsManagement from version preview/2021-07-22-preview to version 2023-03-01
* Updates readme
* Updates API version in new specs and examples
* adding PrometheusRuleGroups stable api-version
* rename example titles
* improve descriptions
* improve examples
* fix lintdiff errors
* add pattern to rule name
* fix pattern
* remove validations
* add recomandations
* change actions
* change to last acions property version
* run prettier
* fix PR review comments
---------
Co-authored-by: Moshe Malka <momalka@microsoft.com>
commit c72a972a6d4fa9e64bb62653e996155379292ebf
Author: Matthew Christopher <matthchr@users.noreply.github.com>
Date: Tue Mar 14 23:29:05 2023 -0700
Update Microsoft.Sql ARM API with "format: arm-id" where appropriate and x-ms-secret where appropriate (#22677)
* SQL ARM IDs
* Secrets
* Examples fix
* Fix examples
commit 4ede5fdef83563cfd08b1017ade793cb4e089057
Author: Naman Agarwal <namanag16@gmail.com>
Date: Wed Mar 15 11:33:19 2023 +0530
[Stable Oct GA] Bring back Scheduled Shutdown MLC models (#23069)
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
commit 7e5861ad01a796a72617080e89e42f428e66242e
Author: Chris Huang <huangc@microsoft.com>
Date: Tue Mar 14 21:37:19 2023 -0700
[Hub Generated] Review request for Microsoft.Devices to add version preview/2022-11-15-preview (#22067)
* Adds base for updating Microsoft.Devices from version preview/2022-04-30-preview to version 2022-11-15-preview
* Updates readme
* Updates API version in new specs and examples
* Huangc 2022 11 15 preview (#22110)
* update iothub example with ipversion and new api version of 2022-11-15-preview
* fix validation
* fix with adding location into lro header
* update manual failover json with adding azure-AsyncOperation
* remove location to see if pass the check
* fix
* fix
* fix
* fix with adding location
* Adding Azure-AsyncOperation to manualfailover
* test fix
* quick style fix for 2019-03-22
* update 2022-11-15-preview MF example
commit 9afbd00d619f4443ba50848f77c9b6237ba76d15
Author: Samuel Kuang <samuk@microsoft.com>
Date: Tue Mar 14 20:42:46 2023 -0700
Merge release sentinel 2023 03 01 preview (#22983)
* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-03-01-preview
* Updates readme
* Updates API version in new specs and examples
* Update description of AAD (#22508)
* Update description of AAD
AAD should be AADIP to prevent mistakes from customer
* Add custom word AADIP
AADIP = Azure Active Directory Identity Protection
* Remove bing phishing feed msti connector (#22706)
* remove bing phishing feed from msti connector
* revert to release-Sentinel-2023-03-01-preview
* fixes
* fixed validation issues
* renamed example file
* added response status codes for examples
* Automation rules - 2023-03-01-preview - add entity trigger API (#22523)
* adjust version order
* Fix cross-version breaking changes.
Fix cross-version breaking changes.
* Pull in metadata changes from stable version.
* Update Metadata.json
* Update Incidents.json
add readonly flag for providerIncidentId.
* Update readme.md
GuidUsage AutoRest-Linter suppression.
* Update readme.md
suppress GuidUsage
* Update readme.md
Correct suppression.
* Update readme.md
Fix suppression.
---------
Co-authored-by: shschwar <55053268+shschwar@users.noreply.github.com>
Co-authored-by: aviyerMSFT <87452453+aviyerMSFT@users.noreply.github.com>
Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com>
commit 5bf60a6746bc03fbff78cc68595eb11f2f212d19
Author: Dor Siso <60354892+dosiso@users.noreply.github.com>
Date: Wed Mar 15 04:28:59 2023 +0200
Limit top incidents resource types (#22790)
* Add blockchain to latest profile
* Add additional types
* Limit incidents list resource type maximum results
* Fix format
---------
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
commit ac29c822ecd5f6054cd17c46839e7c04a1114c6d
Author: apattath <avin.pattath.318@gmail.com>
Date: Tue Mar 14 17:45:00 2023 -0700
Azure Communication Services Email API for GA (#22979)
* Copy existing preview version of CommunicationServicesEmail API to stable folder in preparation for GA
* update version to 2023-03-31
* update comment about events for 202 result
* update readme file
* updated description of Operation-ID header
commit a05c36a524b42600bbdbbeddc8e3527f7d424351
Author: Alex Karcher <alkarche@microsoft.com>
Date: Tue Mar 14 17:08:04 2023 -0700
Updating Microsoft.Web api to remove duplicate workflowState definition (#23083)
* Merging upstream/main
* Updated flowState to be a reference
* Removing conflict
* Revert "Removing conflict"
This reverts commit 7029fe8d55fa49997bfdeb99160a64a4f1c24e66.
* Revert "Merging upstream/main"
This reverts commit d60a048ccee93685c11e53b623ed17bd1da77325.
commit adbce0f14768da2404217860a8d35f9aeb16388e
Author: AmirGeorge <amgeo@microsoft.com>
Date: Tue Mar 14 20:19:45 2023 +0200
Adding changes for Language Authoring 2023-04-01 to dev folder (#22396)
* Adding changes for Language Authoring 2023-04-01 to dev folder
* removing examples of features not shipping in GA
* fixes
---------
Co-authored-by: Amir George <amir.george.microsoft@gmail.com>
commit 5a49823c43b422e5f3b0ec2ce8846d84cfe7c149
Author: Gaurav Kumar <gakum@microsoft.com>
Date: Tue Mar 14 18:27:33 2023 +0530
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 (#22492)
* Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01
* Updates readme
* Updates API version in new specs and examples
* Adding Restore Settings
commit f858b937d0f921a9d008a1d03ab74c3fc4378470
Author: gulopesd <73562152+gulopesd@users.noreply.github.com>
Date: Tue Mar 14 00:03:53 2023 -0700
Edit description of orderBy (#22807)
commit 100f2b143b144287dbfd11dd2615c36070fbd1fe
Author: grchris-microsoft <76813672+grchris-microsoft@users.noreply.github.com>
Date: Tue Mar 14 09:02:02 2023 +0200
[Hub Generated] Review request for Microsoft.Insights to add version preview/2023-01-01-preview (#22575)
* Adds base for updating Microsoft.Insights from version stable/2020-10-01 to version 2023-01-01-preview
* Updates readme
* Updates API version in new specs and examples
* added tenant scope in the new ALA api version
* updated tenant level service health rule example
* fixed linter errors
* added "actionProperties" to the api and examples
* fix prettier. added object types. typo fix
---------
Co-authored-by: Gregory Chris <sgchris@gmail.com>
commit a54263176acce91199a19333d6c4717367a3317e
Author: saviesacov <96383178+saviesacov@users.noreply.github.com>
Date: Tue Mar 14 08:06:59 2023 +0200
Marketplace version 2023-01-01 (#22527)
* init version 2023-01-01
* GetPrivateStoreOffersWithSubscriptions
* readme package-2023-01-01
* add flatten
* renaming
* add x-ms-pageable
* CollectionOffersByContext returns OfferProperties
* minor fix
* mapOffersToContexts
commit d4dfb3388ab40185cf302512268ad1406f666d64
Author: pednekarpraj <72415888+pednekarpraj@users.noreply.github.com>
Date: Mon Mar 13 19:37:10 2023 -0700
Update eTag property description (#23059)
commit 9f339d469c0fe83466edfe295a7960c82ebecf4f
Author: Carlos Oviedo <88506033+carlosov-ms@users.noreply.github.com>
Date: Mon Mar 13 18:49:38 2023 -0500
[Hub Generated] Publish private branch 'dev-graphservicesprod-Microsoft.GraphServices-2022-09-22-preview' (#23000)
* add or modify files
* Update graphservicesprod.json
Bring changes from https://github.com/Azure/azure-rest-api-specs-pr/pull/9502/files.
---------
Co-authored-by: Xiaofei Cao <92354331+XiaofeiCao@users.noreply.github.com>
commit ae3714515dfa35d3a65fc27df6b8a6835d996db1
Author: Drew McDaniel <drewm@microsoft.com>
Date: Mon Mar 13 14:57:14 2023 -0700
Updating notification for Compute (#23018)
commit 6b921fdde7c1806efca2b5aa41ca46ec65f3092e
Author: pansharm-ms <106319348+pansharm-ms@users.noreply.github.com>
Date: Mon Mar 13 21:55:10 2023 +0530
Add PDS GA APIs. (#23010)
* Add PDS GA APIs.
* Fix timespan.
* Correct examples.
commit 9e17eb2d475e8908277d929b0e4a4c582e2ba752
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Mon Mar 13 19:33:21 2023 +0800
update (#22981)
commit 0e13373c80d638f9e0370877aee0ffe5c3101f5d
Author: Roger Nhan <110417948+rnhan@users.noreply.github.com>
Date: Mon Mar 13 04:45:55 2023 -0400
[Hub Generated] Publish private branch 'main' (#23015)
* Onboard Microsoft.ContainerStorage with API version 2023-03-01-preview
* Revert accidental change to elasticsan readme
commit 4b4bb1021353692578499f43f1aa912964a2b7e2
Author: zdelacerda-microsoft <90284189+zdelacerda-microsoft@users.noreply.github.com>
Date: Mon Mar 13 01:06:14 2023 -0700
[Hub Generated] Publish private branch 'imagebuilder/master' (#22901)
* [AutoSync] a35dd0d71 Merged PR 6495219: Release swagger changes through shift left
* [AutoSync] 2a3c8eafa Merged PR 7671495: Merge from develop to master to start ABI release
* Update custom-words.txt
adding "DistributeVersioner" to custom-words doc
---------
Co-authored-by: swagger-automation <swagger@microsoft.com>
commit ba9f30eed00b61ebb1ceedecd65a8ce82c81609b
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Mon Mar 13 12:57:40 2023 +0800
Update readme.python.md (#23033)
commit 9665feff0ab62918a35e19f1c82187397ec81705
Author: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com>
Date: Mon Mar 13 10:20:29 2023 +0530
{AzureServiceFabric} fixes Azure/azure-rest-api-specs#22806 The ClusterVersion API redirects to invalid link (#22868)
"description": "The Service Fabric runtime version of the cluster. This property can only by set the user when upgradeMode is set to 'Manual'. To get list of available Service Fabric versions for new clusters use [ClusterVersion API](https://github.com/Azure/azure-rest-api-specs/issues/ClusterVersion.md)"
The link goes to ./ClusterVersion.md which does not exist. This actually causes dead links in the official MS documentation, e.g. [here](https://learn.microsoft.com/en-us/rest/api/servicefabric/clusters/list?tabs=HTTP#cluster).
commit ee96574a6d4ed37a06883b8e3f8fd3adf4803b83
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Mon Mar 13 11:46:12 2023 +0800
Update readme.python.md (#23031)
commit 17f5f0659c4b395863f1b7752d1bd6a0771a06dd
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Mon Mar 13 11:45:42 2023 +0800
Update readme.python.md (#23032)
commit 0fbb9e53310d0e919a11777765f6d4631d192ae2
Author: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com>
Date: Sun Mar 12 20:05:53 2023 -0700
[Hub Generated] Publish private branch 'kim-soohwan-keyvault-mhsm-Microsoft.KeyVault-2023-02-01' (#22625)
* Adds base for updating Microsoft.KeyVault from version stable/2022-11-01 to version 2023-02-01
* Updates readme
* Updates API version in new specs and examples
* Updated readme files
* Updated location headers to current examples for MHSM async operations
* Adding georeplication support for Managed HSM
* Added new isPrimary property to MHSM Regions
---------
Co-authored-by: Soohwan Kim <sookim@microsoft.com>
commit 44cc617c7dd775f221f4e0fb4dda58ff739a40cb
Author: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com>
Date: Mon Mar 13 07:45:37 2023 +0530
{AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required (#22874)
* {AzureNetwork} fixes Azure/azure-rest-api-specs#22448 Making priority required
fixes #22448
[This is the API](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0) I invoked.
For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Intrestingly the Azure
Request Body:
```
{
"properties": {
"securityRules": [
{
"name": "rule1",
"properties": {
"protocol": "*",
"sourceAddressPrefix": "*",
"destinationAddressPrefix": "*",
"access": "Allow",
"destinationPortRange": "80",
"sourcePortRange": "*",
"direction": "Inbound"
}
}
]
},
"location": "eastus"
}
```
Response received:
```
{
"error": {
"code": "SecurityRuleInvalidPriority",
"message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.",
"details": []
}
}
```
This PR will make the priority parameter as required.
* Update NetworkSecurityGroupRuleDelete.json
Long running operation should return `azure-AsyncOperation` in response header.
* Update NetworkSecurityGroupDelete.json
Long running operation should return location or azure-AsyncOperation in header.
* Update NetworkSecurityGroupRuleDelete.json
* Update NetworkSecurityGroupDelete.json
* Update NetworkSecurityGroupRuleDelete.json
* Update NetworkSecurityGroupDelete.json
commit cacbca520a479632528f3493a7950fa347da9f52
Author: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com>
Date: Mon Mar 13 07:45:04 2023 +0530
{AzureNetwork} fixes Azure/azure-rest-api-specs#20256 Fix for applicationGatewayIpConfigurations, property (#22875)
fixes #20256
This swagger definition is defining property applicationGatewayIpConfigurations,
```
"applicationGatewayIpConfigurations": {
"type": "array",
"items": {
"$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration"
},
"description": "Application gateway IP configurations of virtual network resource."
}
```
but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case.
```
{
"name": "subnet-agw",
"id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw",
"properties": {
"applicationGatewayIPConfigurations": [
{
"id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig"
}
]
},
"type": "Microsoft.Network/virtualNetworks/subnets"
}
```
Please update correspondingly.
commit 95fb710c0025b325306898a3210333eaaf5d5e62
Author: shesamian <107954668+shesamian@users.noreply.github.com>
Date: Sun Mar 12 17:41:44 2023 -0700
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2023-02-01 (#22930)
* Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01
* Updates readme
* Updates API version in new specs and examples
* Added 2023-02-01 changes
commit 10c740b7224771c889cfb92f128168f5a0568c26
Author: xiaoxu qi <xiaoxuqi@microsoft.com>
Date: Fri Mar 10 16:57:42 2023 +0800
Reorganize 2021-12-01-preview into sub service folder (#22988)
* split into sub service folder
* fix model validation
* fix validation
* fix LRO in stable version
* fix
commit 571e783ddaa6f898d0984829bee07feee713d14c
Author: Tianen <v-tianxi@microsoft.com>
Date: Fri Mar 10 16:04:00 2023 +0800
Delete GitHub Action (#23004)
* Update specificationRepositoryConfiguration.json
* delete github action code directlly
* revert specificationRepositoryConfiguration.json
---------
Co-authored-by: Wei Dong <40835867+dw511214992@users.noreply.github.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Co-authored-by: Tianxiang Chen <403562789@qq.com>
commit a2e2617050e68ae1c445db565076c5a7f42ebad4
Author: Roni <roni9311@gmail.com>
Date: Fri Mar 10 09:31:28 2023 +0200
[Hub Generated] Publish private branch 'roni93-security-Microsoft.Security-2023-02-01-preview' (#23005)
* Adds base for updating Microsoft.Security from version preview/2022-11-20-preview to version 2023-02-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add health reports API
* Fix words and urls
* Fix spaces
* revert change
* fixes
* Fixes
* fixes
* Remove operations
* Add subscription Id
* revert change
* revert change
* Fixes after CR
* Change end point scope
* Fix CR
* Fix after CR
* Update exmaples
* Add to readme
* Fixed after CR
* Fixes after CR
* Fix typo
* change back to id
---------
Co-authored-by: Roni Zhelenchuk <rzhelenchuk@microsoft.com>
commit c9a6e0a98a51ebc0c7a346f4fd425ba185f44b31
Author: Tianen <v-tianxi@microsoft.com>
Date: Fri Mar 10 14:39:33 2023 +0800
Stop GitHub Action Running (#23003)
* Update specificationRepositoryConfiguration.json
* delete schedule config
* revert specificationRepositoryConfiguration.json
---------
Co-authored-by: Wei Dong <40835867+dw511214992@users.noreply.github.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Co-authored-by: Tianxiang Chen <403562789@qq.com>
commit 644e559292ea3314c1636285f138b8696536b006
Author: Alfredo Santamaria <chino.sebastian@gmail.com>
Date: Thu Mar 9 19:01:03 2023 -0800
Service Fabric Managed Clusters - api version 2023-02-01-preview (#22752)
* initital commit copy from 2022-10-01-preview
* update definitions with new api version
* update examples
* add new api version to readme and fix shared gallery example
* add missing x-ms-error-response
* add enableNodePublicIP
* remove unnecessary status codes 404 and 400
---------
Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
commit 65d3b5ecda664c318d2ad011c790ad2d6086ed93
Author: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Date: Fri Mar 10 10:48:46 2023 +0800
Update comment.yml (#22661)
commit dfd2eb9b16d96559b97dbc53bb32597611133796
Author: dav5liao <98427802+dav5liao@users.noreply.github.com>
Date: Thu Mar 9 18:43:47 2023 -0800
Dav5liao azurearcdata microsoft.azure arc data 2023 03 15 preview (#22982)
* Adds base for updating Microsoft.AzureArcData from version preview/2023-01-15-preview to version 2023-03-15-preview
* Updates readme
* Updates API version in new specs and examples
* Copied from azure-rest-api-specs-pr branchRPSaaSMaster
* required fix.
commit c6a658f01e1f73dbdaef43fe5055ceaca1b60a93
Author: ZhidaLiu <zhili@microsoft.com>
Date: Thu Mar 9 18:34:36 2023 -0800
Update SoftDelete/FeatureStore changes to MachineLearningService 2023-02-01-preview (#22998)
* Add soft delete and FeatureStore support for new api version
* remove unused property
* fix format
commit 8f45069999e606869d5817252b89a7513e868db9
Author: zhenbiao wei <424401670@qq.com>
Date: Fri Mar 10 10:16:40 2023 +0800
Update readme.python.md (#22989)
* Update readme.python.md
* Update readme.python.md
---------
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
commit a498cae6d1a93f4c33073f0747b93b22815c09b7
Author: Marina Bashtovaya <7862114+mbashtovaya@users.noreply.github.com>
Date: Thu Mar 9 19:40:26 2023 -0500
NetworkCloud 2022-12-12-preview add approved preview corrections (#22820)
* first public preview version for NetworkCloud APIs
* added custom words
* added required attribute to payloads to correct aaz-dev-tool CLI generation
* corrected console patch API payload
commit 3de956a007e6b8629617b8968409311253927947
Author: Sena Gungor <senatol@users.noreply.github.com>
Date: Thu Mar 9 16:15:29 2023 +0300
Update descriptions for Microsoft.DBforPostgreSQL for version stable/2022-11-08 (#22955)
* Update descriptions
* Update descriptions & fix cluster names in examples
* Update domain names & fix config, pec, operation descriptions
* Update create configuration operation ids
* Add reference link for storage and vCores
* Add missing dot in description
* Change configuration operation id
* Remove unnecessary property in examples, fix reference link for compute
* Fix readme error
* Revert breaking operationId changes
* Remove suppress rule
---------
Co-authored-by: Ozan Saka <mesaka@microsoft.com>
commit d82babc9bd0fa25260d04e52d841c2a6f59792c8
Author: meirloichter <96380538+meirloichter@users.noreply.github.com>
Date: Thu Mar 9 09:50:36 2023 +0200
[S360 fix] Add details field to ErrorResponse (#22910)
merge with breaking change approved
commit add28efcd3a5fd422285d992fb1ec5ee5a7a40a6
Author: Karishma Daga <karishmadaga@microsoft.com>
Date: Wed Mar 8 21:29:51 2023 -0800
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2023-02-01-preview (#22436)
* Adds base for updating Microsoft.MachineLearningServices from version preview/2022-12-01-preview to version 2023-02-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add managedResourceGroupTags to registries Feb 2023 Preview swagger (#22617)
* removed feb2023 registries.json
* Revert "removed feb2023 registries.json"
This reverts commit d2d1f7055e00284ba040cf0b792404956fb89c24.
* add managedResourceGroupTags property
---------
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
* updating to feb 2023 preview (#22456)
* updating to feb 2023 preview
* adding example files
* add to custom words, remove spelling errors
* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* resolving model validation errors
* try resolving operation async response validation errors
* merge data container/ver, queue settings
* add datacontainer and version example files, add LRO uri
* update example jobs files, update LRO and registry name pattern
* last LRO fixes
* test that batchdeploymentproperties is resolved
* adding maulik's swagger generation PR changes
* update swagger with new deduped batch names
* adding updated computeresource name
* add boolean featuredatatype
---------
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* ManagedNetwork Support and paramter parttern update for WorkspaceRP (#22588)
* add swagger support for managed network
* update parameter pattern
* Add rules
* remove unused file
* fix
* fix format and add pattern
* update format and example
* revert manage network changes
* small change
* revert
* Staging Branch Gate Fixes and Schema Bug Fix for ModelPackage (#22784)
* updating to feb 2023 preview
* adding example files
* add to custom words, remove spelling errors
* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* Update specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-02-01-preview/mfe.json
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
* resolving model validation errors
* try resolving operation async response validation errors
* merge data container/ver, queue settings
* add datacontainer and version example files, add LRO uri
* update example jobs files, update LRO and registry name pattern
* last LRO fixes
* test that batchdeploymentproperties is resolved
* adding maulik's swagger generation PR changes
* update swagger with new deduped batch names
* adding updated computeresource name
* add boolean featuredatatype
* fixing model validation pattern error
* fix LRO gate
* adding model package updates to swagger
* un requiring property
---------
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
---------
Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com>
Co-authored-by: Komal Yadav <komalyadav@microsoft.com>
Co-authored-by: Jianye Xi <59603451+jianyexi@users.noreply.github.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
commit 1745efa6229fa8ed63ad0ec2dfb5141e37afecac
Author: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com>
Date: Thu Mar 9 10:10:53 2023 +0530
{AzurePostgreSQL} fixes Azure/azure-rest-api-specs#22851 Data encryption type enum should be SystemManaged (#22943)
merged with breaking change approved.
commit 2048c7db421a8e92839f0fccfaf683b60eed9a20
Author: pednekarpraj <72415888+pednekarpraj@users.noreply.github.com>
Date: Wed Mar 8 19:44:28 2023 -0800
Fix linter error R4001 (#22973)
commit 93fbd7d8554d2bb504f85daf4c5b6b87db4abb54
Author: Vibhuti-Sharma-Microsoft <vibsharm@microsoft.com>
Date: Thu Mar 9 08:04:13 2023 +0530
Added pan specifications (#22878)
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Discussed with @Vibhuti-Sharma-Microsoft The operation ID will be fixed in subsequent change, since this version of swagger has already been merged in `azure-rest-api-specs-pr`.
commit f6ca660f317033a6ae2057962305a40f616e27f6
Author: yuc-Li <58678302+yuc-Li@users.noreply.github.com>
Date: Wed Mar 8 19:51:04 2023 +0800
{HDInsight} Fix S360 Swagger Linter items - Error R2010 (#22813)
* Fix Swagger Linter - 1
* Fix Swagger Linter - 2
* Fix Swagger Linter - 3
* Fix Swagger Linter - 4
* Update Location Value - HDInsight
* Add "resourceGroups/rg1/" to 17 Location value
* Update Location value
Not confirmed but upgraded
* Update pathToOperationResult to operationid
---------
Co-authored-by: v-yuchenli <v-yuchenli@microsoft.com>
commit 7d313ecb6a58a51046a3916ee5ea6b6d29973522
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Wed Mar 8 16:33:32 2023 +0800
update (#22965)
commit 4f4044394791773e6e7e82a9bd90d3935caaca1b
Author: Jorge Herrera <69991673+herreraj-ms@users.noreply.github.com>
Date: Tue Mar 7 21:56:27 2023 -0800
[Hub Generated] Review request for Microsoft.Insights to add version stable/2022-06-01 (#22619)
* Base from version 2021-09-01-preview
* adding 2022-06-01 for DCR, DCRA, and DCE
* readme MD changes
* fix examples
* fix provisioning value list
* deduplication for csharp track2
* custom-words
* dedupe
* modelerfour
* undo readme changes
* add new package in readme.md
* fix readme.md
* revert readme.md
* add new package
commit 120c2910613641e64e4a4bdf2dcf0cd5af9c7664
Author: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Date: Wed Mar 8 11:24:30 2023 +0800
update typescript.md for graphservices (#22964)
commit d7558574049caf673720e446ddeab49d0ed8d8c1
Author: Samir Solanki <samirsolanki@outlook.com>
Date: Tue Mar 7 17:40:49 2023 -0800
odata fixes for ApiWikis and ProductWikis Api (#22854)
* odata fixes
* add skip query
* apim doc for filter
* documentation
commit 1e7b408f3323e7f5424745718fe62c7a043a2337
Author: Ray Chen <raychen@microsoft.com>
Date: Wed Mar 8 07:52:21 2023 +0800
Updated pipeline related PR assignment (#22945)
commit 68aa92c941547dffe3e0d980a529cdc8688faff3
Author: Jimmy Campbell <jimmyca@microsoft.com>
Date: Tue Mar 7 10:15:52 2023 -0800
Update snapshot status selector to take multiple statuses. (#22805)
* Update snapshot status selector to take multiple statuses.
* Update snapshot status search to be an array.
* Name updates.
* Use capital like 'After' parameter.
commit 92f0949e7d41e69d612c4a9f0d006b5facb84c05
Author: Julia Gong <113055677+juliagongms@users.noreply.github.com>
Date: Tue Mar 7 09:15:32 2023 -0800
fix tags, description, and api model (#22958)
commit df54c612a18e376b1bc2ddb7dc12cb31d2a1c149
Author: yifan-zhou922 <78060542+yifan-zhou922@users.noreply.github.com>
Date: Tue Mar 7 23:18:58 2023 +0800
Upstream/release purview azure.analytics.purview.catalog 2022 08 01 preview (#21770)
* update 2022-08-01-preview
* Update purviewcatalog.json
* remove get lineage by unique attribute
* Update readme.md
* Add search example
* Revert "remove get lineage by unique attribute"
This reverts commit d8ea3cddc6d874634aa8e4939799528bf2818c5a.
* Update purviewcatalog.json
* Update purviewcatalog.json
* Fix bizMetadata sample issue
* Update readme.md
* fix error
* remove change in 2022-03-01
* Update purviewcatalog.json
* Update purviewcatalog.json
* update example
* update examples
* Update purviewcatalog.json
* Update missing query parameter
* update query parameter & response header
* update lineage examples
* update example
* add collection id & add createdBy for glossaryBaseObject
* update description
* add examples
* update examples
* update additionalProperties to solve invalid type model validation error
* fix model validation error
* fix model validation error
* update description
* Update description
* Update Entity_GetEntitiesByUniqueAttributes.json
* Update query parameter for test
* Update purviewcatalog.json
* Revert "Update purviewcatalog.json"
This reverts commit 6995728d6c3d957d269f1f3c71ff461687c37c81.
* Update Entity_GetEntitiesByUniqueAttributes.json
* Revert "Update query parameter for test"
This reverts commit 21a6f72d4724ed9a15cf645f2a5990b5985ae70e.
* Update purviewcatalog.json
* remove additionalProperties for partial update
* Update purviewcatalog.json
* Update purviewcatalog.json
* Update purviewcatalog.json
* Update purviewcatalog.json
* Update purviewcatalog.json
* Update purviewcatalog.json
* Update purviewcatalog.json
* update from main branch
* Update readme.md
* update api contract according to suggestions
* Update purviewcatalog.json
* update examples
* update description
* Update purviewcatalog.json
* Update purviewcatalog.json
---------
Co-authored-by: Allen Liang <liangliang@microsoft.com>
commit 860d9538f338475d45db9921ea954e8562687bda
Author: shono <31944140+shonohs@users.noreply.github.com>
Date: Tue Mar 7 07:17:34 2023 -0800
Unified Vision service 3/7 public preview release (#22950)
* Copy PRs from azure-rest-api-specs-pr.
* Merge VectorizeText and VectorizeImage APIs
* Add 'vectorize' to custom-words.txt
---------
Co-authored-by: shono <>
commit 4f97119261c5255091d75cf76a3da79c5954d7a4
Author: Lior Abadi <liorabadi@gmail.com>
Date: Tue Mar 7 09:17:53 2023 +0200
Storage Mover: Fix Projects Create Example (#22924)
Co-authored-by: Lior Abadi <liabadi@microsoft.com>
commit fbfcfd2df9357735a95fc0aba82dd4577ffc1e63
Author: Peng Jiahui <46921893+Alancere@users.noreply.github.com>
Date: Tue Mar 7 14:59:38 2023 +0800
[Go] config graphservicesprod readme.go.md (#22944)
commit 84261dbe443523e226f4f5ec55aee6175676715f
Author: Chenjie Shi <tadelesh.shi@live.cn>
Date: Tue Mar 7 14:59:26 2023 +0800
update metric version (#22939)
commit 902860572e43c439b2afa02c19dd0be3496ac32f
Author: YanjunGao <85206987+yanjungao718@users.noreply.github.com>
Date: Tue Mar 7 14:51:18 2023 +0800
update synapse contact (#22842)
commit 90ee6ae3e12e7ed385f1de94a41fcd9e38361a57
Author: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Date: Tue Mar 7 14:36:04 2023 +0800
change loadtesting catalog (#22592)
commit dbdac79ee734ab29a7af19172be78126977d7c57
Author: Ray Chen <raychen@microsoft.com>
Date: Tue Mar 7 14:31:41 2023 +0800
Update Semantic-and-Model-Violations-Reference.md (#22942)
add example for LRO_RESPONSE_HEADER fix.
commit 01c8d56b7540cb3d87c83be5c1ca5f25674178ed
Author: Mohit Makhija <mohitmakhija199@gmail.com>
Date: Tue Mar 7 11:48:40 2023 +0530
updated Resource ID in all example files for workload monitor (#22920)
* updated Resoutce ID in all example files for workload monitor api versions
* updated type for providers in examples Azure Monitor for SAP for api-version 2021-12-01-preview
* updated type for providers in examples Azure Monitor for SAP for api-version 2022-11-01-preview
* updated type for providers in examples Azure Monitor for SAP for api-version 2023-14-01
* updated type for monitor in examples Azure Monitor for SAP for api-version 2021-12-01-preview
* updated type for monitor in examples Azure Monitor for SAP for api-version 2022-12-01-preview
* updated type for monitor in examples Azure Monitor for SAP for api-version 2023-04-01
commit d6e5649022cacc7f39dda6e152b34c7315e9bf8c
Author: profDisarray <123163543+profDisarray@users.noreply.github.com>
Date: Tue Mar 7 11:09:12 2023 +0530
Rp soft delete (#22260)
* Adds base for updating Microsoft.RecoveryServices from version stable/2023-01-01 to version 2023-02-01
* Updates readme
* Updates API version in new specs and examples
* Adds RP Soft delete related API changes
* added ExtendedLocation to IaasVMRestoreRequest (#22468)
* fixed lint error (#22483)
* - adding changes for private endpoint support in get, list Rp and trigger restore.
* -fixing data type
* fixing validation errors
* Added changed for Secured VM details and Security Type (#22848)
---------
Co-authored-by: shesamian <107954668+shesamian@users.noreply.github.com>
Co-authored-by: Arpit Jain <46751982+arpja@users.noreply.github.com>
Co-authored-by: Saksham Arora <125243942+sakshamarora9575@users.noreply.github.com>
commit 2ac2c7d8cdd8ee5ceab9e05d91441e95eeb66910
Author: poshett <85922721+poshett@users.noreply.github.com>
Date: Tue Mar 7 10:47:32 2023 +0530
Adding version 2023-01-01-preview with User API Key changes for Elastic (#22638)
* Base API Commit
* Changing API version to 2023-02-01-preview
* Adding new getOrganizationApiKey post API
* Adding returnApiKey property in ElasticMonitorResource
* Updating getOrganizationApiKey URI
* Adding SubscriptionIdParameter in getOrganizationApiKey
* Renaming ex to Organizations_GetApiKey
* Updating description for UserApiKeyResponse
* Updating examples
* Updating readme.md
* Updated Depolyment Info, added marketplace info
* prettier check fixed
* model validation fixed
* validation fix
* prettier fix
* Increasing max length limit of companyName and business from 50 to 100
* Increasing companyName and business max length limits to 100 in all versions
* Revert "Increasing companyName and business max length limits to 100 in all versions"
This reverts commit c8977b64daa962bce70d33a325053294a4875610.
* Revert "Increasing max length limit of companyName and business from 50 to 100"
This reverts commit 7bd354775b3a57abf310a351c75763bc1aa121f3.
* Updating summary for getOrganizationApiKey
* Renaming "returnApiKey" to "generateApiKey"
* Adding "x-ms-secret": true for apiKey
* Updating getOrganizationApiKey API to /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Elastic/monitors/{monitorName}/getOrganizationApiKey
* Rearranging APIs
* Adding "consumes" to getOrganizationApiKey
* Changing case of emailId
* Moving the API under paths
* Updating User and Company related properties' max length limit to 64
* Adding Location in response header of LROs
* Updating getOrganizationApiKey path
* Updating getOrganizationApiKey Summary
---------
Co-authored-by: Rhea Hooda <rheahooda@microsoft.com>
commit 3a8cbd5a6969b9ae809dd361504ef475bdeb68c5
Author: Ray Chen <raychen@microsoft.com>
Date: Tue Mar 7 12:20:48 2023 +0800
Merge global package config (#22735)
* Merge global package config
* Added cadl-apiview package
commit 8af107b80ae16a7652d52ba879373b033b0e520d
Author: Wei Dong <40835867+dw511214992@users.noreply.github.com>
Date: Tue Mar 7 12:18:08 2023 +0800
update the doc of sdk automation pipeline (#22812)
* update the doc of sdk automation pipeline
* Update GenerateInputSchema.json
* Update README.md
* Update README.md
commit 149f607f45e76218f0fedff31388270ad1bb055a
Author: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Date: Tue Mar 7 12:06:57 2023 +0800
Update pull_request_assignment.yml (#22817)
commit bbba66026d7a271c80c5cb4c9c0f92b8054133ba
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Tue Mar 7 11:51:09 2023 +0800
Update readme.python.md (#22912)
commit f6d16956a7d5b75e125a88d81d7bc9b6fecfd41a
Author: gargankit-microsoft <88656868+gargankit-microsoft@users.noreply.github.com>
Date: Tue Mar 7 06:48:42 2023 +0530
removed locale (#22926)
commit c1bf995dbab472761ba4da53ed33c7b621ff8bd9
Author: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Date: Mon Mar 6 12:05:17 2023 -0800
Add missing closing brace (#22935)
commit 8539fe23e90aff363869fd21321b775ce2ccca8b
Author: Dan Liu <dandandanliu915@gmail.com>
Date: Tue Mar 7 01:28:27 2023 +0800
Sync Gen2 sas auth swagger to synapse (#22713)
* Sync Gen2 sas auth swagger to synapse
* Updated akv reference
---------
Co-authored-by: Dan Liu <liudan7@microsoft.com>
commit 9a59e9be953f01afd42cb7f0b2d18602f14c344a
Author: Osahumen Uyi Aghasomwan <65305780+osaghaso@users.noreply.github.com>
Date: Mon Mar 6 09:09:16 2023 -0800
Add email events to event grid (#22272)
* adding Email event
* adding Email event
* adding Email event
* fixing avocado failure
* fixing avocado failure
* fixing avocado failure
* making update to the sample json
* making update to the sample json
* making update to the sample json
* making update to the sample json
* remove unnessary definitations
* remove unnessary definitations
* adding x-ms-client-name se we dont change property casing
commit af5e3ff90dac7d0b8ae8d319bb2c16ffcdcc2bd6
Author: eladschwartz <116271996+eladschartz@users.noreply.github.com>
Date: Mon Mar 6 18:25:56 2023 +0200
[CPX-Marketplace-Catalog] 2023-01-01-preview (#21476)
* creating new public api version
* fixing validator issues
* fixing validator errors
* fixing string format errors
* fixing 404 in listing response
* modifying nextPageLink
* removing decimal from type description
* Adding descriptions to product entities
* removing a typo
* fixing camel case description
* description fixes
* removing cspState typo
* Updating name of returned catalog API entity
* Removing count from listing example
* removing unused query parameter
* Adding required fields and descriptions
* Making requested PR changes
* Wrapping error responses in default return value
* Removing explicit 400s from example responses
* removing x-nullable and testing odata naming
* adding more required fields
* Updating the products file to contain correct definitions
* Fixing listing example
* Fixing example for singlePublic flow
* Fixing validation issues
* Adding more validation fixes
* Fixing json reference in readme file
* Changing additionalProperties to additionalProductProperties
* Making some comment and description fixes
* fixing spelling errors
* fixing a small typo
* Adding technical descriptions
* Fixing typos
* Adding whitespace to descriptions
* Adding filterable fields examples
* Adding more descriptions
* Fixing some basic spelling errors
* Adding backticks to orderby
* Removing duplicates and fixing descriptions
* Adding custom word
* Fix filter description
* changing in to is
* Fixing second reviewer comments
* make tests run again
* reverting test word
* Revert "Fixing second reviewer comments"
This reverts commit 772d199a90094f46506ae6e0828a123856f9487e.
* Adding csv collection type
* Changing relevant OData types to array
* Removing $ from descriptions
* Fixing final PR comments
commit b0a96087a75bc286a7e2735f71872d63692c7baa
Author: singhabh27 <69506434+singhabh27@users.noreply.github.com>
Date: Mon Mar 6 14:58:36 2023 +0530
Review request for Microsoft.RecoveryServices to add version stable/2023-01-01 (#22076)
* Adds base for updating Microsoft.RecoveryServices from version stable/2022-10-01 to version 2023-01-01
* Updates readme
* Updates API version in new specs and examples
* CVM and OS Upgrade changes
* Update ReplicationProtectionContainers_SwitchProtection.json
Fixing swagger linting issue.
* Update service.json
Swagger correctness fix.
* Updated supportedOSVersions description.
* Taken up ARM feedback
* model validation fix
* Revert "model validation fix"
This reverts commit 98310580f5e72f932e7144f11c486261da1d3ed1.
* Fixing model validations
* Fixing ReplicationFabrics_Purge.json
* Fixing model validations
* RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE fix
* Adding Azure-AsyncOperation in header
* Fixing examples
---------
Co-authored-by: Pradheep Myaka <mpr4ul@outlook.com>
commit 241e964afe675a7be98aa6a2e171a3c5f830816c
Author: GalGoldi72 <124780962+GalGoldi72@users.noreply.github.com>
Date: Mon Mar 6 09:52:09 2023 +0200
[Hub Generated] Review request for Microsoft.Security to add version preview/2023-02-01-preview (#22797)
* Adds base for updating Microsoft.Security from version preview/2020-07-01-preview to version 2023-02-01-preview
* Updates readme
* Updates API version in new specs and examples
* Update new API version…
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…ew (Azure#22990) * health insights cadl + generated openapi spec * fix PR Comments * change country to countryOrRegion * split to multiple cadl projects * update cadl-project.yaml files * update example with generic contact details * update samples with generic contacts * convert cadl to typespec * update generated openapi spec * convert cadl to typespec (#4) * convert cadl to typespec * update generated openapi spec * move ClinicalNoteEvidence to common modules * remove redundant imports * fix typespec dependencies * remove dependencies from main.tsp * using rest * move imports from service.tsp to its caller * fix comment - directive error * remove imports from service.tsp
mikekistler
added
the
APIStewardshipBoard-SignedOff
|
Approval recorded in internal issue for API review. |
qiaozha
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Aug 18, 2023
### Packages impacted by this PR Health Insights CancerProfilingRest and ClinicalMatchingRest (new packages). ### Issues associated with this PR [[Cognitive Services - Health Decision Support] REST API Review · Issue #5731 · Azure/azure-rest-api-specs-pr (github.com)](Azure/azure-rest-api-specs-pr#5731) ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Provide a list of related PRs _(if any)_ [[Cognitive Services - Health Insights] CADL revision for public preview by asaflevi-ms · Pull Request #22990 · Azure/azure-rest-api-specs (github.com)](Azure/azure-rest-api-specs#22990) --------- Co-authored-by: Asaf Levi <asaflevi@microsoft.com> Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
dgetu
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 6, 2023
### Packages impacted by this PR Health Insights CancerProfilingRest and ClinicalMatchingRest (new packages). ### Issues associated with this PR [[Cognitive Services - Health Decision Support] REST API Review · Issue #5731 · Azure/azure-rest-api-specs-pr (github.com)](Azure/azure-rest-api-specs-pr#5731) ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Provide a list of related PRs _(if any)_ [[Cognitive Services - Health Insights] CADL revision for public preview by asaflevi-ms · Pull Request #22990 · Azure/azure-rest-api-specs (github.com)](Azure/azure-rest-api-specs#22990) --------- Co-authored-by: Asaf Levi <asaflevi@microsoft.com> Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
Convert our current (approved) private preview OpenAPI to CADL, per Azure SDK team guidance.
This PR follows private PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/10411
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links